fix: Fix another round of avalonia flaky tests#2178
Merged
Conversation
maximilien-noal
approved these changes
May 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce Avalonia headless UI test flakiness by ensuring that deferred UI-thread work triggered by window closure is processed before the test tears down.
Changes:
- Added a shared
CloseWindowAndWaithelper to close windows and pump pending UI events. - Updated UI tests to use the new helper for deterministic cleanup.
- Ensured the headless infrastructure smoke test also pumps dispatcher jobs after closing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Spice86.Tests/UI/MemoryViewUiTests.cs | Uses CloseWindowAndWait for window cleanup after async UI interactions. |
| tests/Spice86.Tests/UI/HeadlessInfrastructureTests.cs | Pumps Dispatcher.UIThread jobs after closing the test window to reduce teardown races. |
| tests/Spice86.Tests/UI/BreakpointUiTestBase.cs | Introduces CloseWindowAndWait (Close + ProcessUiEvents) as a shared stabilization helper. |
| tests/Spice86.Tests/UI/BreakpointsViewUiTests.cs | Replaces direct window.Close() calls with CloseWindowAndWait across the test suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rationale behind Changes
Suggested Testing Steps