Remove outdated Ant and org.json references from writing-extensions.md#550
Open
nishitagajraj wants to merge 1 commit intoOpenRefine:masterfrom
Open
Remove outdated Ant and org.json references from writing-extensions.md#550nishitagajraj wants to merge 1 commit intoOpenRefine:masterfrom
nishitagajraj wants to merge 1 commit intoOpenRefine:masterfrom
Conversation
Removes outdated references to the Ant build system (build.xml) and old org.json library (JSONObject, JSONWriter) which were replaced in OpenRefine 3.1 and 3.2 respectively. Fixes OpenRefine#522
✅ Deploy Preview for openrefine-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tfmorris
requested changes
Mar 13, 2026
Member
tfmorris
left a comment
tfmorris
left a comment
There was a problem hiding this comment.
Thanks for reviewing and updating the documentation! I think it needs a little more work, but it's a good start.
|
|
||
| ``` | ||
| public void write(JSONWriter writer, Properties options) throws JSONException { | ||
| public void writeJSON(ObjectMapper writer) throws JsonProcessingException { |
Member
There was a problem hiding this comment.
Same comment as above. There is no writeJSON method. The documentation on migrating legacy extensions might have the necessary information which could be used to update this.
|
|
||
| ``` | ||
| static public OverlayModel reconstruct(JSONObject o) throws JSONException { | ||
| static public OverlayModel reconstruct(ObjectNode o) throws IOException { |
Member
There was a problem hiding this comment.
Thanks for identifying the obsolete reference, but the update isn't a one-to-one replacement. You'll need to check the new code to figure out the proper documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes outdated references to the Ant build system (build.xml) and old org.json library (JSONObject, JSONWriter) which were replaced in OpenRefine 3.1 and 3.2 respectively.
Fixes #522