-
Notifications
You must be signed in to change notification settings - Fork 141
Remove outdated Ant and org.json references from writing-extensions.md #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nishitagajraj
wants to merge
1
commit into
OpenRefine:master
Choose a base branch
from
nishitagajraj:nishitagajraj-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,7 +93,7 @@ sample-extension/ | |
|
|
||
| The sub-directory `MOD-INF` contains the Butterfly module's metadata and is what Butterfly looks for when it scans directories for modules. `MOD-INF` serves similar functions as `WEB-INF` in other web frameworks. | ||
|
|
||
| Java code is built into the sub-directory `classes` inside `MOD-INF`, and supporting external Java jars are in the `lib` sub-directory. Those will be automatically loaded by Butterfly. (The build.xml script is wired to compile into the `classes` sub-directory.) | ||
| Java code is built into the sub-directory `classes` inside `MOD-INF`, and supporting external Java jars are in the `lib` sub-directory. Those will be automatically loaded by Butterfly. (Maven is configured to compile into the `classes` sub-directory.) | ||
|
|
||
| Client-side code is in the inner `module` sub-directory. They can be plain old .html, .css, .js, and image files. There are also Velocity .vt files, but they need to be routed inside `MOD-INF/controller.js`. | ||
|
|
||
|
|
@@ -315,15 +315,15 @@ Packages.com.google.refine.model.Project.registerOverlayModel( | |
| Note that you register the **class** , not an instance. The class should implement the following static method for reconstructing an overlay model instance from a JSON blob: | ||
|
|
||
| ``` | ||
| static public OverlayModel reconstruct(JSONObject o) throws JSONException { | ||
| static public OverlayModel reconstruct(ObjectNode o) throws IOException { | ||
| ... | ||
| } | ||
| ``` | ||
|
|
||
| When the project gets saved, the overlay model instance's `write` method will be called: | ||
|
|
||
| ``` | ||
| public void write(JSONWriter writer, Properties options) throws JSONException { | ||
| public void writeJSON(ObjectMapper writer) throws JsonProcessingException { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above. There is no |
||
| ... | ||
| } | ||
| ``` | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for identifying the obsolete reference, but the update isn't a one-to-one replacement. You'll need to check the new code to figure out the proper documentation.