Skip to content

Add new STIG URL#2262

Merged
evgenyz merged 2 commits intoOpenSCAP:maint-1.3from
Mab879:fix_2261
Oct 8, 2025
Merged

Add new STIG URL#2262
evgenyz merged 2 commits intoOpenSCAP:maint-1.3from
Mab879:fix_2261

Conversation

@Mab879
Copy link
Copy Markdown
Member

@Mab879 Mab879 commented Oct 6, 2025

Fixes #2261

@evgenyz
Copy link
Copy Markdown
Contributor

evgenyz commented Oct 7, 2025

At this point with DISA mood for naming things swinging all over the place (3-rd URL to match) I wonder if we should make it a config file or something that'd allow users to amend things without rebuilding OpenSCAP.

Copy link
Copy Markdown
Contributor

@evgenyz evgenyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But okay, let's just have it for now.

BTW, what about https://github.com/OpenSCAP/openscap/blob/main/xsl/xccdf-references.xsl#L85?

@jan-cerny
Copy link
Copy Markdown
Member

At this point with DISA mood for naming things swinging all over the place (3-rd URL to match) I wonder if we should make it a config file or something that'd allow users to amend things without rebuilding OpenSCAP.

Great idea! You can have an environment variable that allow users to override the hard coded URL if a need arises in future. Using the environment variable they will be able to work around their problems until we update the package.

@Mab879
Copy link
Copy Markdown
Member Author

Mab879 commented Oct 7, 2025

But okay, let's just have it for now.

BTW, what about https://github.com/OpenSCAP/openscap/blob/main/xsl/xccdf-references.xsl#L85?

it doesn't even have the public.cyber.mil address, does this file even matter?

@evgenyz
Copy link
Copy Markdown
Contributor

evgenyz commented Oct 7, 2025

But okay, let's just have it for now.
BTW, what about https://github.com/OpenSCAP/openscap/blob/main/xsl/xccdf-references.xsl#L85?

it doesn't even have the public.cyber.mil address, does this file even matter?

The references-to-json template is used in report generation (maybe some JS is not working properly).

Copy link
Copy Markdown
Contributor

@evgenyz evgenyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@evgenyz evgenyz merged commit 6c9d478 into OpenSCAP:maint-1.3 Oct 8, 2025
8 of 10 checks passed
@Mab879 Mab879 deleted the fix_2261 branch October 8, 2025 11:30
@Mab879 Mab879 mentioned this pull request Oct 8, 2025
@Mab879 Mab879 added this to the 1.3.13 milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants