Parse set values (#25)

* Parse set values

* Add selectors module

Author: xprazak2

lib/openscap_parser/profile.rb

@@ -24,13 +24,6 @@ def selected_rule_ids
         @parsed_xml.xpath("select[@selected='true']/@idref").map(&:text)
     end
 
-    def set_values
-      @set_values ||= @parsed_xml.xpath("set-value") &&
-        @parsed_xml.xpath("set-value").map do |set_value|
-        [set_value['idref'], set_value.text]
-      end.to_h
-    end
-
     def to_h
       { :id => id, :title => title, :description => description }
     end

lib/openscap_parser/rule.rb

@@ -54,5 +54,17 @@ def rule_identifier
     def identifier_node
       @identifier_node ||= parsed_xml.at_xpath('ident')
     end
+
+    def to_h
+      {
+        :id => id,
+        :selected => selected,
+        :severity => severity,
+        :title => title,
+        :description => description,
+        :rationale => rationale,
+        :identifier => rule_identifier.to_h
+      }
+    end
   end
 end

lib/openscap_parser/rule_identifier.rb

@@ -10,5 +10,12 @@ def label
     def system
       @system ||= @parsed_xml && @parsed_xml['system']
     end
+
+    def to_h
+      {
+        :label => label,
+        :system => system
+      }
+    end
   end
 end

lib/openscap_parser/selectors.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require 'openscap_parser/set_values'
+
+module OpenscapParser
+  module Selectors
+    include OpenscapParser::SetValues
+  end
+end

lib/openscap_parser/set_value.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+require 'openscap_parser/xml_node'
+
+module OpenscapParser
+  class SetValue < XmlNode
+    def id
+      @id ||= @parsed_xml['idref']
+    end
+
+    def text
+      @text ||= @parsed_xml.text
+    end
+
+    def to_h
+      { :id => id, :text => text }
+    end
+  end
+end

lib/openscap_parser/set_values.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require 'openscap_parser/set_value'
+
+module OpenscapParser
+  module SetValues
+    def self.included(base)
+      base.class_eval do
+        def set_values
+          @set_values ||= set_value_nodes.map do |set_value_node|
+            OpenscapParser::SetValue.new(parsed_xml: set_value_node)
+          end
+        end
+
+        def set_value_nodes(xpath = ".//set-value")
+          xpath_nodes(xpath)
+        end
+      end
+    end
+  end
+end

lib/openscap_parser/test_result.rb

@@ -1,10 +1,12 @@
 # frozen_string_literal: true
 
 require 'openscap_parser/rule_results'
+require 'openscap_parser/selectors'
 
 module OpenscapParser
   class TestResult < XmlNode
     include OpenscapParser::RuleResults
+    include OpenscapParser::Selectors
 
     def target
       @target ||= parsed_xml.at_xpath('target') &&

test/fixtures/files/arf_report_cs2.xml

@@ -7,6 +7,10 @@ def setup
     @test_result_file = OpenscapParser::TestResultFile.new(
       file_fixture('xccdf_report.xml').read
     )
+
+    @arf_result_file = OpenscapParser::TestResultFile.new(
+      file_fixture('arf_report_cs2.xml').read
+    )
   end
 
   context 'benchmark' do
@@ -93,6 +97,43 @@ def setup
     end
 
     context 'rules' do
+      test 'should parse rules for xccdf report' do
+        parse_rules @test_result_file
+      end
+
+      test 'should parse rules for arf report' do
+        parse_rules @arf_result_file
+      end
+    end
+
+    context 'set values' do
+      test 'should parse set values for xccdf report' do
+        parse_set_values @test_result_file
+      end
+
+      test 'should parse set values for arf report' do
+        parse_set_values @arf_result_file
+      end
     end
   end
+
+  def parse_set_values(result_file)
+    set_values = result_file.test_result.set_values.map(&:to_h)
+    idrefs = set_values.map { |val| val[:id] }
+    texts = set_values.map { | val| val[:text] }
+    refute_empty set_values
+    assert_equal idrefs, idrefs.compact
+    assert_equal texts, texts.compact
+  end
+
+  def parse_rules(result_file)
+    rules = result_file.benchmark.rules.map(&:to_h)
+    ids = rules.map { |rule| rule[:id] }
+    titles = rules.map { |rule| rule[:title] }
+    selected = rules.map { |rule| rule[:selected] }
+    refute_empty rules
+    assert_equal ids, ids.compact
+    assert_equal titles, titles.compact
+    assert_equal selected, selected.compact
+  end
 end