[WIP] Enhance MTLN performance#401
Draft
lmdiazangulo wants to merge 5 commits into
Draft
Conversation
… unnecessary computations Co-authored-by: Copilot <copilot@github.com>
lmdiazangulo
changed the title
- Add termination_handler.F90: Fortran-based solvers for simple RLC terminations (types 1-10: SHORT, OPEN, SERIES, PARALLEL, and complex RLC combinations) - Add benchmark.F90: Timing utilities for performance measurement - Modify network.F90: Add termination type and component values to nw_node_t - Modify network_manager.F90: Implement hybrid approach using Fortran for simple terminations and ngspice only for complex ones (CIRCUIT, NETWORK) - Modify preprocess.F90: Populate termination info when creating network nodes - All 31 MTLN tests pass with the new implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiling seems to show that the problem is with ngspice. A possible solution would be to keep calls to it at minimum. Just when the input contains "circuits" which require it.