fix: Correct domain release on TLS switch failure in tls_sni_cb

rrb3942 · aider-chat-bot · rrb3942 · commit 30b56bc8384a · 2025-11-14T15:00:21.000-08:00
Co-authored-by: aider (gemini/gemini-2.5-pro) &lt;aider@aider.chat&gt;
diff --git a/modules/tls_mgm/tls_mgm.c b/modules/tls_mgm/tls_mgm.c
@@ -583,11 +583,11 @@ int tls_sni_cb(struct tls_domain *dom, struct tcp_connection *c,
 			rc = wolfssl_api.switch_ssl_ctx(new_dom, ssl_ctx);
 		} else {
 			LM_CRIT("No TLS library module loaded\n");
-			tls_release_domain(dom);
+			tls_release_domain(new_dom);
 			return -1;
 		}
 		if (rc < 0) {
-			tls_release_domain(dom);
+			tls_release_domain(new_dom);
 			return -1;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -583,11 +583,11 @@ int tls_sni_cb(struct tls_domain dom, struct tcp_connection c,`
`583`	`583`	`rc = wolfssl_api.switch_ssl_ctx(new_dom, ssl_ctx);`
`584`	`584`	`} else {`
`585`	`585`	`LM_CRIT("No TLS library module loaded\n");`
`586`		`- tls_release_domain(dom);`
	`586`	`+ tls_release_domain(new_dom);`
`587`	`587`	`return -1;`
`588`	`588`	`}`
`589`	`589`	`if (rc < 0) {`
`590`		`- tls_release_domain(dom);`
	`590`	`+ tls_release_domain(new_dom);`
`591`	`591`	`return -1;`
`592`	`592`	`}`
`593`	`593`