[b2b_entities] avoid sending 408 on a completed transaction

upon entities cleanup, is the UAS/UPDATE transactions are completed, just unref without sending a 408.
Reported by @davegreeko2023
Fixes #3899

Author: bogdan-iancu

modules/b2b_entities/dlg.c

@@ -2229,29 +2229,39 @@ void b2b_delete_record(b2b_dlg_t* dlg, b2b_table htable, unsigned int hash_index
 		shm_free(dlg->logic_key.s);
 
 	if(dlg->uas_tran) {
-		tmb.unref_cell(dlg->uas_tran);
 
-		pto = get_to(dlg->uas_tran->uas.request);
-		if (pto == NULL || pto->error != PARSE_OK) {
-			LM_ERR("'To' header COULD NOT be parsed\n");
-		} else {
-			if (run_tm_api(&tmb, t_reply_with_body, dlg->uas_tran, 408, &reply_text, 0, 0,
-				&pto->tag_value) < 0)
-				LM_ERR("Failed to send 408 reply\n");
+		/* if we come across an already finally replied trans,
+		 * just release it; otherwise send 408 */
+		if ( dlg->uas_tran->uas.status<200) {
+			pto = get_to(dlg->uas_tran->uas.request);
+			if (pto == NULL || pto->error != PARSE_OK) {
+				LM_ERR("'To' header COULD NOT be parsed\n");
+			} else {
+				if (run_tm_api(&tmb, t_reply_with_body, dlg->uas_tran,
+				408, &reply_text, 0, 0, &pto->tag_value) < 0)
+					LM_ERR("Failed to send 408 reply\n");
+			}
 		}
+
+		tmb.unref_cell(dlg->uas_tran);
 	}
 
 	if (dlg->update_tran) {
-		tmb.unref_cell(dlg->update_tran);
 
-		pto = get_to(dlg->update_tran->uas.request);
-		if (pto == NULL || pto->error != PARSE_OK) {
-			LM_ERR("'To' header COULD NOT be parsed\n");
-		} else {
-			if (run_tm_api(&tmb, t_reply_with_body, dlg->update_tran, 408, &reply_text, 0, 0,
-				&pto->tag_value) < 0)
-				LM_ERR("Failed to send 408 reply\n");
+		/* if we come across an already finally replied trans,
+		 * just release it; otherwise send 408 */
+		if ( dlg->update_tran->uas.status<200) {
+			pto = get_to(dlg->update_tran->uas.request);
+			if (pto == NULL || pto->error != PARSE_OK) {
+				LM_ERR("'To' header COULD NOT be parsed\n");
+			} else {
+				if (run_tm_api(&tmb, t_reply_with_body, dlg->update_tran,
+				408, &reply_text, 0, 0, &pto->tag_value) < 0)
+					LM_ERR("Failed to send 408 reply\n");
+			}
 		}
+
+		tmb.unref_cell(dlg->update_tran);
 	}
 
 	if(dlg->ack_sdp.s)