Fix buffer overflow in dnscache (#3669)#3672
Merged
Merged
Conversation
`addr_no` and `alias_no` are calculated based on whichever is smaller out of the actual number of addresses/aliases, and `MAXADDRS-1`/`MAXALIASES-1`. But then the code inserted all of the actual number of addresses/aliases anyway, which makes for a potential buffer overflow, and corrupted deserialisation later.
Member
NormB
pushed a commit
to NormB/opensips
that referenced
this pull request
May 9, 2026
Fix buffer overflow in dnscache (OpenSIPS#3669)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix buffer overflow in dnscache (#3669)
@pb-dstny wrote this fix for our internal use.
Details
addr_noandalias_noare calculated based on whichever is smaller out of the actual number of addresses/aliases, andMAXADDRS-1/MAXALIASES-1.But then the code inserted all of the actual number of addresses/aliases anyway, which makes for a potential buffer overflow, and corrupted deserialisation later.
Solution
This PR fixes the problem by using the calculated values of
addr_noandalias_no.Compatibility
Closing issues
closes #3669