event_flatstore: fix rotation handling and add optional file headers#3870
Open
nikbyte wants to merge 1 commit intoOpenSIPS:masterfrom
Open
event_flatstore: fix rotation handling and add optional file headers#3870nikbyte wants to merge 1 commit intoOpenSIPS:masterfrom
nikbyte wants to merge 1 commit intoOpenSIPS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains several fixes and small improvements for
event_flatstore.Details
The main goal of this PR is to make file rotation more reliable and predictable, and to add a small usability improvement for generated log files.
It also fixes a few smaller issues in the module implementation.
Solution
The changes include:
headerparameter, which writes a first line to newly created log files;Compatibility
The change is backward-compatible.
The new
headerparameter is optional and disabled by default, so existing configurations will continue to work as before.Closing issues
N/A