fix(builder): #585

Author: thundax-lyp

builder/runner/local/src/main/java/com/antgroup/openspg/builder/runner/local/physical/sink/impl/Neo4jSinkWriter.java

@@ -51,15 +51,15 @@ public class Neo4jSinkWriter extends BaseSinkWriter<Neo4jSinkNodeConfig> {
   private Project project;
   private static final String DOT = ".";
 
-  private static RejectedExecutionHandler handler =
+  private static final RejectedExecutionHandler handler =
       (r, executor) -> {
         try {
           executor.getQueue().put(r);
         } catch (InterruptedException e) {
           Thread.currentThread().interrupt();
         }
       };
-  private static ExecutorService executor =
+  private static final ExecutorService executor =
       new ThreadPoolExecutor(
           NUM_THREADS,
           NUM_THREADS,
@@ -169,7 +169,7 @@ private void awaitAllTasks(List<Future<Void>> futures)
 
   private void writeNode(SubGraphRecord.Node node) {
     try {
-      Long statr = System.currentTimeMillis();
+      long start = System.currentTimeMillis();
       RecordAlterOperationEnum operation = context.getOperation();
       if (StringUtils.isBlank(node.getId())
           || StringUtils.isBlank(node.getName())
@@ -184,7 +184,7 @@ private void writeNode(SubGraphRecord.Node node) {
       List<LPGPropertyRecord> properties = Lists.newArrayList();
       for (Map.Entry<String, Object> entry : node.getProperties().entrySet()) {
         Object entryValue = entry.getValue();
-        if (!TypeChecker.isArrayOrCollectionOfPrimitives(entryValue)) {
+        if (!TypeChecker.isBasicType(entryValue)) {
           entryValue = JSON.toJSONString(entryValue);
         }
         properties.add(new LPGPropertyRecord(entry.getKey(), entryValue));
@@ -199,7 +199,7 @@ private void writeNode(SubGraphRecord.Node node) {
       log.info(
           String.format(
               "write Node succeed id:%s cons:%s",
-              node.getId(), System.currentTimeMillis() - statr));
+              node.getId(), System.currentTimeMillis() - start));
     } catch (Exception e) {
       throw new RuntimeException(e);
     }
@@ -214,7 +214,7 @@ private String labelPrefix(String label) {
 
   private void writeEdge(SubGraphRecord.Edge edge) {
     try {
-      Long statr = System.currentTimeMillis();
+      long start = System.currentTimeMillis();
       RecordAlterOperationEnum operation = context.getOperation();
       if (StringUtils.isBlank(edge.getFrom())
           || StringUtils.isBlank(edge.getTo())
@@ -226,7 +226,7 @@ private void writeEdge(SubGraphRecord.Edge edge) {
       List<LPGPropertyRecord> properties = Lists.newArrayList();
       for (Map.Entry<String, Object> entry : edge.getProperties().entrySet()) {
         Object entryValue = entry.getValue();
-        if (!TypeChecker.isArrayOrCollectionOfPrimitives(entryValue)) {
+        if (!TypeChecker.isBasicType(entryValue)) {
           entryValue = JSON.toJSONString(entryValue);
         }
         properties.add(new LPGPropertyRecord(entry.getKey(), entryValue));
@@ -244,9 +244,10 @@ private void writeEdge(SubGraphRecord.Edge edge) {
         client.deleteEdge(edge.getLabel(), edgeRecords);
       }
       log.info(
-          String.format(
-              "write Edge succeed from:%s to:%s cons:%s",
-              edge.getFrom(), edge.getTo(), System.currentTimeMillis() - statr));
+          "write Edge succeed from:{} to:{} cons:{}",
+          edge.getFrom(),
+          edge.getTo(),
+          System.currentTimeMillis() - start);
     } catch (Exception e) {
       throw new RuntimeException(e);
     }

cloudext/interface/graph-store/src/main/java/com/antgroup/openspg/cloudext/interfaces/graphstore/util/TypeChecker.java

@@ -66,4 +66,36 @@ public static boolean isArrayOrCollectionOfPrimitives(Object obj) {
     }
     return false;
   }
+
+  public static boolean isBasicType(Object obj) {
+    if (obj == null) {
+      return false;
+    }
+    if (obj instanceof Object[]) {
+      for (Object element : (Object[]) obj) {
+        if (!isBasicType(element)) {
+          return false;
+        }
+      }
+      return true;
+
+    } else if (obj instanceof Collection<?>) {
+      for (Object element : (Collection<?>) obj) {
+        if (!isBasicType(element)) {
+          return false;
+        }
+      }
+      return true;
+    }
+
+    return obj.getClass().isPrimitive()
+        || obj instanceof Integer
+        || obj instanceof Double
+        || obj instanceof Float
+        || obj instanceof Long
+        || obj instanceof Byte
+        || obj instanceof Boolean
+        || obj instanceof Character
+        || obj instanceof CharSequence;
+  }
 }