fix(spp_drims): fix 3 critical audit issues

- Add missing data/approval_definitions.xml to manifest
- Fix alert search filters: alert_type → alert_type_id.code
- Add @api.depends("sla_due_datetime") to _compute_sla_hours_remaining

Author: emjay0921

spp_drims/__manifest__.py

@@ -43,6 +43,7 @@
         "data/audit_rules.xml",
         "data/config_defaults.xml",
         "data/gis_report_templates.xml",
+        "data/approval_definitions.xml",
         # Reports (before views, as views may reference report actions)
         "report/waybill_template.xml",
         "views/dashboard_views.xml",

spp_drims/models/request.py

@@ -348,6 +348,7 @@ def _compute_sla_status(self):
                 rec.sla_due_datetime = False
                 rec.sla_status = False
 
+    @api.depends("sla_due_datetime")
     def _compute_sla_hours_remaining(self):
         """Compute hours remaining until SLA breach."""
         now = fields.Datetime.now()

spp_drims/views/alert_views.xml

@@ -289,17 +289,17 @@
                 <filter
                     name="filter_low_stock"
                     string="Low Stock"
-                    domain="[('alert_type', '=', 'low_stock')]"
+                    domain="[('alert_type_id.code', '=', 'low_stock')]"
                 />
                 <filter
                     name="filter_expiry"
                     string="Expiry"
-                    domain="[('alert_type', '=', 'expiry')]"
+                    domain="[('alert_type_id.code', '=', 'expiry')]"
                 />
                 <filter
                     name="filter_sla"
                     string="SLA"
-                    domain="[('alert_type', 'in', ['sla_warning', 'sla_breach'])]"
+                    domain="[('alert_type_id.code', 'in', ['sla_warning', 'sla_breach'])]"
                 />
                 <separator />