Commit 0c2bcd2
committed
test(spp_import_match): update conditional-match test for new pure-gate semantics (OP#991)
CI surfaced a regression in test_match_find_conditional_match. The
test was written under the pre-OP#991 semantics where an
`is_conditional=True` row contributed BOTH a gate (CSV value check)
AND a search predicate (`field_id` added to the search domain). The
OP#991 fix (commit da3f563) intentionally removes that dual role —
conditional rows are now pure gates, never injected into the domain.
Under the new semantics, a rule with only one conditional row produces
an empty search domain and is skipped (the existing `if not domain:
continue` guard at line 109). The test's assertion that the partner
would be found is therefore obsolete.
Rewrite the test to demonstrate the new gate + non-conditional-search
shape: a conditional row gates on `name`, and a non-conditional row
provides the actual `email` search predicate. Verifies the gate-
passing path while respecting the OP#991 semantics. Sibling test
test_match_find_conditional_skip (gate-failing path) still passes
unchanged.
44 tests, 0 failed locally.1 parent 7d7c879 commit 0c2bcd2
1 file changed
Lines changed: 17 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | | - | |
124 | | - | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
125 | 136 | | |
126 | 137 | | |
127 | 138 | | |
128 | 139 | | |
129 | 140 | | |
130 | 141 | | |
131 | | - | |
| 142 | + | |
| 143 | + | |
132 | 144 | | |
133 | 145 | | |
134 | 146 | | |
135 | 147 | | |
136 | | - | |
137 | | - | |
| 148 | + | |
| 149 | + | |
138 | 150 | | |
139 | 151 | | |
140 | 152 | | |
| |||
0 commit comments