Merge pull request #129 from OpenSPP/fix/serialize-detail-skip-before-getattr

fix: skip field types before getattr and isolate detail prefetch

Author: emjay0921

spp_api_v2_change_request/__manifest__.py

@@ -1,7 +1,7 @@
 {  # pylint: disable=pointless-statement
     "name": "OpenSPP API V2 - Change Request",
     "category": "OpenSPP/Integration",
-    "version": "19.0.2.0.0",
+    "version": "19.0.2.0.1",
     "sequence": 1,
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/OpenSPP2",

spp_api_v2_change_request/services/change_request_service.py

@@ -204,10 +204,17 @@ def _serialize_detail(self, detail) -> dict[str, Any]:
         # Get fields from the model
         model_fields = detail._fields
 
+        # Field types that are skipped entirely — check BEFORE reading the
+        # value so that computed fields of these types are never triggered.
+        _SKIP_FIELD_TYPES = {"many2many", "one2many", "binary"}
+
         for field_name, field in model_fields.items():
             if field_name.startswith("_") or field_name in DETAIL_SKIP_FIELDS:
                 continue
 
+            if field.type in _SKIP_FIELD_TYPES:
+                continue
+
             value = getattr(detail, field_name)
 
             if field.type == "many2one":
@@ -230,19 +237,10 @@ def _serialize_detail(self, detail) -> dict[str, Any]:
                         }
                     else:
                         result[field_name] = value.name if hasattr(value, "name") else str(value.id)
-            elif field.type == "many2many":
-                # Skip many2many for now
-                continue
-            elif field.type == "one2many":
-                # Skip one2many for now
-                continue
             elif field.type == "date":
                 result[field_name] = value.isoformat() if value else None
             elif field.type == "datetime":
                 result[field_name] = value.isoformat() if value else None
-            elif field.type == "binary":
-                # Skip binary fields in API
-                continue
             else:
                 result[field_name] = value
 

spp_change_request_v2/__manifest__.py

@@ -1,6 +1,6 @@
 {
     "name": "OpenSPP Change Request V2",
-    "version": "19.0.2.0.0",
+    "version": "19.0.2.0.1",
     "sequence": 50,
     "category": "OpenSPP",
     "summary": "Configuration-driven change request system with UX improvements, conflict detection and duplicate prevention",

spp_change_request_v2/models/change_request.py

@@ -713,10 +713,15 @@ def _create_dms_directory(self):
     # ══════════════════════════════════════════════════════════════════════════
 
     def get_detail(self):
-        """Get the detail record for this CR."""
+        """Get the detail record for this CR.
+
+        Uses with_prefetch() to isolate from _ensure_detail's sudo()
+        prefetch set — without this, non-stored computed fields can
+        trigger record-rule checks against the wrong user.
+        """
         self.ensure_one()
         if self.detail_res_model and self.detail_res_id:
-            return self.env[self.detail_res_model].browse(self.detail_res_id)
+            return self.env[self.detail_res_model].browse(self.detail_res_id).with_prefetch()
         return None
 
     def _ensure_detail(self):