Merge pull request #12 from OpenSPP/feat/spp-alerts-rule-evaluation-beta

feat(spp_alerts): add rule evaluation engine and promote to Beta

Author: gonzalesedwin1123

spp_alerts/README.rst

@@ -14,9 +14,9 @@ OpenSPP Alerts
    !! source digest: sha256:7186687b7752640f90d9d124b0fc91967afaef27e84c13f22cbed7954ae9b438
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
-.. |badge1| image:: https://img.shields.io/badge/maturity-Alpha-red.png
+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
-    :alt: Alpha
+    :alt: Beta
 .. |badge2| image:: https://img.shields.io/badge/license-LGPL--3-blue.png
     :target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html
     :alt: License: LGPL-3
@@ -103,11 +103,6 @@ Dependencies
 
 ``base``, ``mail``, ``spp_security``, ``spp_vocabulary``
 
-.. IMPORTANT::
-   This is an alpha version, the data model and design can change at any time without warning.
-   Only for development or testing purpose, do not use in production.
-   `More details on development status <https://odoo-community.org/page/development-status>`_
-
 **Table of contents**
 
 .. contents::

spp_alerts/__manifest__.py

@@ -9,7 +9,7 @@
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/OpenSPP2",
     "license": "LGPL-3",
-    "development_status": "Alpha",
+    "development_status": "Beta",
     "maintainers": ["jeremi", "gonzalesedwin1123", "emjay0921"],
     "depends": [
         "base",
@@ -26,6 +26,7 @@
         "data/ir_sequence.xml",
         "data/vocabulary_namespaces.xml",
         "data/vocabulary_codes.xml",
+        "data/ir_cron.xml",
         # Views
         "views/alert_views.xml",
         "views/alert_rule_views.xml",

spp_alerts/data/ir_cron.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo noupdate="1">
+    <!-- Generic Alert Rule Evaluation Cron -->
+    <record id="cron_evaluate_alert_rules" model="ir.cron">
+        <field name="name">Alerts: Evaluate Alert Rules</field>
+        <field name="model_id" ref="model_spp_alert_rule" />
+        <field name="state">code</field>
+        <field name="code">model._cron_evaluate_rules()</field>
+        <field name="interval_number">1</field>
+        <field name="interval_type">days</field>
+        <field name="active" eval="True" />
+    </record>
+</odoo>

spp_alerts/models/alert.py

@@ -2,6 +2,7 @@
 import logging
 
 from odoo import _, api, fields, models
+from odoo.exceptions import UserError
 
 _logger = logging.getLogger(__name__)
 
@@ -94,6 +95,31 @@ class Alert(models.Model):
         help="Detailed description of the alert condition",
     )
 
+    # Source tracking (populated by rule engine, empty for manual alerts)
+    rule_id = fields.Many2one(
+        "spp.alert.rule",
+        string="Source Rule",
+        index=True,
+        readonly=True,
+        ondelete="set null",
+        help="Alert rule that generated this alert (empty for manually created alerts)",
+    )
+
+    res_model = fields.Char(
+        string="Source Model",
+        index=True,
+        readonly=True,
+        help="Technical model name of the record that triggered this alert",
+    )
+
+    res_id = fields.Many2oneReference(
+        string="Source Record",
+        model_field="res_model",
+        index=True,
+        readonly=True,
+        help="Record that triggered this alert",
+    )
+
     # Metrics for threshold and deadline tracking
     current_value = fields.Float(
         string="Current Value",
@@ -144,7 +170,9 @@ def create(self, vals_list):
         for vals in vals_list:
             if vals.get("reference", _("New")) == _("New"):
                 # Use sudo to access sequence (users may not have ir.sequence access)
-                vals["reference"] = self.env["ir.sequence"].sudo().next_by_code("spp.alert") or _("New")
+                # nosemgrep: odoo-sudo-without-context - Standard sequence access
+                Sequence = self.env["ir.sequence"].sudo()
+                vals["reference"] = Sequence.next_by_code("spp.alert") or _("New")
         return super().create(vals_list)
 
     def action_acknowledge(self):
@@ -164,7 +192,15 @@ def action_resolve(self, notes=None):
 
         Returns:
             bool: True on success
+
+        Raises:
+            UserError: If resolution notes are not provided.
         """
+        for record in self:
+            resolution = notes or record.resolution_notes
+            if not resolution:
+                raise UserError(_("Please provide resolution notes before resolving the alert."))
+
         vals = {
             "state": "resolved",
             "resolved_by_id": self.env.user.id,