Skip to content

Commit 3258a93

Browse files
gonzalesedwin1123gonzalesedwin1123
authored
Merge pull request #33 from OpenSPP/fix/cr-no-create-no-open-lookup-fields
fix(spp_change_request_v2): add no_create/no_open to lookup fields in CR detail views
2 parents bf42ea2 + b2d2b05 commit 3258a93

9 files changed

+37
-16
lines changed

‎spp_change_request_v2/views/detail_add_member_views.xml‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,14 @@
4747
</group>
4848
<group>
4949
<field name="birthdate" />
50-
<field name="gender_id" />
51-
<field name="relationship_id" />
50+
<field
51+
name="gender_id"
52+
options="{'no_create': True, 'no_open': True}"
53+
/>
54+
<field
55+
name="relationship_id"
56+
options="{'no_create': True, 'no_open': True}"
57+
/>
5258
</group>
5359
</group>
5460

‎spp_change_request_v2/views/detail_change_hoh_views.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
<group string="Previous Head Reassignment">
5656
<field
5757
name="previous_head_new_role_id"
58-
options="{'no_create': True}"
58+
options="{'no_create': True, 'no_open': True}"
5959
/>
6060
</group>
6161
</group>

‎spp_change_request_v2/views/detail_create_group_views.xml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<group>
3232
<group string="Group Information">
3333
<field name="group_name" required="1" />
34-
<field name="group_type_id" options="{'no_create': True}" />
34+
<field name="group_type_id" options="{'no_create': True, 'no_open': True}" />
3535
</group>
3636
<group string="Contact">
3737
<field name="phone" />
@@ -61,7 +61,7 @@
6161
<field name="head_birthdate" />
6262
<field
6363
name="head_gender_id"
64-
options="{'no_create': True}"
64+
options="{'no_create': True, 'no_open': True}"
6565
/>
6666
<field name="head_phone" />
6767
</group>
@@ -75,9 +75,9 @@
7575
<field name="city" />
7676
</group>
7777
<group>
78-
<field name="state_id" options="{'no_create': True}" />
78+
<field name="state_id" options="{'no_create': True, 'no_open': True}" />
7979
<field name="postal_code" />
80-
<field name="country_id" options="{'no_create': True}" />
80+
<field name="country_id" options="{'no_create': True, 'no_open': True}" />
8181
</group>
8282
</group>
8383

‎spp_change_request_v2/views/detail_edit_individual_views.xml‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@
4444
<field name="given_name" required="1" />
4545
<field name="family_name" required="1" />
4646
<field name="birthdate" />
47-
<field name="gender_id" />
47+
<field
48+
name="gender_id"
49+
options="{'no_create': True, 'no_open': True}"
50+
/>
4851
</group>
4952
<group>
5053
<field name="phone" />

‎spp_change_request_v2/views/detail_exit_registrant_views.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
<field
5656
name="destination_country_id"
5757
invisible="exit_reason != 'emigrated'"
58+
options="{'no_create': True, 'no_open': True}"
5859
/>
5960
</group>
6061
<group string="Options">

‎spp_change_request_v2/views/detail_merge_registrants_views.xml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,11 @@
4040

4141
<group>
4242
<group string="Primary Registrant (Keep)">
43-
<field name="primary_registrant_id" required="1" />
43+
<field
44+
name="primary_registrant_id"
45+
required="1"
46+
options="{'no_create': True, 'no_open': True}"
47+
/>
4448
<field name="primary_name" invisible="1" />
4549
<field name="is_group_merge" invisible="1" />
4650
<field name="available_duplicate_ids" invisible="1" />

‎spp_change_request_v2/views/detail_split_household_views.xml‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,11 @@
4747

4848
<group>
4949
<group string="Source Household">
50-
<field name="source_group_id" required="1" />
50+
<field
51+
name="source_group_id"
52+
required="1"
53+
options="{'no_create': True, 'no_open': True}"
54+
/>
5155
<field name="source_group_name" invisible="1" />
5256
<field name="available_member_ids" invisible="1" />
5357
<field name="members_to_split_ids" invisible="1" />
@@ -89,7 +93,7 @@
8993
<field name="new_group_name" required="1" />
9094
<field
9195
name="new_group_type_id"
92-
options="{'no_create': True}"
96+
options="{'no_create': True, 'no_open': True}"
9397
/>
9498
</group>
9599
<group>
@@ -104,9 +108,9 @@
104108
<field name="city" />
105109
</group>
106110
<group string="Location">
107-
<field name="state_id" options="{'no_create': True}" />
111+
<field name="state_id" options="{'no_create': True, 'no_open': True}" />
108112
<field name="postal_code" />
109-
<field name="country_id" options="{'no_create': True}" />
113+
<field name="country_id" options="{'no_create': True, 'no_open': True}" />
110114
</group>
111115
<group string="Contact">
112116
<field name="phone" />

‎spp_change_request_v2/views/detail_transfer_member_views.xml‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@
3030
<sheet>
3131
<group>
3232
<group string="Source">
33-
<field name="source_group_id" />
33+
<field
34+
name="source_group_id"
35+
options="{'no_create': True, 'no_open': True}"
36+
/>
3437
<field name="available_individual_ids" invisible="1" />
3538
<field
3639
name="individual_id"
@@ -47,7 +50,7 @@
4750
options="{'no_create': True}"
4851
required="1"
4952
/>
50-
<field name="new_role_id" options="{'no_create': True}" />
53+
<field name="new_role_id" options="{'no_create': True, 'no_open': True}" />
5154
</group>
5255
</group>
5356
<group>

‎spp_change_request_v2/views/detail_update_id_views.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
</group>
5252
<group invisible="operation == 'remove'">
5353
<group string="ID Information">
54-
<field name="id_type_id" options="{'no_create': True}" />
54+
<field name="id_type_id" options="{'no_create': True, 'no_open': True}" />
5555
<field name="id_value" required="operation == 'add'" />
5656
<field name="expiry_date" />
5757
</group>

0 commit comments

Comments
 (0)