fix(cr): fix pre-commit CI failures and address review comments

- Fix ruff E501: break long domain strings in add_member, change_hoh, transfer_member
- Fix ruff F841: prefix unused variables with _ in test files
- Fix ruff E741: rename lambda l to ln in wizard files
- Fix ruff format: auto-format all Python files
- Fix eslint: remove unused import (onWillUnmount), unused param (action),
  add parseInt radix, move inline comment
- Fix prettier: reformat XML/JS files
- Fix oca-checks: add default_types.xml to manifest data
- Fix B017: use ValidationError instead of blind Exception in test
- Address Gemini review: remove downloadUrl from fileViewer.open()

Author: emjay0921

spp_change_request_v2/__manifest__.py

@@ -56,6 +56,7 @@
         # Data
         "data/dms_directories.xml",
         "data/sequences.xml",
+        "data/default_types.xml",
         "data/event_types.xml",
         "data/user_roles.xml",
     ],

spp_change_request_v2/data/default_types.xml

@@ -1,8 +1,8 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8" ?>
 <odoo>
     <!-- Parent DMS Directory for all Change Requests -->
     <record id="dms_directory_change_request_root" model="spp.dms.directory">
         <field name="name">Change Request</field>
-        <field name="is_root_directory" eval="True"/>
+        <field name="is_root_directory" eval="True" />
     </record>
 </odoo>

spp_change_request_v2/data/dms_directories.xml

@@ -6,7 +6,9 @@
         <field name="code">cr_audit</field>
         <field name="category">manual</field>
         <field name="target_type">both</field>
-        <field name="description">Audit trail events for change request state transitions</field>
+        <field
+            name="description"
+        >Audit trail events for change request state transitions</field>
     </record>
 
     <!-- Event Type for CR Conflict Detection -->
@@ -15,7 +17,8 @@
         <field name="code">cr_conflict</field>
         <field name="category">manual</field>
         <field name="target_type">both</field>
-        <field name="description">Audit trail events for conflict detection and resolution</field>
+        <field
+            name="description"
+        >Audit trail events for conflict detection and resolution</field>
     </record>
-
 </odoo>

spp_change_request_v2/data/event_types.xml

@@ -6,7 +6,6 @@
         <field name="code">spp.change.request</field>
         <field name="prefix">CR/%(year)s/</field>
         <field name="padding">5</field>
-        <field name="company_id" eval="False"/>
+        <field name="company_id" eval="False" />
     </record>
-
 </odoo>

spp_change_request_v2/data/sequences.xml

@@ -5,13 +5,14 @@ Part of OpenSPP. See LICENSE file for full copyright and licensing details.
 User roles for Change Request module.
 -->
 <odoo noupdate="1">
-
     <!-- CR Requestor Role -->
     <!-- For users who can create and submit change requests -->
     <record id="global_role_cr_requestor" model="res.users.role">
         <field name="name">CR Requestor</field>
         <field name="role_type">global</field>
-        <field name="comment">Can create and submit change requests for approval.</field>
+        <field
+            name="comment"
+        >Can create and submit change requests for approval.</field>
         <field
             name="implied_ids"
             eval="[
@@ -53,5 +54,4 @@ User roles for Change Request module.
             ]"
         />
     </record>
-
 </odoo>

spp_change_request_v2/data/user_roles.xml

@@ -29,7 +29,8 @@ class SPPCRDetailAddMember(models.Model):
     relationship_id = fields.Many2one(
         "spp.vocabulary.code",
         string="Relationship to Head",
-        domain="[('vocabulary_id.namespace_uri', '=', 'urn:openspp:vocab:group-membership-type'), ('code', '!=', 'head')]",
+        domain="[('vocabulary_id.namespace_uri', '=', 'urn:openspp:vocab:group-membership-type'),"
+        " ('code', '!=', 'head')]",
         tracking=True,
     )
     id_number = fields.Char(string="ID Number", tracking=True)

spp_change_request_v2/details/add_member.py

@@ -41,7 +41,8 @@ class SPPCRDetailChangeHOH(models.Model):
     previous_head_new_role_id = fields.Many2one(
         "spp.vocabulary.code",
         string="Previous Head's New Role",
-        domain="[('vocabulary_id.namespace_uri', '=', 'urn:openspp:vocab:group-membership-type'), ('code', '!=', 'head')]",
+        domain="[('vocabulary_id.namespace_uri', '=', 'urn:openspp:vocab:group-membership-type'),"
+        " ('code', '!=', 'head')]",
         tracking=True,
         help="The new role for the previous head (e.g., Spouse, Other Adult)",
     )

spp_change_request_v2/details/change_hoh.py

@@ -132,7 +132,7 @@ def _check_registrant_types(self):
                 for dup in rec.duplicate_registrant_ids:
                     if dup.is_group != primary_is_group:
                         raise ValidationError(
-                            "Cannot merge individuals with groups. " "All registrants must be of the same type."
+                            "Cannot merge individuals with groups. All registrants must be of the same type."
                         )
                     if dup.id == rec.primary_registrant_id.id:
                         raise ValidationError("Primary registrant cannot be in the duplicates list.")

spp_change_request_v2/details/merge_registrants.py

@@ -243,7 +243,7 @@ def _check_minimum_remaining(self):
                 )
                 if len(rec.members_to_split_ids) >= total:
                     raise ValidationError(
-                        "Cannot move all members. At least one member must remain " "in the source household."
+                        "Cannot move all members. At least one member must remain in the source household."
                     )
 
     @api.onchange("copy_address")