refactor(spp_audit): use isinstance for Markup checks, simplify loops

Replace fragile str(type(...)) comparisons with isinstance(value, Markup)
and restructure sanitization loops to iterate each record's items directly
instead of extracting keys from the first record.

Addresses gemini-code-assist review feedback on PR #138.

Author: gonzalesedwin1123

spp_audit/README.rst

@@ -152,6 +152,8 @@ Changelog
   create overrides (#138)
 - fix: Markup sanitization in audit_write and audit_unlink now handles
   all records, not just the first
+- refactor: use ``isinstance(value, Markup)`` instead of fragile
+  ``str(type(...))`` comparison in all audit decorator methods
 
 19.0.2.0.0
 ~~~~~~~~~~

spp_audit/readme/HISTORY.md

@@ -2,6 +2,7 @@
 
 - fix: use @api.model_create_multi for audit_create to support Odoo 19 create overrides (#138)
 - fix: Markup sanitization in audit_write and audit_unlink now handles all records, not just the first
+- refactor: use `isinstance(value, Markup)` instead of fragile `str(type(...))` comparison in all audit decorator methods
 
 ### 19.0.2.0.0
 

spp_audit/static/description/index.html

@@ -522,6 +522,8 @@ <h1>19.0.2.0.1</h1>
 create overrides (#138)</li>
 <li>fix: Markup sanitization in audit_write and audit_unlink now handles
 all records, not just the first</li>
+<li>refactor: use <tt class="docutils literal">isinstance(value, Markup)</tt> instead of fragile
+<tt class="docutils literal"><span class="pre">str(type(...))</span></tt> comparison in all audit decorator methods</li>
 </ul>
 </div>
 <div class="section" id="section-2">

spp_audit/tools/decorator.py

@@ -4,6 +4,8 @@
 import copy
 import logging
 
+from markupsafe import Markup
+
 from odoo import api
 
 _logger = logging.getLogger(__name__)
@@ -35,11 +37,10 @@ def audit_create(self, vals_list):
             )
         )
         if new_values:
-            keys = new_values[0].keys()
-            for key in keys:
-                for nv in new_values:
-                    if str(type(nv[key])) == "<class 'markupsafe.Markup'>":
-                        nv[key] = str(nv[key])
+            for nv in new_values:
+                for key, value in nv.items():
+                    if isinstance(value, Markup):
+                        nv[key] = str(value)
 
             rules.log("create", new_values=new_values)
         return result
@@ -71,13 +72,14 @@ def audit_write(self, vals):
         )
 
         if new_values and old_values_copy:
-            keys = new_values[0].keys()
-            for key in keys:
-                for nv, ov in zip(new_values, old_values_copy, strict=False):
-                    if str(type(nv[key])) == "<class 'markupsafe.Markup'>":
-                        nv[key] = str(nv[key])
-                    if str(type(ov[key])) == "<class 'markupsafe.Markup'>":
-                        ov[key] = str(ov[key])
+            for nv in new_values:
+                for key, value in nv.items():
+                    if isinstance(value, Markup):
+                        nv[key] = str(value)
+            for ov in old_values_copy:
+                for key, value in ov.items():
+                    if isinstance(value, Markup):
+                        ov[key] = str(value)
 
             rules.log("write", old_values_copy, new_values)
         return result
@@ -92,11 +94,10 @@ def audit_unlink(self):
         )
 
         if old_values:
-            keys = old_values[0].keys()
-            for key in keys:
-                for ov in old_values:
-                    if str(type(ov[key])) == "<class 'markupsafe.Markup'>":
-                        ov[key] = str(ov[key])
+            for ov in old_values:
+                for key, value in ov.items():
+                    if isinstance(value, Markup):
+                        ov[key] = str(value)
 
             rules.log("unlink", old_values)
         return audit_unlink.origin(self)