fix(spp_programs): use format_amount for thousands separator on entitlement summary (#941 r3)

QA round-3 follow-up: amounts on the 'What Do They Receive?' overview
were rendered with currency symbol + 2-decimal precision but without
thousands grouping (e.g. "$ 1000000.00" instead of "$ 1,000,000.00").

Switch both render paths in program_manager_ui.py to odoo.tools.misc.
format_amount, which gives locale-aware grouping plus correct currency
symbol position out of the box:

- _manager_detail_entitlement_items
- _manager_detail_basic_cash

Adds test_items_summary_includes_thousands_separator covering the
1,000,000 case. Local run: 0 failed of 3 tests.

Author: emjay0921

spp_programs/models/program_manager_ui.py

@@ -7,6 +7,7 @@
 """
 
 from odoo import _, api, fields, models
+from odoo.tools.misc import format_amount
 
 
 def _format_recurrence(duration, rrule_type):
@@ -487,11 +488,7 @@ def _manager_detail_entitlement_items(self, concrete):
             multiplier_field = getattr(item, "multiplier_field", False)
             condition = getattr(item, "condition", "") or ""
             currency = getattr(item, "currency_id", False)
-            currency_sym = (currency.symbol or currency.name) if currency else ""
-            precision = currency.decimal_places if currency else 2
-            amount_with_sym = (
-                f"{currency_sym} {amount:.{precision}f}".strip() if currency_sym else f"{amount:.{precision}f}"
-            )
+            amount_with_sym = format_amount(self.env, amount, currency) if currency else f"{amount:,.2f}"
             if amount_expr:
                 line = _("Amount per beneficiary: %s") % amount_expr
             elif multiplier_field:
@@ -517,27 +514,22 @@ def _manager_detail_basic_cash(self, concrete):
         fee_pct = getattr(concrete, "transfer_fee_pct", 0) or 0
         fee_amount = getattr(concrete, "transfer_fee_amount", 0) or 0
         currency = getattr(concrete, "currency_id", False)
-        currency_sym = (currency.symbol or currency.name) if currency else ""
-        precision = currency.decimal_places if currency else 2
 
         def _fmt(amt):
-            return f"{amt:.{precision}f}"
+            return format_amount(self.env, amt, currency) if currency else f"{amt:,.2f}"
 
         lines = []
         if per_cycle:
-            lines.append(_("Amount per cycle: %(sym)s %(amt)s") % {"sym": currency_sym, "amt": _fmt(per_cycle)})
+            lines.append(_("Amount per cycle: %s") % _fmt(per_cycle))
         if per_person:
-            line = _("Amount per person in group: %(sym)s %(amt)s") % {
-                "sym": currency_sym,
-                "amt": _fmt(per_person),
-            }
+            line = _("Amount per person in group: %s") % _fmt(per_person)
             if max_people:
                 line += _(" (up to %s people)") % max_people
             lines.append(line)
         if fee_pct:
             lines.append(_("Transfer fee: %s%% of amount") % fee_pct)
         elif fee_amount:
-            lines.append(_("Transfer fee: %(sym)s %(amt)s flat") % {"sym": currency_sym, "amt": _fmt(fee_amount)})
+            lines.append(_("Transfer fee: %s flat") % _fmt(fee_amount))
         if not lines:
             return _("No amount configured yet — click Edit above to set how much each beneficiary receives per cycle.")
         return "\n".join(lines)

spp_programs/tests/test_manager_summary_formatting.py

@@ -88,3 +88,26 @@ def test_basic_cash_summary_two_decimals(self):
         currency = self.program.journal_id.currency_id
         sym = currency.symbol or currency.name
         self.assertIn(sym, summary)
+
+    def test_items_summary_includes_thousands_separator(self):
+        """Round-3 QA: large amounts must group thousands (1,000,000.00 not 1000000.00)."""
+        cash = self.env["spp.program.entitlement.manager.cash"].create(
+            {
+                "name": "Cash Large Amount [TEST]",
+                "program_id": self.program.id,
+                "approval_definition_id": self.approval_def.id,
+            }
+        )
+        self.env["spp.program.entitlement.manager.cash.item"].create(
+            {
+                "entitlement_id": cash.id,
+                "amount": 1_000_000.0,
+            }
+        )
+        self._wrap_manager(cash)
+
+        summary = self.program.entitlement_manager_detail or ""
+        # Should include a comma in the grouped amount for en_US locale.
+        self.assertIn("1,000,000", summary, f"summary missing thousands separator: {summary!r}")
+        # And of course still no bare "1000000" without a separator.
+        self.assertNotRegex(summary, r"\b1000000\b")