fix: address remaining gemini-code-assist findings

- eligibility_manager: guard the queued import against archived/deleted
  programs (with regression test); drop the NOT-IN anti-pattern from the
  tier-2 domain (tier1 | tier2 already dedups); recordset subtraction for
  already-enrolled exclusion; iterate ids when building membership values.
- gis_edit_map widget: only re-create the MapLibre map when the geometry
  value actually changed (prevents zoom/pan loss and WebGL context churn on
  unrelated OWL patches).

Author: gonzalesedwin1123

spp_gis/static/src/js/widgets/gis_edit_map/field_gis_edit_map.esm.js

@@ -51,11 +51,20 @@ export class FieldGisEditMap extends Component {
                 defaultCenter: default_center,
             });
 
+            this._lastValue = this.props.record.data[this.props.name] || false;
             this.renderMap();
             this.addDrawInteraction();
         });
 
         onPatched(() => {
+            // Re-creating the MapLibre map on every OWL patch loses zoom/pan
+            // state and can exhaust WebGL contexts; only re-render when the
+            // geometry value actually changed.
+            const value = this.props.record.data[this.props.name] || false;
+            if (value === this._lastValue) {
+                return;
+            }
+            this._lastValue = value;
             this.defaultZoom = this.map.getZoom();
             this.renderMap();
             this.addDrawInteraction();

spp_program_geofence/models/eligibility_manager.py

@@ -151,9 +151,11 @@ def _find_eligible_registrants(self, membership=None):
                 area_domain += [("area_type_id", "=", self.fallback_area_type_id.id)]
             matching_areas = self.env["spp.area"].search(area_domain)
             if matching_areas:
+                # No "id not in tier1.ids" filter: with many tier-1 matches it
+                # generates a heavy NOT IN clause, and the tier1 | tier2 union
+                # below already deduplicates.
                 tier2_domain = base_domain + [
                     ("area_id", "in", matching_areas.ids),
-                    ("id", "not in", tier1.ids),
                 ]
                 tier2 = self.env["res.partner"].search(tier2_domain)
                 return tier1 | tier2
@@ -185,8 +187,7 @@ def import_eligible_registrants(self, state="draft"):
         new_beneficiaries = self._find_eligible_registrants()
 
         # Exclude already-enrolled beneficiaries (match base manager's exclusion source)
-        existing_partner_ids = set(self.program_id.get_beneficiaries().mapped("partner_id").ids)
-        new_beneficiaries = new_beneficiaries.filtered(lambda r: r.id not in existing_partner_ids)
+        new_beneficiaries -= self.program_id.get_beneficiaries().mapped("partner_id")
 
         ben_count = len(new_beneficiaries)
         if ben_count < self.ASYNC_IMPORT_THRESHOLD:
@@ -222,9 +223,19 @@ def mark_import_as_done(self):
         self.program_id.message_post(body=_("Import finished."))
 
     def _import_registrants(self, new_beneficiaries, state="draft", do_count=False):
+        program = self.program_id
+        # This runs from the job queue: the program may have been archived or
+        # deleted between enqueue and execution (a Many2one still dereferences
+        # an archived record as truthy).
+        if not program.exists() or not program.active:
+            _logger.warning(
+                "spp_program_geofence: program for manager %s is missing or archived; skipping import",
+                self.id,
+            )
+            return
         _logger.info("spp_program_geofence: Importing %s beneficiaries", len(new_beneficiaries))
         self.env["spp.program.membership"].create(
-            [{"program_id": self.program_id.id, "partner_id": b.id, "state": state} for b in new_beneficiaries]
+            [{"program_id": program.id, "partner_id": pid, "state": state} for pid in new_beneficiaries.ids]
         )
 
         if do_count:

spp_program_geofence/tests/test_geofence_eligibility.py

@@ -786,3 +786,15 @@ def mock_delayable(self_inner, **kwargs):
             channels,
             f"Expected 'statistics_refresh' channel for on_done job, got: {channels}",
         )
+
+    def test_import_skips_archived_program(self):
+        """The queued import must not create memberships for an archived program."""
+        registrant = self.env["res.partner"].create({"name": "Archived Prog Registrant", "is_registrant": True})
+        Membership = self.env["spp.program.membership"]
+        before = Membership.with_context(active_test=False).search_count([("program_id", "=", self.program.id)])
+        self.program.active = False
+        with self.assertLogs("odoo.addons.spp_program_geofence.models.eligibility_manager", level="WARNING"):
+            self.manager._import_registrants(registrant)
+        self.program.active = True
+        after = Membership.with_context(active_test=False).search_count([("program_id", "=", self.program.id)])
+        self.assertEqual(before, after, "no memberships may be created for an archived program")