Merge pull request #26 from OpenSPP/feat/drims-beta

feat(spp_drims): promote to Beta with view improvements

Author: gonzalesedwin1123

spp_drims/__manifest__.py

@@ -10,7 +10,7 @@
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/OpenSPP2",
     "license": "LGPL-3",
-    "development_status": "Alpha",
+    "development_status": "Beta",
     "maintainers": ["jeremi", "gonzalesedwin1123"],
     "depends": [
         "base",
@@ -43,6 +43,7 @@
         "data/audit_rules.xml",
         "data/config_defaults.xml",
         "data/gis_report_templates.xml",
+        "data/approval_definitions.xml",
         # Reports (before views, as views may reference report actions)
         "report/waybill_template.xml",
         "views/dashboard_views.xml",

spp_drims/data/approval_definitions.xml

@@ -14,6 +14,10 @@
         <field name="active">True</field>
         <field name="sla_days">0</field>
         <field name="sequence">1</field>
+        <field name="approval_type">group</field>
+        <field name="approval_group_id" ref="group_drims_manager"/>
+        <field name="is_emergency_bypass_allowed">True</field>
+        <field name="notify_on_submit">True</field>
     </record>
 
     <!-- Standard Approval (Small Value) -->
@@ -23,6 +27,9 @@
         <field name="active">True</field>
         <field name="sla_days">1</field>
         <field name="sequence">10</field>
+        <field name="approval_type">group</field>
+        <field name="approval_group_id" ref="group_drims_approver"/>
+        <field name="notify_on_submit">True</field>
     </record>
 
     <!-- Medium Value Approval -->
@@ -32,6 +39,10 @@
         <field name="active">True</field>
         <field name="sla_days">2</field>
         <field name="sequence">20</field>
+        <field name="approval_type">group</field>
+        <field name="approval_group_id" ref="group_drims_approver"/>
+        <field name="is_require_comment">True</field>
+        <field name="notify_on_submit">True</field>
     </record>
 
     <!-- Large Value Approval -->
@@ -41,5 +52,9 @@
         <field name="active">True</field>
         <field name="sla_days">3</field>
         <field name="sequence">30</field>
+        <field name="approval_type">group</field>
+        <field name="approval_group_id" ref="group_drims_manager"/>
+        <field name="is_require_comment">True</field>
+        <field name="notify_on_submit">True</field>
     </record>
 </odoo>

spp_drims/models/request.py

@@ -348,6 +348,7 @@ def _compute_sla_status(self):
                 rec.sla_due_datetime = False
                 rec.sla_status = False
 
+    @api.depends("sla_due_datetime")
     def _compute_sla_hours_remaining(self):
         """Compute hours remaining until SLA breach."""
         now = fields.Datetime.now()