fix(spp_gis): use dedicated geofence tag model instead of spp.vocabulary

The tag_ids field on spp.gis.geofence was pointing to spp.vocabulary,
which is a generic vocabulary model containing all tag categories
(Country, Currency, etc.). Replace with a dedicated spp.gis.geofence.tag
model so the tags dropdown only shows geofence-specific tags.

Author: jeremi

spp_gis/__manifest__.py

@@ -11,7 +11,7 @@
     "license": "LGPL-3",
     "development_status": "Production/Stable",
     "maintainers": ["jeremi", "gonzalesedwin1123", "reichie020212"],
-    "depends": ["base", "web", "contacts", "spp_security", "spp_area", "spp_vocabulary", "spp_registry"],
+    "depends": ["base", "web", "contacts", "spp_security", "spp_area", "spp_registry"],
     "external_dependencies": {"python": ["shapely", "pyproj", "geojson"]},
     "data": [
         "data/res_config_data.xml",

spp_gis/models/geofence.py

@@ -15,6 +15,18 @@
 _logger = logging.getLogger(__name__)
 
 
+class GisGeofenceTag(models.Model):
+    """Tags for classifying geofences."""
+
+    _name = "spp.gis.geofence.tag"
+    _description = "Geofence Tag"
+    _order = "name"
+
+    name = fields.Char(required=True, translate=True)
+    color = fields.Integer(string="Color Index")
+    active = fields.Boolean(default=True)
+
+
 class GisGeofence(models.Model):
     """Saved Geographic Areas of Interest.
 
@@ -63,7 +75,7 @@ class GisGeofence(models.Model):
 
     # Tags for flexible classification
     tag_ids = fields.Many2many(
-        "spp.vocabulary",
+        "spp.gis.geofence.tag",
         "spp_gis_geofence_tag_rel",
         "geofence_id",
         "tag_id",

spp_gis/security/ir.model.access.csv

@@ -6,6 +6,9 @@ access_spp_raster_layer_admin,Raster Layer Admin,spp_gis.model_spp_gis_raster_la
 access_spp_raster_layer_type_admin,Raster Layer Type Admin,spp_gis.model_spp_gis_raster_layer_type,spp_security.group_spp_admin,1,1,1,1
 access_spp_data_layer_read,Data Layer Read,spp_gis.model_spp_gis_data_layer,spp_registry.group_registry_read,1,0,0,0
 access_spp_raster_layer_read,Raster Layer Read,spp_gis.model_spp_gis_raster_layer,spp_registry.group_registry_read,1,0,0,0
+access_spp_gis_geofence_tag_admin,Geofence Tag Admin,spp_gis.model_spp_gis_geofence_tag,spp_security.group_spp_admin,1,1,1,1
+access_spp_gis_geofence_tag_manager,Geofence Tag Manager,spp_gis.model_spp_gis_geofence_tag,spp_registry.group_registry_manager,1,1,1,0
+access_spp_gis_geofence_tag_read,Geofence Tag Read,spp_gis.model_spp_gis_geofence_tag,spp_registry.group_registry_read,1,0,0,0
 access_spp_gis_geofence_admin,Geofence Admin,spp_gis.model_spp_gis_geofence,spp_security.group_spp_admin,1,1,1,1
 access_spp_gis_geofence_manager,Geofence Manager,spp_gis.model_spp_gis_geofence,spp_registry.group_registry_manager,1,1,1,1
 access_spp_gis_geofence_officer,Geofence Officer,spp_gis.model_spp_gis_geofence,spp_registry.group_registry_officer,1,1,1,0

spp_gis/tests/test_geofence.py

@@ -61,18 +61,12 @@ def setUpClass(cls):
             ],
         }
 
-        # Create test vocabulary for tags
-        cls.tag1 = cls.env["spp.vocabulary"].search(
-            [("namespace_uri", "=", "urn:openspp:concept:geofence_tag_1")],
-            limit=1,
+        # Create test tag for geofences
+        cls.tag1 = cls.env["spp.gis.geofence.tag"].create(
+            {
+                "name": "Test Tag 1",
+            }
         )
-        if not cls.tag1:
-            cls.tag1 = cls.env["spp.vocabulary"].create(
-                {
-                    "name": "Test Tag 1",
-                    "namespace_uri": "urn:openspp:concept:geofence_tag_1",
-                }
-            )
 
     def test_create_geofence_basic(self):
         """Test creating a basic geofence."""