fix(cr): remove duplicate role attributes and fix manifest data loading

emjay0921 · emjay0921 · commit 721b5b39c85e · 2026-03-09T11:57:20.000+08:00
diff --git a/spp_change_request_v2/__manifest__.py b/spp_change_request_v2/__manifest__.py
@@ -56,10 +56,12 @@
         # Data
         "data/dms_directories.xml",
         "data/sequences.xml",
-        "data/default_types.xml",
         "data/event_types.xml",
         "data/user_roles.xml",
     ],
+    "oca_data_manual": [
+        "data/default_types.xml",
+    ],
     "assets": {
         "web.assets_backend": [
             "spp_change_request_v2/static/src/components/**/*",
diff --git a/spp_change_request_v2/views/change_request_views.xml b/spp_change_request_v2/views/change_request_views.xml
@@ -281,7 +281,7 @@
                     <!-- Target Type Information Banner -->
                     <div
                         class="alert alert-secondary py-2"
-                        role="status"
+                        role="alert"
                         invisible="not target_type_message"
                     >
                         <div class="d-flex align-items-center">
@@ -336,7 +336,7 @@
                     <!-- Revision Needed Banner -->
                     <div
                         class="alert alert-warning"
-                        role="status"
+                        role="alert"
                         invisible="approval_state != 'revision'"
                     >
                         <div class="d-flex align-items-center">
@@ -354,7 +354,7 @@
                     <!-- Ready to Finalize Banner -->
                     <div
                         class="alert alert-success"
-                        role="status"
+                        role="alert"
                         invisible="approval_state != 'approved' or is_applied"
                     >
                         <div class="d-flex align-items-center">
@@ -374,7 +374,7 @@
                     <!-- Multi-tier Approval Progress Banner -->
                     <div
                         class="alert alert-info"
-                        role="status"
+                        role="alert"
                         invisible="not multitier_approval_message"
                     >
                         <div class="d-flex align-items-center">
diff --git a/spp_change_request_v2/views/conflict_extensions.xml b/spp_change_request_v2/views/conflict_extensions.xml
@@ -232,7 +232,7 @@
                     <!-- WARNING: Less alarming banner -->
                     <div
                         class="alert alert-warning"
-                        role="status"
+                        role="alert"
                         invisible="conflict_status != 'warning'"
                     >
                         <div class="d-flex align-items-center">
@@ -255,7 +255,7 @@
                     <!-- OVERRIDDEN: Success banner with collapsible details -->
                     <div
                         class="alert alert-success"
-                        role="status"
+                        role="alert"
                         invisible="conflict_status != 'overridden'"
                     >
                         <div class="d-flex align-items-center">
diff --git a/spp_change_request_v2/views/create_wizard_views.xml b/spp_change_request_v2/views/create_wizard_views.xml
@@ -35,7 +35,7 @@
                     <!-- Target type info -->
                     <div
                         class="alert alert-secondary py-2"
-                        role="status"
+                        role="alert"
                         invisible="not target_type_message"
                     >
                         <div class="d-flex align-items-center">
@@ -78,7 +78,7 @@
                     <!-- Selected registrant info -->
                     <div
                         class="alert alert-success py-2 mb-3"
-                        role="status"
+                        role="alert"
                         invisible="not registrant_id"
                     >
                         <field name="registrant_info_html" nolabel="1" readonly="1" />
diff --git a/spp_change_request_v2/views/stage_documents_form.xml b/spp_change_request_v2/views/stage_documents_form.xml
@@ -47,6 +47,7 @@
                     <!-- Context banner -->
                     <div
                         class="alert alert-light border d-flex align-items-center mb-4 py-2"
+                        role="alert"
                     >
                         <i class="fa fa-file-text fa-lg text-primary me-3" />
                         <field name="stage_banner_html" nolabel="1" readonly="1" />
diff --git a/spp_change_request_v2/views/stage_review_form.xml b/spp_change_request_v2/views/stage_review_form.xml
@@ -147,6 +147,7 @@
                     <!-- Context banner -->
                     <div
                         class="alert alert-light border d-flex align-items-center mb-4 py-2"
+                        role="alert"
                     >
                         <i class="fa fa-search fa-lg text-primary me-3" />
                         <field name="stage_banner_html" nolabel="1" readonly="1" />
@@ -155,7 +156,7 @@
                     <!-- Revision feedback banner (for creator in revision state) -->
                     <div
                         class="alert alert-warning"
-                        role="status"
+                        role="alert"
                         invisible="approval_state != 'revision' or not revision_notes"
                     >
                         <div class="d-flex align-items-center">
@@ -174,7 +175,7 @@
                     <!-- Rejection reason banner -->
                     <div
                         class="alert alert-danger"
-                        role="status"
+                        role="alert"
                         invisible="approval_state != 'rejected' or not rejection_reason"
                     >
                         <div class="d-flex align-items-center">
@@ -193,7 +194,7 @@
                     <!-- Approval status banner -->
                     <div
                         class="alert alert-info"
-                        role="status"
+                        role="alert"
                         invisible="not multitier_approval_message"
                     >
                         <div class="d-flex align-items-center">
@@ -205,7 +206,11 @@
                     </div>
 
                     <!-- Review instruction -->
-                    <div class="alert alert-warning mb-3 py-2" invisible="is_applied">
+                    <div
+                        class="alert alert-warning mb-3 py-2"
+                        role="alert"
+                        invisible="is_applied"
+                    >
                         <i class="fa fa-exclamation-triangle me-2" />
                         Review the changes below.
                     </div>
@@ -223,7 +228,7 @@
                             </div>
                         </page>
                         <page string="Attached Documents" name="attached_documents">
-                            <div class="alert alert-warning mb-3 py-2">
+                            <div class="alert alert-warning mb-3 py-2" role="alert">
                                 <i class="fa fa-exclamation-triangle me-2" />
                                 Only images and PDF files can be previewed. Other file types must be downloaded to view.
                             </div>

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@`
`47`	`47`	`<!-- Context banner -->`
`48`	`48`	`<div`
`49`	`49`	`class="alert alert-light border d-flex align-items-center mb-4 py-2"`
	`50`	`+ role="alert"`
`50`	`51`	`>`
`51`	`52`	`<i class="fa fa-file-text fa-lg text-primary me-3" />`
`52`	`53`	`<field name="stage_banner_html" nolabel="1" readonly="1" />`