fix: CodeEditor mode crash and hidden menu reset on upgrade

1. spp_approval: change ace widget mode from 'text' to 'python' in
   CEL expression fields. Odoo 19 CodeEditor only accepts
   javascript/xml/qweb/scss/python — 'text' crashes with
   "Invalid props for component 'CodeEditor': 'mode' is not valid".

2. spp_hide_menus_base: re-apply hiding when module upgrade resets
   menu group_ids via XML (noupdate="0"). Previously, menus with
   state="hide" were skipped in hide_menus(), so an upgrade that
   re-applied the original group_ids left them visible.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: haklyray

spp_approval/views/approval_definition_views_cel.xml

@@ -15,7 +15,7 @@
                             <field
                                 name="cel_condition"
                                 widget="ace"
-                                options="{'mode': 'text'}"
+                                options="{'mode': 'python'}"
                                 invisible="not use_cel_condition"
                                 placeholder="record.amount > 10000"
                             />
@@ -42,7 +42,7 @@
                             <field
                                 name="cel_reviewer_expression"
                                 widget="ace"
-                                options="{'mode': 'text'}"
+                                options="{'mode': 'python'}"
                                 invisible="not use_cel_reviewer"
                                 placeholder="record.manager_id.user_id.id"
                             />

spp_hide_menus_base/models/hide_menu.py

@@ -40,6 +40,17 @@ def hide_menu(self, menu_id=None):
                 )
                 rec.state = "hide"
 
+    def _reapply_hide(self):
+        """Re-apply hiding when module upgrade reset group_ids via XML."""
+        try:
+            hide_group = self.env.ref("spp_hide_menus_base.group_hide_menus_user")
+        except ValueError:
+            hide_group = self.env.ref("spp_hide_menus_base.group_menu_visibility")
+        for rec in self:
+            if rec.menu_id and hide_group not in rec.menu_id.group_ids:
+                rec.default_group_ids = rec.menu_id.group_ids
+                rec.menu_id.write({"group_ids": [Command.set([hide_group.id])]})
+
     def show_menu(self):
         for rec in self:
             if rec.state == "hide" and rec.menu_id:

spp_hide_menus_base/models/ir_module_module.py

@@ -79,6 +79,10 @@ def hide_menus(self):
                         hidden_menu.hide_menu()
                     elif hidden_menus.state == "show":
                         hidden_menus.hide_menu()
+                    elif hidden_menus.state == "hide":
+                        # Module upgrade may have reset group_ids via XML
+                        # (noupdate="0"). Re-apply hiding if stale.
+                        hidden_menus._reapply_hide()
 
     def next(self):
         # Call your menu hiding logic first