Skip to content

Commit 779171e

Browse files
committed
chore: regenerate spp_base_common + spp_security READMEs (OP#951)
1 parent c9bb0f0 commit 779171e

4 files changed

Lines changed: 31 additions & 23 deletions

File tree

spp_base_common/README.rst

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,21 @@ Dependencies
120120
Changelog
121121
=========
122122

123+
19.0.2.0.1
124+
~~~~~~~~~~
125+
126+
- fix(security): add ``groups="base.group_system"`` to the existing
127+
``<menuitem id="base.menu_management" />`` override in
128+
``views/main_view.xml``. Out of the box the Apps top-level menu has no
129+
group restriction and is visible to every logged-in user, violating
130+
the OP#951 audit's ``Apps: no`` rows. The override here is the single
131+
authoritative declaration for this menu's attributes in the OpenSPP
132+
install (sequence, custom OpenSPP icon, and now group_ids); doing the
133+
gating anywhere upstream (e.g. a ``post_init_hook`` in
134+
``spp_security``) is unreliable because this ``<menuitem>`` reload
135+
re-writes the record without a ``groups`` attribute and resets
136+
``group_ids`` to empty.
137+
123138
19.0.2.0.0
124139
~~~~~~~~~~
125140

spp_base_common/static/description/index.html

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -495,6 +495,22 @@ <h2><a class="toc-backref" href="#toc-entry-1">Changelog</a></h2>
495495
</div>
496496
</div>
497497
<div class="section" id="section-1">
498+
<h1>19.0.2.0.1</h1>
499+
<ul class="simple">
500+
<li>fix(security): add <tt class="docutils literal"><span class="pre">groups=&quot;base.group_system&quot;</span></tt> to the existing
501+
<tt class="docutils literal">&lt;menuitem <span class="pre">id=&quot;base.menu_management&quot;</span> /&gt;</tt> override in
502+
<tt class="docutils literal">views/main_view.xml</tt>. Out of the box the Apps top-level menu has no
503+
group restriction and is visible to every logged-in user, violating
504+
the OP#951 audit’s <tt class="docutils literal">Apps: no</tt> rows. The override here is the single
505+
authoritative declaration for this menu’s attributes in the OpenSPP
506+
install (sequence, custom OpenSPP icon, and now group_ids); doing the
507+
gating anywhere upstream (e.g. a <tt class="docutils literal">post_init_hook</tt> in
508+
<tt class="docutils literal">spp_security</tt>) is unreliable because this <tt class="docutils literal">&lt;menuitem&gt;</tt> reload
509+
re-writes the record without a <tt class="docutils literal">groups</tt> attribute and resets
510+
<tt class="docutils literal">group_ids</tt> to empty.</li>
511+
</ul>
512+
</div>
513+
<div class="section" id="section-2">
498514
<h1>19.0.2.0.0</h1>
499515
<ul class="simple">
500516
<li>Initial migration to OpenSPP2</li>

spp_security/README.rst

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -140,17 +140,6 @@ Dependencies
140140
Changelog
141141
=========
142142

143-
19.0.2.0.1
144-
~~~~~~~~~~
145-
146-
- fix(security): gate the Odoo-stock **Apps** top-level menu
147-
(``base.menu_management``) on ``base.group_system``. Out of the box
148-
the menu had no ``groups`` restriction and was visible to every
149-
logged-in user, so the OP#951 audit's ``Apps: no`` rows were silently
150-
violated. System Admin is the only OpenSPP role that pulls in
151-
``base.group_system``, so this single override hides Apps from every
152-
other role without touching any individual role definition.
153-
154143
19.0.2.0.0
155144
~~~~~~~~~~
156145

spp_security/static/description/index.html

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -496,18 +496,6 @@ <h2><a class="toc-backref" href="#toc-entry-1">Changelog</a></h2>
496496
</div>
497497
</div>
498498
<div class="section" id="section-1">
499-
<h1>19.0.2.0.1</h1>
500-
<ul class="simple">
501-
<li>fix(security): gate the Odoo-stock <strong>Apps</strong> top-level menu
502-
(<tt class="docutils literal">base.menu_management</tt>) on <tt class="docutils literal">base.group_system</tt>. Out of the box
503-
the menu had no <tt class="docutils literal">groups</tt> restriction and was visible to every
504-
logged-in user, so the OP#951 audit’s <tt class="docutils literal">Apps: no</tt> rows were silently
505-
violated. System Admin is the only OpenSPP role that pulls in
506-
<tt class="docutils literal">base.group_system</tt>, so this single override hides Apps from every
507-
other role without touching any individual role definition.</li>
508-
</ul>
509-
</div>
510-
<div class="section" id="section-2">
511499
<h1>19.0.2.0.0</h1>
512500
<ul class="simple">
513501
<li>Initial migration to OpenSPP2</li>

0 commit comments

Comments
 (0)