fix(spp_studio_events): self-explanatory step 1 for Studio-backed event types (OP#992)

Author: emjay0921

spp_studio_events/README.rst

@@ -50,30 +50,30 @@ Key Capabilities
 Key Models
 ~~~~~~~~~~
 
-+------------------------------------------+----------------------------------+
-| Model                                    | Description                      |
-+==========================================+==================================+
-| ``spp.studio.event.type``                | Custom event type definition     |
-|                                          | with draft/active lifecycle      |
-+------------------------------------------+----------------------------------+
-| ``spp.studio.event.field``               | Field definition with type,      |
-|                                          | validation, and visibility       |
-+------------------------------------------+----------------------------------+
-| ``spp.studio.event.field.group``         | Groups fields into tabs in the   |
-|                                          | data entry wizard                |
-+------------------------------------------+----------------------------------+
-| ``spp.studio.event.field.template``      | Reusable template containing     |
-|                                          | field definitions                |
-+------------------------------------------+----------------------------------+
-| ``spp.studio.event.field.template.line`` | Field definition within a        |
-|                                          | template                         |
-+------------------------------------------+----------------------------------+
-| ``spp.studio.event.type.wizard``         | 3-step wizard for creating event |
-|                                          | types                            |
-+------------------------------------------+----------------------------------+
-| ``spp.event.data.entry.wizard``          | Generated wizard for entering    |
-|                                          | event data                       |
-+------------------------------------------+----------------------------------+
++----------------------------------+----------------------------------+
+| Model                            | Description                      |
++==================================+==================================+
+| ``spp.studio.event.type``        | Custom event type definition     |
+|                                  | with draft/active lifecycle      |
++----------------------------------+----------------------------------+
+| ``spp.studio.event.field``       | Field definition with type,      |
+|                                  | validation, and visibility       |
++----------------------------------+----------------------------------+
+| ``spp.studio.event.field.group`` | Groups fields into tabs in the   |
+|                                  | data entry wizard                |
++----------------------------------+----------------------------------+
+| ``s                              | Reusable template containing     |
+| pp.studio.event.field.template`` | field definitions                |
++----------------------------------+----------------------------------+
+| ``spp.st                         | Field definition within a        |
+| udio.event.field.template.line`` | template                         |
++----------------------------------+----------------------------------+
+| ``spp.studio.event.type.wizard`` | 3-step wizard for creating event |
+|                                  | types                            |
++----------------------------------+----------------------------------+
+| ``spp.event.data.entry.wizard``  | Generated wizard for entering    |
+|                                  | event data                       |
++----------------------------------+----------------------------------+
 
 Configuration
 ~~~~~~~~~~~~~
@@ -99,18 +99,20 @@ UI Location
 Security
 ~~~~~~~~
 
-+--------------------------------------------+----------------------------------+
-| Group                                      | Access                           |
-+============================================+==================================+
-| ``spp_studio.group_studio_viewer``         | Read event types and templates   |
-+--------------------------------------------+----------------------------------+
-| ``spp_studio.group_studio_editor_officer`` | Read/Write/Create on event       |
-|                                            | types, fields, and templates (no |
-|                                            | delete on event                  |
-|                                            | types/fields/templates)          |
-+--------------------------------------------+----------------------------------+
-| ``spp_studio.group_studio_manager``        | Full CRUD                        |
-+--------------------------------------------+----------------------------------+
++----------------------------------+----------------------------------+
+| Group                            | Access                           |
++==================================+==================================+
+| ``                               | Read event types and templates   |
+| spp_studio.group_studio_viewer`` |                                  |
++----------------------------------+----------------------------------+
+| ``spp_stud                       | Read/Write/Create on event       |
+| io.group_studio_editor_officer`` | types, fields, and templates (no |
+|                                  | delete on event                  |
+|                                  | types/fields/templates)          |
++----------------------------------+----------------------------------+
+| ``s                              | Full CRUD                        |
+| pp_studio.group_studio_manager`` |                                  |
++----------------------------------+----------------------------------+
 
 Extension Points
 ~~~~~~~~~~~~~~~~
@@ -137,6 +139,25 @@ Dependencies
 Changelog
 =========
 
+19.0.2.0.2
+~~~~~~~~~~
+
+- fix(views): the basic Create Event wizard's step 1 is now
+  self-explanatory for Studio-backed event types. The misleading raw
+  JSON field is hidden; an info banner announces the next stage; the
+  "Create Event" button is renamed "Next" so users know there's a second
+  step where the structured fields appear. Non-Studio event types keep
+  the original step-1 UI unchanged. Backed by a new computed
+  ``is_studio_event_type`` boolean on ``spp.create.event.wizard``.
+
+19.0.2.0.1
+~~~~~~~~~~
+
+- fix(views): clicking the **Events** smart button on a Studio Event
+  Type form no longer crashes with ``View types not defined tree``.
+  ``action_view_events`` returned ``view_mode="tree,form"``, but Odoo 19
+  renamed ``tree`` to ``list``; switched to ``view_mode="list,form"``.
+
 19.0.2.0.0
 ~~~~~~~~~~
 

spp_studio_events/__manifest__.py

@@ -1,7 +1,7 @@
 # pylint: disable-next=pointless-statement
 {
     "name": "OpenSPP Studio - Events",
-    "version": "19.0.2.0.1",
+    "version": "19.0.2.0.2",
     "category": "OpenSPP/Configuration",
     "summary": "No-code event type designer for data collection",
     "author": "OpenSPP.org",
@@ -22,6 +22,7 @@
         # Wizards
         "wizard/event_type_wizard_views.xml",
         "wizard/event_data_entry_wizard_views.xml",
+        "wizard/create_event_wizard_views.xml",
         # Data
         "data/event_field_templates.xml",
     ],

spp_studio_events/readme/HISTORY.md

@@ -1,3 +1,7 @@
+### 19.0.2.0.2
+
+- fix(views): the basic Create Event wizard's step 1 is now self-explanatory for Studio-backed event types. The misleading raw JSON field is hidden; an info banner announces the next stage; the "Create Event" button is renamed "Next" so users know there's a second step where the structured fields appear. Non-Studio event types keep the original step-1 UI unchanged. Backed by a new computed `is_studio_event_type` boolean on `spp.create.event.wizard`.
+
 ### 19.0.2.0.1
 
 - fix(views): clicking the **Events** smart button on a Studio Event Type form no longer crashes with `View types not defined tree`. `action_view_events` returned `view_mode="tree,form"`, but Odoo 19 renamed `tree` to `list`; switched to `view_mode="list,form"`.

spp_studio_events/static/description/index.html

@@ -399,8 +399,8 @@ <h1>Key Capabilities</h1>
 <h1>Key Models</h1>
 <table border="1" class="docutils">
 <colgroup>
-<col width="55%" />
-<col width="45%" />
+<col width="50%" />
+<col width="50%" />
 </colgroup>
 <thead valign="bottom">
 <tr><th class="head">Model</th>
@@ -420,11 +420,13 @@ <h1>Key Models</h1>
 <td>Groups fields into tabs in the
 data entry wizard</td>
 </tr>
-<tr><td><tt class="docutils literal">spp.studio.event.field.template</tt></td>
+<tr><td><tt class="docutils literal">s
+pp.studio.event.field.template</tt></td>
 <td>Reusable template containing
 field definitions</td>
 </tr>
-<tr><td><tt class="docutils literal">spp.studio.event.field.template.line</tt></td>
+<tr><td><tt class="docutils literal">spp.st
+udio.event.field.template.line</tt></td>
 <td>Field definition within a
 template</td>
 </tr>
@@ -465,25 +467,28 @@ <h1>UI Location</h1>
 <h1>Security</h1>
 <table border="1" class="docutils">
 <colgroup>
-<col width="56%" />
-<col width="44%" />
+<col width="50%" />
+<col width="50%" />
 </colgroup>
 <thead valign="bottom">
 <tr><th class="head">Group</th>
 <th class="head">Access</th>
 </tr>
 </thead>
 <tbody valign="top">
-<tr><td><tt class="docutils literal">spp_studio.group_studio_viewer</tt></td>
+<tr><td>``
+spp_studio.group_studio_viewer``</td>
 <td>Read event types and templates</td>
 </tr>
-<tr><td><tt class="docutils literal">spp_studio.group_studio_editor_officer</tt></td>
+<tr><td><tt class="docutils literal">spp_stud
+io.group_studio_editor_officer</tt></td>
 <td>Read/Write/Create on event
 types, fields, and templates (no
 delete on event
 types/fields/templates)</td>
 </tr>
-<tr><td><tt class="docutils literal">spp_studio.group_studio_manager</tt></td>
+<tr><td><tt class="docutils literal">s
+pp_studio.group_studio_manager</tt></td>
 <td>Full CRUD</td>
 </tr>
 </tbody>
@@ -516,6 +521,27 @@ <h2><a class="toc-backref" href="#toc-entry-1">Changelog</a></h2>
 </div>
 </div>
 <div class="section" id="section-1">
+<h1>19.0.2.0.2</h1>
+<ul class="simple">
+<li>fix(views): the basic Create Event wizard’s step 1 is now
+self-explanatory for Studio-backed event types. The misleading raw
+JSON field is hidden; an info banner announces the next stage; the
+“Create Event” button is renamed “Next” so users know there’s a second
+step where the structured fields appear. Non-Studio event types keep
+the original step-1 UI unchanged. Backed by a new computed
+<tt class="docutils literal">is_studio_event_type</tt> boolean on <tt class="docutils literal">spp.create.event.wizard</tt>.</li>
+</ul>
+</div>
+<div class="section" id="section-2">
+<h1>19.0.2.0.1</h1>
+<ul class="simple">
+<li>fix(views): clicking the <strong>Events</strong> smart button on a Studio Event
+Type form no longer crashes with <tt class="docutils literal">View types not defined tree</tt>.
+<tt class="docutils literal">action_view_events</tt> returned <tt class="docutils literal"><span class="pre">view_mode=&quot;tree,form&quot;</span></tt>, but Odoo 19
+renamed <tt class="docutils literal">tree</tt> to <tt class="docutils literal">list</tt>; switched to <tt class="docutils literal"><span class="pre">view_mode=&quot;list,form&quot;</span></tt>.</li>
+</ul>
+</div>
+<div class="section" id="section-3">
 <h1>19.0.2.0.0</h1>
 <ul class="simple">
 <li>Initial migration to OpenSPP2</li>

spp_studio_events/wizard/create_event_wizard.py

@@ -2,7 +2,7 @@
 
 import logging
 
-from odoo import _, models
+from odoo import _, api, fields, models
 
 _logger = logging.getLogger(__name__)
 
@@ -12,6 +12,22 @@ class SPPCreateEventWizardStudioExtension(models.TransientModel):
 
     _inherit = "spp.create.event.wizard"
 
+    is_studio_event_type = fields.Boolean(
+        compute="_compute_is_studio_event_type",
+        help=(
+            "True when the selected event type was created via Studio and "
+            "renders structured fields in the next stage. Drives the basic "
+            "wizard's UX: hides the misleading raw JSON input, shows an "
+            "info banner, and renames the submit button to 'Next' so users "
+            "know there's a second step coming."
+        ),
+    )
+
+    @api.depends("event_type_id")
+    def _compute_is_studio_event_type(self):
+        for rec in self:
+            rec.is_studio_event_type = bool(rec.event_type_id and rec.event_type_id._get_active_studio_event_type())
+
     def create_event(self):
         """Override to redirect to Studio wizard if applicable.
 

spp_studio_events/wizard/create_event_wizard_views.xml

@@ -0,0 +1,75 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <!--
+        Inherit the basic Create Event wizard form to make step 1 of the
+        Studio flow self-explanatory:
+
+        - Hide the raw JSON `event_data` field for Studio event types
+          (it's misleading since the structured fields render in the
+          next stage, not this one).
+        - Insert an info banner that announces the next stage.
+        - Replace the "Create Event" button with a "Next" button when the
+          selected event type is Studio-backed; non-Studio types keep
+          "Create Event" because for them this *is* the only stage.
+
+        See OP#992.
+    -->
+    <record id="view_spp_create_event_wizard_form_studio" model="ir.ui.view">
+        <field name="name">spp.create.event.wizard.form.studio</field>
+        <field name="model">spp.create.event.wizard</field>
+        <field
+            name="inherit_id"
+            ref="spp_event_data.view_spp_create_event_wizard_form"
+        />
+        <field name="arch" type="xml">
+            <!-- Make the Studio flag readable from the view's evaluation
+                 context so the conditional attributes below work. -->
+            <xpath expr="//field[@name='partner_id']" position="before">
+                <field name="is_studio_event_type" invisible="1" />
+            </xpath>
+
+            <!-- Info banner at the top of the sheet — full-width, only
+                 visible for Studio-backed event types. Placed before the
+                 first group so it renders as a banner above the form
+                 fields rather than as a column-neighbor of the (now
+                 hidden) JSON group. -->
+            <xpath expr="//sheet/group[1]" position="before">
+                <div
+                    class="alert alert-info"
+                    role="alert"
+                    invisible="not is_studio_event_type"
+                >
+                    This event type uses <strong>structured fields</strong>.
+                    Click <strong>Next</strong> to enter them — you'll be
+                    moved to the second stage where each defined field
+                    appears as its own input.
+                </div>
+            </xpath>
+
+            <!-- Hide the raw JSON group when the event type is Studio-backed. -->
+            <xpath expr="//field[@name='event_data']/.." position="attributes">
+                <attribute
+                    name="invisible"
+                >not event_type_id or is_studio_event_type</attribute>
+            </xpath>
+
+            <!-- Hide the original "Create Event" button when Studio. -->
+            <xpath expr="//footer/button[@name='create_event']" position="attributes">
+                <attribute
+                    name="invisible"
+                >not event_type_id or is_studio_event_type</attribute>
+            </xpath>
+
+            <!-- Add a "Next" button (same backing method) for Studio types. -->
+            <xpath expr="//footer/button[@name='create_event']" position="after">
+                <button
+                    name="create_event"
+                    string="Next"
+                    type="object"
+                    class="oe_highlight"
+                    invisible="not is_studio_event_type"
+                />
+            </xpath>
+        </field>
+    </record>
+</odoo>