feat(spp_dci_client): drop unsupported Basic Authentication option

Basic auth was a non-functional stub: the auth_type selection offered it,
but get_headers() raised 'not yet implemented' and no username/password
fields existed, so picking it was a dead end. Remove the 'basic' selection
option and the dead handler branch. Tests covering the stub are removed; the
sender-id constraint test now exercises bearer auth instead.

Author: gonzalesedwin1123

spp_dci_client/__manifest__.py

@@ -2,7 +2,7 @@
 {
     "name": "OpenSPP DCI Client",
     "summary": "Base DCI client infrastructure with OAuth2 and data source management",
-    "version": "19.0.2.0.0",
+    "version": "19.0.2.0.1",
     "category": "OpenSPP/Integration",
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/OpenSPP2",

spp_dci_client/models/data_source.py

@@ -48,7 +48,6 @@ class DCIDataSource(models.Model):
         [
             ("none", "None"),
             ("bearer", "Bearer Token"),
-            ("basic", "Basic Authentication"),
             ("oauth2", "OAuth2"),
         ],
         default="oauth2",
@@ -486,9 +485,6 @@ def get_headers(self, force_refresh_token=False):
             if not self.bearer_token:
                 raise UserError(_("Bearer token is not configured for this data source."))
             headers["Authorization"] = f"Bearer {self.bearer_token}"
-        elif self.auth_type == "basic":
-            # Basic auth would require username/password fields (not in current spec)
-            raise UserError(_("Basic authentication is not yet implemented."))
 
         return headers
 

spp_dci_client/tests/test_data_source.py

@@ -238,14 +238,15 @@ def test_oauth2_secret_set_via_display_field_on_write(self):
 
     def test_sender_id_required_for_auth(self):
         """Test sender ID is required when auth_type is not 'none'"""
-        # Should fail for basic auth without sender_id
+        # Should fail for bearer auth without sender_id
         with self.assertRaises(ValidationError) as cm:
             self.DataSource.create(
                 {
                     "name": "Test CRVS",
                     "code": "test_crvs",
                     "base_url": "https://crvs.example.org/api",
-                    "auth_type": "basic",
+                    "auth_type": "bearer",
+                    "bearer_token": "tok",
                 }
             )
         self.assertIn("sender id", str(cm.exception).lower())

spp_dci_client/tests/test_data_source_http.py

@@ -142,19 +142,6 @@ def test_get_headers_bearer(self):
         )
         self.assertEqual(ds.get_headers()["Authorization"], "Bearer btok")
 
-    def test_get_headers_basic_not_implemented(self):
-        ds = self.DataSource.create(
-            {
-                "name": "Basic DS",
-                "code": "basic_ds",
-                "base_url": "https://dci.example.org/api",
-                "auth_type": "basic",
-                "our_sender_id": "openspp.test",
-            }
-        )
-        with self.assertRaises(UserError):
-            ds.get_headers()
-
     # --- test_connection -----------------------------------------------------
 
     def test_connection_success_activates(self):