Merge pull request #293 from OpenSPP/fix/1125-cr-type-disable-document-creation

fix(change_request_v2): disable inline creation of CR document types in CR Type Documents tab (#1125)

Author: emjay0921

spp_change_request_v2/README.rst

@@ -853,6 +853,16 @@ Before declaring a new CR type complete:
 Changelog
 =========
 
+19.0.2.0.8
+~~~~~~~~~~
+
+- fix(views): disable inline creation of CR document types on the Change
+  Request Type "Documents" tab — the ``Available Documents`` field now
+  only selects existing ``cr_document_type`` vocabulary codes
+  (``no_create`` / ``no_quick_create``), matching
+  ``Required Documents``. This removes the broken "Create Available
+  Documents" modal (missing Name field) that blocked saving (#1125)
+
 19.0.2.0.7
 ~~~~~~~~~~
 

spp_change_request_v2/__manifest__.py

@@ -1,6 +1,6 @@
 {
     "name": "OpenSPP Change Request V2",
-    "version": "19.0.2.0.7",
+    "version": "19.0.2.0.8",
     "sequence": 50,
     "category": "OpenSPP",
     "summary": "Configuration-driven change request system with UX improvements, conflict detection and duplicate prevention",

spp_change_request_v2/readme/HISTORY.md

@@ -1,3 +1,7 @@
+### 19.0.2.0.8
+
+- fix(views): disable inline creation of CR document types on the Change Request Type "Documents" tab — the `Available Documents` field now only selects existing `cr_document_type` vocabulary codes (`no_create` / `no_quick_create`), matching `Required Documents`. This removes the broken "Create Available Documents" modal (missing Name field) that blocked saving (#1125)
+
 ### 19.0.2.0.7
 
 - fix(security): align CR Requestor / CR Local Validator / CR HQ Validator roles with the OP#951 menu audit — replace the `spp_registry.group_registry_read` (Tier-3, no menu) link with `spp_registry.group_registry_viewer` so these roles see the Registry menu; add `spp_hazard.group_hazard_viewer` so they retain Hazard visibility once the menu root is gated. Adds `spp_hazard` to module dependencies.

spp_change_request_v2/static/description/index.html

@@ -1339,6 +1339,17 @@ <h2>Changelog</h2>
 </div>
 </div>
 <div class="section" id="section-1">
+<h1>19.0.2.0.8</h1>
+<ul class="simple">
+<li>fix(views): disable inline creation of CR document types on the Change
+Request Type “Documents” tab — the <tt class="docutils literal">Available Documents</tt> field now
+only selects existing <tt class="docutils literal">cr_document_type</tt> vocabulary codes
+(<tt class="docutils literal">no_create</tt> / <tt class="docutils literal">no_quick_create</tt>), matching
+<tt class="docutils literal">Required Documents</tt>. This removes the broken “Create Available
+Documents” modal (missing Name field) that blocked saving (#1125)</li>
+</ul>
+</div>
+<div class="section" id="section-2">
 <h1>19.0.2.0.7</h1>
 <ul class="simple">
 <li>fix(security): align CR Requestor / CR Local Validator / CR HQ
@@ -1350,7 +1361,7 @@ <h1>19.0.2.0.7</h1>
 dependencies.</li>
 </ul>
 </div>
-<div class="section" id="section-2">
+<div class="section" id="section-3">
 <h1>19.0.2.0.6</h1>
 <ul class="simple">
 <li>fix(views): route post-submit CRs (pending / approved / applied /
@@ -1365,7 +1376,7 @@ <h1>19.0.2.0.6</h1>
 list so row-click goes through the stage router.</li>
 </ul>
 </div>
-<div class="section" id="section-3">
+<div class="section" id="section-4">
 <h1>19.0.2.0.5</h1>
 <ul class="simple">
 <li>fix(security): add a global <tt class="docutils literal">ir.rule</tt> on <tt class="docutils literal">spp.change.request</tt> that
@@ -1378,27 +1389,27 @@ <h1>19.0.2.0.5</h1>
 roles).</li>
 </ul>
 </div>
-<div class="section" id="section-4">
+<div class="section" id="section-5">
 <h1>19.0.2.0.3</h1>
 <ul class="simple">
 <li>fix: add HTML escaping to all computed Html fields with
 <tt class="docutils literal">sanitize=False</tt> to prevent stored XSS (#50)</li>
 </ul>
 </div>
-<div class="section" id="section-5">
+<div class="section" id="section-6">
 <h1>19.0.2.0.2</h1>
 <ul class="simple">
 <li>fix: fix batch approval wizard line deletion (#130)</li>
 </ul>
 </div>
-<div class="section" id="section-6">
+<div class="section" id="section-7">
 <h1>19.0.2.0.1</h1>
 <ul class="simple">
 <li>fix: skip field types before getattr and isolate detail prefetch
 (#129)</li>
 </ul>
 </div>
-<div class="section" id="section-7">
+<div class="section" id="section-8">
 <h1>19.0.2.0.0</h1>
 <ul class="simple">
 <li>Initial migration to OpenSPP2</li>

spp_change_request_v2/views/change_request_type_views.xml

@@ -222,7 +222,7 @@
                                     name="available_document_ids"
                                     widget="many2many_tags"
                                     placeholder="Select which document types can be uploaded..."
-                                    context="{'default_vocabulary_id': %(spp_vocabulary.vocabulary_cr_document_type)d}"
+                                    options="{'no_create': True, 'no_quick_create': True}"
                                 />
                                 <field
                                     name="required_document_ids"