fix: include enrollment_date in bulk SQL insert, hoist Date.today()

Set enrollment_date to current timestamp when state is 'enrolled' in
the program membership SQL insert (computed field not triggered by raw
SQL). Hoist fields.Date.today() outside the loop in cycle membership
to avoid repeated calls per record.

Author: kneckinator

spp_programs/models/cycle_membership.py

@@ -120,6 +120,7 @@ def _bulk_insert_on_conflict(self, vals_list, chunk_size=1000):
         cr = self.env.cr
         uid = self.env.uid
         total_inserted = 0
+        today = fields.Date.today()
 
         for i in range(0, len(vals_list), chunk_size):
             batch = vals_list[i : i + chunk_size]
@@ -132,7 +133,7 @@ def _bulk_insert_on_conflict(self, vals_list, chunk_size=1000):
                         v["partner_id"],
                         v["cycle_id"],
                         v.get("state", "draft"),
-                        v.get("enrollment_date", fields.Date.today()),
+                        v.get("enrollment_date", today),
                         uid,
                         uid,
                     ]

spp_programs/models/program_membership.py

@@ -405,25 +405,30 @@ def _bulk_insert_on_conflict(self, vals_list, chunk_size=1000):
         uid = self.env.uid
         total_inserted = 0
 
+        now = fields.Datetime.now()
+
         for i in range(0, len(vals_list), chunk_size):
             batch = vals_list[i : i + chunk_size]
             values = []
             params = []
             for v in batch:
-                values.append("(%s, %s, %s, %s, %s, now(), now())")
+                state = v.get("state", "draft")
+                enrollment_date = now if state == "enrolled" else None
+                values.append("(%s, %s, %s, %s, %s, %s, now(), now())")
                 params.extend(
                     [
                         v["partner_id"],
                         v["program_id"],
-                        v.get("state", "draft"),
+                        state,
+                        enrollment_date,
                         uid,
                         uid,
                     ]
                 )
 
             sql = """
                 INSERT INTO spp_program_membership
-                    (partner_id, program_id, state,
+                    (partner_id, program_id, state, enrollment_date,
                      create_uid, write_uid, create_date, write_date)
                 VALUES {}
                 ON CONFLICT (partner_id, program_id) DO NOTHING