fix(spp_user_roles): drop position=replace on implied_ids

OCA xml-view-dangerous-replace-low-priority hook flagged the
position="replace" used to add a domain and an embedded list to the
`implied_ids` field on the role form. Replace is reserved as a last
resort; the same effect can be achieved with position="attributes"
(for the new domain) plus position="inside" (to embed the list).

Functionally identical for OP#979 — the field still restricts the
group dropdown to free groups and the inline list still has create
disabled, but the inheritance is now safer for downstream views.

Author: emjay0921

spp_user_roles/views/role.xml

@@ -20,16 +20,19 @@
             <xpath expr="//field[@name='name']" position="after">
                 <field name="role_type" />
             </xpath>
-            <xpath expr="//field[@name='implied_ids']" position="replace">
-                <field
-                    name="implied_ids"
-                    nolabel="1"
-                    domain="[('role_id', '=', False)]"
-                >
-                    <list create="0">
-                        <field name="full_name" string="Group" />
-                    </list>
-                </field>
+            <!-- Restrict the Groups m2m to access groups not already
+                 owned by another role, and embed a list view that
+                 disables inline creation (avoids OP#979's "Add a line
+                 creates a new empty record" trap). Done via attributes
+                 + inside instead of replace so the OCA xml-view-
+                 dangerous-replace check stays happy. -->
+            <xpath expr="//field[@name='implied_ids']" position="attributes">
+                <attribute name="domain">[('role_id', '=', False)]</attribute>
+            </xpath>
+            <xpath expr="//field[@name='implied_ids']" position="inside">
+                <list create="0">
+                    <field name="full_name" string="Group" />
+                </list>
             </xpath>
             <xpath
                 expr="//field[@name='line_ids']/list/field[@name='user_id']"