fix(spp_program_geofence): fix spatial query operator and test compatibility

- Use gis_intersects instead of gis_within for Tier 1 spatial query;
  gis_within generates ST_Within(value, field) which is backwards for
  point-in-polygon checks, while gis_intersects is symmetric
- Use disabled=None instead of disabled=False in domain (Datetime field)
- Use fields.Datetime.now() for disabled test data (not Boolean True)
- Use group_ids with Command.link() for Odoo 19 compatibility in tests

Author: jeremi

spp_program_geofence/models/eligibility_manager.py

@@ -108,8 +108,8 @@ def _prepare_eligible_domain(self, membership=None):
             ids = membership.mapped("partner_id.id")
             domain += [("id", "in", ids)]
 
-        # Exclude disabled registrants
-        domain += [("disabled", "=", False)]
+        # Exclude disabled registrants (disabled is a Datetime field)
+        domain += [("disabled", "=", None)]
 
         if self.program_id.target_type == "group":
             domain += [("is_group", "=", True), ("is_registrant", "=", True)]
@@ -145,7 +145,7 @@ def _find_eligible_registrants(self, membership=None):
         base_domain = self._prepare_eligible_domain(membership)
 
         # Tier 1: registrants with coordinates inside the geofence
-        tier1_domain = base_domain + [("coordinates", "gis_within", combined_geojson)]
+        tier1_domain = base_domain + [("coordinates", "gis_intersects", combined_geojson)]
         tier1 = self.env["res.partner"].search(tier1_domain)
 
         # Tier 2: registrants whose area intersects the geofence

spp_program_geofence/tests/test_geofence_eligibility.py

@@ -3,6 +3,7 @@
 
 import json
 
+from odoo import Command, fields
 from odoo.tests import TransactionCase, tagged
 
 
@@ -148,7 +149,7 @@ def setUpClass(cls):
                 "name": "Disabled Registrant",
                 "is_registrant": True,
                 "is_group": False,
-                "disabled": True,
+                "disabled": fields.Datetime.now(),
                 "coordinates": point_inside,
             }
         )
@@ -402,15 +403,9 @@ def setUpClass(cls):
             {
                 "name": "Test Officer",
                 "login": "test_geofence_officer",
-                "groups_id": [
-                    (
-                        6,
-                        0,
-                        [
-                            cls.env.ref("spp_programs.group_programs_officer").id,
-                            cls.env.ref("base.group_user").id,
-                        ],
-                    )
+                "group_ids": [
+                    Command.link(cls.env.ref("spp_programs.group_programs_officer").id),
+                    Command.link(cls.env.ref("base.group_user").id),
                 ],
             }
         )