fix(spp_scoring): address QA findings on thresholds, smart button, strict mode

- #835: threshold gap/overlap check now rounds to 2 decimals before
  comparing. IEEE-754 made 20.00 - 19.99 occasionally compute to
  0.010000000000000009, triggering a false "gap" error on valid
  contiguous boundaries.
- #837: Scores smart button was inheriting base.view_partner_form,
  but spp_registry.view_individuals_form replaces the //sheet, so the
  button never showed on Individual or Group registrant pages. Inherit
  the registry form instead. Drop the now-redundant is_registrant
  guard — the registry form is only opened on registrants.
- #838: strict mode detected missing/invalid required indicators but
  still created the score record with is_complete=False. Now it raises
  UserError, preventing an incomplete score from being persisted and
  downstream enrollment logic from acting on it.

Author: emjay0921

spp_scoring/models/scoring_engine.py

@@ -115,13 +115,26 @@ def calculate_score(self, registrant, scoring_model, mode="manual"):
         if calculation_method == "cel_formula":
             total_score = self._calculate_cel_total(scoring_model, registrant, inputs_snapshot)
 
+        # In strict mode, required-indicator failures must prevent score creation
+        # (not just mark the result incomplete) — otherwise an invalid score
+        # can still enroll a registrant.
+        if errors and is_strict_mode:
+            raise UserError(
+                _(
+                    "Cannot calculate score for '%(name)s' in strict mode. "
+                    "%(count)d required indicator(s) failed:\n- %(errors)s"
+                )
+                % {
+                    "name": registrant.display_name,
+                    "count": len(errors),
+                    "errors": "\n- ".join(errors),
+                }
+            )
+
         # Determine classification (thresholds already prefetched)
         classification = self._get_classification(total_score, scoring_model)
 
-        # Check for errors in strict mode
         is_complete = True
-        if errors and is_strict_mode:
-            is_complete = False
 
         # Create result record
         Result = self.env["spp.scoring.result"]

spp_scoring/models/scoring_model.py

@@ -270,10 +270,12 @@ def _validate_thresholds(self):
 
         sorted_thresholds = self.threshold_ids.sorted(key=lambda t: t.min_score)
 
-        # Check all consecutive threshold boundaries for gaps and overlaps
+        # Check all consecutive threshold boundaries for gaps and overlaps.
+        # Round to 2 decimal places to avoid IEEE-754 false positives
+        # (e.g., 20.00 - 19.99 computing to 0.010000000000000009).
         for i, threshold in enumerate(sorted_thresholds[:-1]):
             next_threshold = sorted_thresholds[i + 1]
-            gap = next_threshold.min_score - threshold.max_score
+            gap = round(next_threshold.min_score - threshold.max_score, 2)
 
             if gap > 0.01:
                 errors.append(
@@ -285,7 +287,7 @@ def _validate_thresholds(self):
                         "min": next_threshold.min_score,
                     }
                 )
-            elif gap < -0.01:
+            elif gap < 0:
                 errors.append(
                     _("Overlap detected between thresholds '%(current)s' (max %(max)s) and '%(next)s' (min %(min)s).")
                     % {

spp_scoring/views/res_partner_views.xml

@@ -1,18 +1,20 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo>
-    <!-- Add Scores smart button to registrant form -->
-    <record id="view_res_partner_form_scoring" model="ir.ui.view">
-        <field name="name">res.partner.form.scoring</field>
+    <!-- Add Scores smart button to the OpenSPP registrant form.
+         spp_registry.view_individuals_form replaces //sheet on res.partner,
+         so inheriting base.view_partner_form does not propagate to the
+         registry form used by Individuals and Groups. -->
+    <record id="view_registrant_form_scoring" model="ir.ui.view">
+        <field name="name">spp_registry.view_registrant_form.scoring</field>
         <field name="model">res.partner</field>
-        <field name="inherit_id" ref="base.view_partner_form" />
+        <field name="inherit_id" ref="spp_registry.view_individuals_form" />
         <field name="arch" type="xml">
             <xpath expr="//div[@name='button_box']" position="inside">
                 <button
                     name="action_view_scoring_results"
                     type="object"
                     class="oe_stat_button"
                     icon="fa-bar-chart"
-                    invisible="not is_registrant"
                 >
                     <field
                         name="scoring_result_count"