test(spp_programs): add comprehensive tests for deduplication, enrollment, and membership

Author: emjay0921

spp_programs/models/managers/deduplication_manager.py

@@ -138,10 +138,7 @@ def _check_duplicate_by_individual_ids(self, beneficiaries):
 
             individual_rec = self.env["res.partner"].browse(individual_id)
             group_names = duplicate_beneficiaries.mapped("partner_id.name")
-            reason = (
-                f"Shared member: {individual_rec.name} "
-                f"found in {len(group_ids)} groups ({', '.join(group_names)})"
-            )
+            reason = f"Shared member: {individual_rec.name} found in {len(group_ids)} groups ({', '.join(group_names)})"
             self._record_duplicate(self, duplicate_beneficiariy_ids, reason)
 
             duplicated_enrolled = duplicate_beneficiaries.filtered(lambda rec: rec.state == "enrolled")
@@ -277,9 +274,7 @@ def _check_duplicate_by_group_with_individual(self, beneficiaries):
         # Build mapping: individual_id -> list of duplicate ID doc descriptions
         individual_dup_docs = {}
         for doc in duplicated_doc_ids:
-            individual_dup_docs.setdefault(doc.partner_id.id, []).append(
-                f"{doc.id_type_id.display}: {doc.value}"
-            )
+            individual_dup_docs.setdefault(doc.partner_id.id, []).append(f"{doc.id_type_id.display}: {doc.value}")
 
         group_of_duplicates = {}
         for group_membership in group_with_duplicates:
@@ -296,10 +291,7 @@ def _check_duplicate_by_group_with_individual(self, beneficiaries):
 
             individual_rec = self.env["res.partner"].browse(individual_id)
             doc_info = ", ".join(individual_dup_docs.get(individual_id, []))
-            reason = (
-                f"Duplicate ID document ({doc_info}) "
-                f"on member: {individual_rec.name}"
-            )
+            reason = f"Duplicate ID document ({doc_info}) on member: {individual_rec.name}"
             self._record_duplicate(self, duplicate_beneficiariy_ids, reason)
 
             duplicated_enrolled = duplicate_beneficiaries.filtered(lambda rec: rec.state == "enrolled")
@@ -361,10 +353,7 @@ def _check_duplicate_by_individual(self, beneficiaries):
                 continue
 
             names = dup_memberships.mapped("partner_id.name")
-            reason = (
-                f"Duplicate ID document ({doc_key}) "
-                f"shared by: {', '.join(names)}"
-            )
+            reason = f"Duplicate ID document ({doc_key}) shared by: {', '.join(names)}"
             self._record_duplicate(self, dup_memberships.ids, reason)
 
             # Keep-one-enrolled logic
@@ -373,9 +362,9 @@ def _check_duplicate_by_individual(self, beneficiaries):
                 to_mark = dup_memberships.filtered(lambda rec: rec.state != "enrolled")
             else:
                 to_mark = dup_memberships
-            to_mark.filtered(
-                lambda rec: rec.state not in ["exited", "not_eligible", "duplicated"]
-            ).write({"state": "duplicated"})
+            to_mark.filtered(lambda rec: rec.state not in ["exited", "not_eligible", "duplicated"]).write(
+                {"state": "duplicated"}
+            )
 
             all_duplicated_memberships |= dup_memberships
 
@@ -501,9 +490,7 @@ def _check_duplicate_by_group_with_individual(self, beneficiaries):
         # Build mapping: individual_id -> list of duplicate phone numbers
         individual_dup_phones = {}
         for phone_rec in duplicate_individuals_ids:
-            individual_dup_phones.setdefault(phone_rec.partner_id.id, []).append(
-                phone_rec.phone_no
-            )
+            individual_dup_phones.setdefault(phone_rec.partner_id.id, []).append(phone_rec.phone_no)
 
         group_of_duplicates = {}
         for group_membership in group_with_duplicates:
@@ -520,10 +507,7 @@ def _check_duplicate_by_group_with_individual(self, beneficiaries):
 
             individual_rec = self.env["res.partner"].browse(individual_id)
             phone_info = ", ".join(individual_dup_phones.get(individual_id, []))
-            reason = (
-                f"Duplicate phone number ({phone_info}) "
-                f"on member: {individual_rec.name}"
-            )
+            reason = f"Duplicate phone number ({phone_info}) on member: {individual_rec.name}"
             self._record_duplicate(self, duplicate_beneficiariy_ids, reason)
 
             duplicated_enrolled = duplicate_beneficiaries.filtered(lambda rec: rec.state == "enrolled")
@@ -600,10 +584,7 @@ def _check_duplicate_by_individual(self, beneficiaries):
                 continue
 
             names = dup_memberships.mapped("partner_id.name")
-            reason = (
-                f"Duplicate phone number ({phone_val}) "
-                f"shared by: {', '.join(names)}"
-            )
+            reason = f"Duplicate phone number ({phone_val}) shared by: {', '.join(names)}"
             self._record_duplicate(self, dup_memberships.ids, reason)
 
             # Keep-one-enrolled logic
@@ -612,9 +593,9 @@ def _check_duplicate_by_individual(self, beneficiaries):
                 to_mark = dup_memberships.filtered(lambda rec: rec.state != "enrolled")
             else:
                 to_mark = dup_memberships
-            to_mark.filtered(
-                lambda rec: rec.state not in ["exited", "not_eligible", "duplicated"]
-            ).write({"state": "duplicated"})
+            to_mark.filtered(lambda rec: rec.state not in ["exited", "not_eligible", "duplicated"]).write(
+                {"state": "duplicated"}
+            )
 
             all_duplicated_memberships |= dup_memberships
 

spp_programs/models/managers/program_manager.py

@@ -217,9 +217,7 @@ def _enroll_eligible_registrants(self, states, offset=0, limit=None, do_count=Fa
         # Exclude members that are duplicated or exited — those states
         # should only be changed through their own workflows.
         _logger.debug("members filtered: %s", members)
-        not_enrolled = members.filtered(
-            lambda m: m.state not in ("enrolled", "duplicated", "exited")
-        )
+        not_enrolled = members.filtered(lambda m: m.state not in ("enrolled", "duplicated", "exited"))
         _logger.debug("not_enrolled: %s", not_enrolled)
         not_enrolled.write(
             {
@@ -230,8 +228,7 @@ def _enroll_eligible_registrants(self, states, offset=0, limit=None, do_count=Fa
         # dis-enroll the one not eligible anymore:
         enrolled_members_ids = members.ids
         members_to_remove = member_before.filtered(
-            lambda m: m.state not in ("not_eligible", "duplicated", "exited")
-            and m.id not in enrolled_members_ids
+            lambda m: m.state not in ("not_eligible", "duplicated", "exited") and m.id not in enrolled_members_ids
         )
         # _logger.debug("members_to_remove: %s", members_to_remove)
         members_to_remove.write(

spp_programs/models/programs.py

@@ -399,13 +399,9 @@ def deduplicate_beneficiaries(self):
                 if total_duplicated > 0:
                     parts = []
                     if new_duplicates > 0:
-                        parts.append(
-                            _("%(new)s new duplicate(s) found", new=new_duplicates)
-                        )
+                        parts.append(_("%(new)s new duplicate(s) found", new=new_duplicates))
                     if already_duplicated > 0:
-                        parts.append(
-                            _("%(existing)s already flagged", existing=already_duplicated)
-                        )
+                        parts.append(_("%(existing)s already flagged", existing=already_duplicated))
                     message = ", ".join(parts) + "."
                     kind = "warning"
                 elif duplicates > 0:

spp_programs/tests/__init__.py

@@ -1,17 +1,24 @@
+from . import common_compliance
+from . import test_compliance_cel
 from . import test_create_program_wiz
+from . import test_create_program_wizard_cash
+from . import test_create_program_wizard_cel
+from . import test_create_program_wizard_inkind
+from . import test_cycle
+from . import test_cycle_auto_approve_fund_check
+from . import test_deduplication
+from . import test_eligibility_cel
+from . import test_eligibility_cel_integration
 from . import test_enrollment_wizard
-from . import test_entitlement_report_wiz
 from . import test_entitlement
+from . import test_entitlement_amount_cel
+from . import test_entitlement_manager_cash
+from . import test_entitlement_manager_inkind
+from . import test_entitlement_report_wiz
+from . import test_program_enrollment
+from . import test_program_membership
 from . import test_programs
 from . import test_registrant
-from . import test_stock_rule
-from . import test_cycle
-from . import common_compliance
 from . import test_spp_cycle_compliance
 from . import test_spp_program_create_wizard_compliance
-from . import test_entitlement_manager_cash
-from . import test_create_program_wizard_cash
-from . import test_eligibility_cel
-from . import test_eligibility_cel_integration
-from . import test_compliance_cel
-from . import test_create_program_wizard_cel
+from . import test_stock_rule