Merge remote-tracking branch 'origin/19.0' into feat/876-create-group-cr-redesign

# Conflicts:
#	spp_change_request_v2/README.rst
#	spp_change_request_v2/__manifest__.py
#	spp_change_request_v2/readme/HISTORY.md
#	spp_change_request_v2/static/description/index.html
#	spp_mis_demo_v2/README.rst
#	spp_mis_demo_v2/readme/HISTORY.md
#	spp_mis_demo_v2/static/description/index.html

Author: emjay0921

spp_change_request_v2/README.rst

@@ -874,6 +874,16 @@ Changelog
   ``relationship_id``); downstream modules that extended the old flow
   must adapt (see #1133).
 
+19.0.2.0.8
+~~~~~~~~~~
+
+- fix(views): disable inline creation of CR document types on the Change
+  Request Type "Documents" tab — the ``Available Documents`` field now
+  only selects existing ``cr_document_type`` vocabulary codes
+  (``no_create`` / ``no_quick_create``), matching
+  ``Required Documents``. This removes the broken "Create Available
+  Documents" modal (missing Name field) that blocked saving (#1125)
+
 19.0.2.0.7
 ~~~~~~~~~~
 

spp_change_request_v2/readme/HISTORY.md

@@ -4,6 +4,10 @@
 - fix(change_request): Split Household "New Household Information" shows a fillable Address field, and the new-household **Latitude/Longitude** are surfaced with an interactive **map** (`spp_gis`, OSM basemap) to pick/preview the location — the two stay in sync and out-of-range coordinates are rejected. The review page surfaces the coordinates plus the new household's Phone / Bank / ID lines as tables (#877)
 - **Breaking:** the Add Member detail no longer exposes the create-a-new-individual fields (`created_individual_id`, `given_name`, `family_name`, `birthdate`, `gender_id`, `relationship_id`); downstream modules that extended the old flow must adapt (see #1133).
 
+### 19.0.2.0.8
+
+- fix(views): disable inline creation of CR document types on the Change Request Type "Documents" tab — the `Available Documents` field now only selects existing `cr_document_type` vocabulary codes (`no_create` / `no_quick_create`), matching `Required Documents`. This removes the broken "Create Available Documents" modal (missing Name field) that blocked saving (#1125)
+
 ### 19.0.2.0.7
 
 - fix(security): align CR Requestor / CR Local Validator / CR HQ Validator roles with the OP#951 menu audit — replace the `spp_registry.group_registry_read` (Tier-3, no menu) link with `spp_registry.group_registry_viewer` so these roles see the Registry menu; add `spp_hazard.group_hazard_viewer` so they retain Hazard visibility once the menu root is gated. Adds `spp_hazard` to module dependencies.

spp_change_request_v2/static/description/index.html

@@ -1361,6 +1361,17 @@ <h1>19.0.3.0.0</h1>
 </ul>
 </div>
 <div class="section" id="section-2">
+<h1>19.0.2.0.8</h1>
+<ul class="simple">
+<li>fix(views): disable inline creation of CR document types on the Change
+Request Type “Documents” tab — the <tt class="docutils literal">Available Documents</tt> field now
+only selects existing <tt class="docutils literal">cr_document_type</tt> vocabulary codes
+(<tt class="docutils literal">no_create</tt> / <tt class="docutils literal">no_quick_create</tt>), matching
+<tt class="docutils literal">Required Documents</tt>. This removes the broken “Create Available
+Documents” modal (missing Name field) that blocked saving (#1125)</li>
+</ul>
+</div>
+<div class="section" id="section-3">
 <h1>19.0.2.0.7</h1>
 <ul class="simple">
 <li>fix(security): align CR Requestor / CR Local Validator / CR HQ
@@ -1372,7 +1383,7 @@ <h1>19.0.2.0.7</h1>
 dependencies.</li>
 </ul>
 </div>
-<div class="section" id="section-3">
+<div class="section" id="section-4">
 <h1>19.0.2.0.6</h1>
 <ul class="simple">
 <li>fix(views): route post-submit CRs (pending / approved / applied /
@@ -1387,7 +1398,7 @@ <h1>19.0.2.0.6</h1>
 list so row-click goes through the stage router.</li>
 </ul>
 </div>
-<div class="section" id="section-4">
+<div class="section" id="section-5">
 <h1>19.0.2.0.5</h1>
 <ul class="simple">
 <li>fix(security): add a global <tt class="docutils literal">ir.rule</tt> on <tt class="docutils literal">spp.change.request</tt> that
@@ -1400,27 +1411,27 @@ <h1>19.0.2.0.5</h1>
 roles).</li>
 </ul>
 </div>
-<div class="section" id="section-5">
+<div class="section" id="section-6">
 <h1>19.0.2.0.3</h1>
 <ul class="simple">
 <li>fix: add HTML escaping to all computed Html fields with
 <tt class="docutils literal">sanitize=False</tt> to prevent stored XSS (#50)</li>
 </ul>
 </div>
-<div class="section" id="section-6">
+<div class="section" id="section-7">
 <h1>19.0.2.0.2</h1>
 <ul class="simple">
 <li>fix: fix batch approval wizard line deletion (#130)</li>
 </ul>
 </div>
-<div class="section" id="section-7">
+<div class="section" id="section-8">
 <h1>19.0.2.0.1</h1>
 <ul class="simple">
 <li>fix: skip field types before getattr and isolate detail prefetch
 (#129)</li>
 </ul>
 </div>
-<div class="section" id="section-8">
+<div class="section" id="section-9">
 <h1>19.0.2.0.0</h1>
 <ul class="simple">
 <li>Initial migration to OpenSPP2</li>

spp_change_request_v2/views/change_request_type_views.xml

@@ -230,7 +230,7 @@
                                     name="available_document_ids"
                                     widget="many2many_tags"
                                     placeholder="Select which document types can be uploaded..."
-                                    context="{'default_vocabulary_id': %(spp_vocabulary.vocabulary_cr_document_type)d}"
+                                    options="{'no_create': True, 'no_quick_create': True}"
                                 />
                                 <field
                                     name="required_document_ids"

spp_farmer_registry/README.rst

@@ -68,6 +68,17 @@ Model                 Description
 Changelog
 =========
 
+19.0.2.0.3
+~~~~~~~~~~
+
+- fix(farm): remove the farm membership-completeness warnings entirely —
+  both the "No head member designated" and "No members linked to this
+  group yet" banners, their "No Head Member" / "No Members" search
+  filters, the ``member_count`` and head-member list columns, and the
+  backing ``has_head_member`` / ``member_count`` computed fields. The
+  head-member check misfired on farm groups that did have a head, and
+  per #1113 no such warnings should be shown (#1113)
+
 19.0.2.0.2
 ~~~~~~~~~~
 

spp_farmer_registry/__manifest__.py

@@ -3,7 +3,7 @@
     "name": "OpenSPP Farmer Registry",
     "summary": "Farmer Registry with vocabulary-based fields, CEL variables, and Logic Studio integration",
     "category": "OpenSPP",
-    "version": "19.0.2.0.2",
+    "version": "19.0.2.0.3",
     "sequence": 1,
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/OpenSPP2",

spp_farmer_registry/models/farm.py

@@ -148,27 +148,6 @@ class Farm(models.Model):
         help="Sum of all livestock activity quantities",
     )
 
-    # ═══════════════════════════════════════════════════════════════════════
-    # MEMBERSHIP COMPLETENESS (#939)
-    # ═══════════════════════════════════════════════════════════════════════
-    # Farm-registry users need to surface farms that aren't usable yet because
-    # nobody is associated with them, or because no member is flagged as the
-    # head of household. Stored so the search filters and list-row decoration
-    # can use them without triggering N+1 reads.
-
-    member_count = fields.Integer(
-        string="# Members",
-        compute="_compute_member_membership_state",
-        store=True,
-        help="Number of non-ended members linked to this farm/group.",
-    )
-    has_head_member = fields.Boolean(
-        string="Has Head Member",
-        compute="_compute_member_membership_state",
-        store=True,
-        help="True when at least one non-ended member carries the 'head' membership type.",
-    )
-
     # ═══════════════════════════════════════════════════════════════════════
     # COMPUTED METHODS
     # ═══════════════════════════════════════════════════════════════════════
@@ -217,21 +196,6 @@ def _compute_total_livestock_heads(self):
         for record in self:
             record.total_livestock_heads = sum(act.quantity or 0 for act in record.farm_livestock_act_ids)
 
-    @api.depends(
-        "group_membership_ids",
-        "group_membership_ids.is_ended",
-        "group_membership_ids.membership_type_ids",
-    )
-    def _compute_member_membership_state(self):
-        """Compute member_count and has_head_member from non-ended memberships."""
-        head_code = self.env["spp.vocabulary.code"].get_code("urn:openspp:vocab:group-membership-type", "head")
-        for record in self:
-            active_members = record.group_membership_ids.filtered(lambda m: not m.is_ended)
-            record.member_count = len(active_members)
-            record.has_head_member = bool(
-                head_code and active_members.filtered(lambda m: head_code in m.membership_type_ids)
-            )
-
     # ═══════════════════════════════════════════════════════════════════════
     # HELPER METHODS
     # ═══════════════════════════════════════════════════════════════════════

spp_farmer_registry/readme/HISTORY.md

@@ -1,3 +1,7 @@
+### 19.0.2.0.3
+
+- fix(farm): remove the farm membership-completeness warnings entirely — both the "No head member designated" and "No members linked to this group yet" banners, their "No Head Member" / "No Members" search filters, the `member_count` and head-member list columns, and the backing `has_head_member` / `member_count` computed fields. The head-member check misfired on farm groups that did have a head, and per #1113 no such warnings should be shown (#1113)
+
 ### 19.0.2.0.2
 
 - fix(security): align Farm User / Farm Manager roles with the OP#951 menu audit — both farm roles now imply `spp_hazard.group_hazard_viewer` and `spp_gis_report.group_gis_report_user` so they retain Hazard and GIS Reports menu visibility once those menu roots are gated. Adds `spp_hazard` and `spp_gis_report` to module dependencies.

spp_farmer_registry/static/description/index.html

@@ -436,6 +436,18 @@ <h2><a class="toc-backref" href="#toc-entry-1">Changelog</a></h2>
 </div>
 </div>
 <div class="section" id="section-1">
+<h1>19.0.2.0.3</h1>
+<ul class="simple">
+<li>fix(farm): remove the farm membership-completeness warnings entirely —
+both the “No head member designated” and “No members linked to this
+group yet” banners, their “No Head Member” / “No Members” search
+filters, the <tt class="docutils literal">member_count</tt> and head-member list columns, and the
+backing <tt class="docutils literal">has_head_member</tt> / <tt class="docutils literal">member_count</tt> computed fields. The
+head-member check misfired on farm groups that did have a head, and
+per #1113 no such warnings should be shown (#1113)</li>
+</ul>
+</div>
+<div class="section" id="section-2">
 <h1>19.0.2.0.2</h1>
 <ul class="simple">
 <li>fix(security): align Farm User / Farm Manager roles with the OP#951
@@ -446,15 +458,15 @@ <h1>19.0.2.0.2</h1>
 <tt class="docutils literal">spp_hazard</tt> and <tt class="docutils literal">spp_gis_report</tt> to module dependencies.</li>
 </ul>
 </div>
-<div class="section" id="section-2">
+<div class="section" id="section-3">
 <h1>19.0.2.0.1</h1>
 <ul class="simple">
 <li>fix(views): apply <tt class="docutils literal">spp_registry.x2many_no_padding</tt> widget to the
 farm activities list on farm forms — removes the four empty
 placeholder rows Odoo 19 inserts on inline list-in-form views (#943).</li>
 </ul>
 </div>
-<div class="section" id="section-3">
+<div class="section" id="section-4">
 <h1>19.0.2.0.0</h1>
 <ul class="simple">
 <li>Initial migration to OpenSPP2</li>

spp_farmer_registry/views/farm_views.xml

@@ -222,81 +222,6 @@
         </field>
     </record>
 
-    <!-- ═══════════════════════════════════════════════════════════════════════
-         Farm membership-completeness UX (#939)
-         ═══════════════════════════════════════════════════════════════════════ -->
-
-    <!-- Search filters: surface farms with no members or no head member -->
-    <record id="view_registry_groups_filter_farm" model="ir.ui.view">
-        <field name="name">res.partner.search.farm.member_completeness</field>
-        <field name="model">res.partner</field>
-        <field name="inherit_id" ref="spp_registry.view_registry_groups_filter" />
-        <field name="priority">50</field>
-        <field name="arch" type="xml">
-            <xpath expr="//filter[@name='has_phone']" position="after">
-                <separator />
-                <filter
-                    string="No Members"
-                    name="no_members"
-                    domain="[('member_count', '=', 0)]"
-                />
-                <filter
-                    string="No Head Member"
-                    name="no_head_member"
-                    domain="[('has_head_member', '=', False)]"
-                />
-            </xpath>
-        </field>
-    </record>
-
-    <!-- List view: warning decoration + optional column for member count.
-         The decoration scopes to farm records (those with farm_type_id set)
-         so it doesn't fire on plain group registrants. -->
-    <record id="view_groups_list_tree_farm" model="ir.ui.view">
-        <field name="name">res.partner.list.farm.member_completeness</field>
-        <field name="model">res.partner</field>
-        <field name="inherit_id" ref="spp_registry.view_groups_list_tree" />
-        <field name="priority">50</field>
-        <field name="arch" type="xml">
-            <xpath expr="//list" position="inside">
-                <field name="member_count" optional="hide" />
-                <field name="has_head_member" optional="hide" widget="boolean" />
-            </xpath>
-        </field>
-    </record>
-
-    <!-- Form-top banners: warn when a group has no members, or has members
-         but no designated head. The two banners are mutually exclusive:
-         no-members fires only when member_count == 0; no-head fires only
-         when there are members but none flagged as head. Scoped to
-         is_group so neither appears on individuals. -->
-    <record id="view_individuals_form_farm_no_members" model="ir.ui.view">
-        <field name="name">res.partner.form.farm.member_completeness_banners</field>
-        <field name="model">res.partner</field>
-        <field name="inherit_id" ref="spp_registry.view_individuals_form" />
-        <field name="priority">50</field>
-        <field name="arch" type="xml">
-            <xpath expr="//div[@name='button_box']" position="before">
-                <div
-                    class="alert alert-warning text-center"
-                    role="alert"
-                    invisible="not is_group or member_count != 0"
-                >
-                    <i class="fa fa-exclamation-triangle me-2" title="Warning" />
-                    No members linked to this group yet.
-                </div>
-                <div
-                    class="alert alert-danger text-center"
-                    role="alert"
-                    invisible="not is_group or member_count == 0 or has_head_member"
-                >
-                    <i class="fa fa-exclamation-triangle me-2" title="Warning" />
-                    No head member designated.
-                </div>
-            </xpath>
-        </field>
-    </record>
-
     <!-- Add view activity actions to res.partner -->
     <record id="res_partner_view_crop_activities" model="ir.actions.server">
         <field name="name">View Crop Activities</field>