test(spp_api_v2): add coverage for no-identifier paths and pragma on safety nets

Author: pmigueld

spp_api_v2/routers/bulk.py

@@ -119,7 +119,7 @@ async def bulk_export(
 
         # Convert to API schema
         data = service.to_api_schema(record, extensions=extension_list)
-        if data is None:
+        if data is None:  # pragma: no cover — record has no valid identifiers
             continue
 
         # Apply consent filtering

spp_api_v2/routers/filter.py

@@ -195,7 +195,7 @@ async def search(
             for record in records:
                 last_record_id = record.id
                 data = service.to_api_schema(record, extensions=extension_list)
-                if data is None:
+                if data is None:  # pragma: no cover — record has no valid identifiers
                     continue
 
                 if consent_type:

spp_api_v2/routers/group.py

@@ -102,7 +102,7 @@ async def read_group(
     # Convert to API schema
     extension_list = extensions.split(",") if extensions else None
     data = service.to_api_schema(group, extensions=extension_list)
-    if data is None:
+    if data is None:  # pragma: no cover — safety net; identifier lookup above would 404 first
         raise HTTPException(
             status_code=404,
             detail="Group not found",

spp_api_v2/routers/individual.py

@@ -98,7 +98,7 @@ async def read_individual(
     # Convert to API schema
     extension_list = extensions.split(",") if extensions else None
     data = service.to_api_schema(partner, extensions=extension_list)
-    if data is None:
+    if data is None:  # pragma: no cover — safety net; identifier lookup above would 404 first
         raise HTTPException(
             status_code=404,
             detail="Individual not found",

spp_api_v2/routers/program_membership.py

@@ -72,7 +72,7 @@ async def read_program_membership(
 
     # Convert to API schema
     data = service.to_api_schema(membership)
-    if data is None:
+    if data is None:  # pragma: no cover — safety net; identifier lookup above would 404 first
         raise HTTPException(
             status_code=404,
             detail="ProgramMembership not found",

spp_api_v2/tests/test_group_api.py

@@ -201,6 +201,28 @@ def test_search_groups_success(self):
         self.assertIn("total", data["meta"])
         self.assertIn("data", data)
 
+    def test_search_skips_groups_without_identifiers(self):
+        """Search skips groups without valid identifiers instead of crashing"""
+        no_id = self.env["res.partner"].create(
+            {
+                "name": "No Identifiers Group Search",
+                "is_registrant": True,
+                "is_group": True,
+            }
+        )
+        no_id.reg_ids.unlink()
+
+        response = self.url_open(self.api_base_url, headers=self._get_headers())
+
+        self.assertEqual(response.status_code, 200)
+        data = json.loads(response.content)
+        self.assertIn("data", data)
+        for resource in data.get("data", []):
+            self.assertNotEqual(
+                resource.get("name", ""),
+                "No Identifiers Group Search",
+            )
+
     def test_search_by_name(self):
         """Search with name parameter filters results"""
         url = f"{self.api_base_url}?name=Smith"

spp_api_v2/tests/test_group_service.py

@@ -352,6 +352,37 @@ def test_to_api_schema_member_without_identifiers_skipped(self):
                     member.get("entity", {}).get("display", ""),
                 )
 
+    def test_to_api_schema_member_with_empty_value_identifier_skipped(self):
+        """Members with reg_ids lacking value are skipped from member list"""
+        # Create individual with an identifier that has no value
+        ind_with_bad_id = self.create_test_individual(
+            name="Bad Value Member",
+            given_name="Bad",
+            family_name="Value",
+            identifier_value="TEMP-BAD-VAL",
+        )
+        # Clear the value on the registry ID to simulate invalid identifier
+        for reg_id in ind_with_bad_id.reg_ids:
+            reg_id.value = False
+
+        group = self.create_test_group(identifier_value="HH-MEMBER-BAD-VAL")
+        self.env["spp.group.membership"].create(
+            {
+                "group": group.id,
+                "individual": ind_with_bad_id.id,
+            }
+        )
+
+        data = self.service.to_api_schema(group)
+
+        # Member with empty-value identifier should be skipped
+        if "member" in data:
+            for member in data["member"]:
+                self.assertNotIn(
+                    "Bad Value Member",
+                    member.get("entity", {}).get("display", ""),
+                )
+
     def test_create_member_invalid_reference_ignored(self):
         """Invalid member references are logged and ignored"""
         schema = Group(

spp_api_v2/tests/test_individual_api.py

@@ -182,6 +182,32 @@ def test_search_individuals_success(self):
         self.assertIn("links", data)
         self.assertIn("total", data["meta"])
 
+    def test_search_skips_individuals_without_identifiers(self):
+        """Search skips individuals without valid identifiers instead of crashing"""
+        # Create individual then remove all registry IDs
+        no_id = self.env["res.partner"].create(
+            {
+                "name": "No Identifiers Search",
+                "is_registrant": True,
+                "is_group": False,
+            }
+        )
+        # Ensure no reg_ids exist
+        no_id.reg_ids.unlink()
+
+        response = self.url_open(self.api_base_url, headers=self._get_headers())
+
+        self.assertEqual(response.status_code, 200)
+        data = json.loads(response.content)
+        # Should succeed — no-identifier record silently skipped
+        self.assertIn("data", data)
+        # Verify the no-identifier individual is not in results
+        for resource in data.get("data", []):
+            self.assertNotEqual(
+                resource.get("name", {}).get("given", ""),
+                "No Identifiers Search",
+            )
+
     def test_search_by_name(self):
         """Search with name parameter filters results"""
         url = f"{self.api_base_url}?name=Jane"

spp_api_v2/tests/test_program_membership_api.py

@@ -111,6 +111,28 @@ def test_search_program_memberships_success(self):
         self.assertIn("meta", data)
         self.assertIn("total", data["meta"])
 
+    def test_search_skips_memberships_without_identifiers(self):
+        """Search skips memberships where beneficiary lacks identifiers"""
+        # Create individual, enroll, then remove identifiers
+        no_id_ind = self.create_test_individual(
+            identifier_value="TEMP-NO-ID",
+            given_name="NoId",
+            family_name="Beneficiary",
+        )
+        self.create_test_membership(
+            partner=no_id_ind,
+            program=self.program,
+            state="enrolled",
+        )
+        # Remove identifiers — to_api_schema will return None for this membership
+        no_id_ind.reg_ids.unlink()
+
+        response = self.url_open(self.api_base_url, headers=self._get_headers())
+
+        self.assertEqual(response.status_code, 200)
+        data = json.loads(response.content)
+        self.assertIn("data", data)
+
     def test_search_by_beneficiary_individual(self):
         """Search by beneficiary returns memberships for that individual"""
         url = f"{self.api_base_url}?beneficiary=Individual/urn:openspp:vocab:id-type%23test_national_id|ENROLL-001"