refactor(spp_programs,spp_change_request_v2): remove dead _prepare_domain overrides (OP#989)

Round-2 replaced the Python search_read / web_search_read overrides
with ir.rule records that filter every ORM read path (search, count,
read_group, name_search, related-field traversal). The earlier Python
hooks were left in place by mistake — they only caught two of those
paths and are now strictly redundant given the rule does more.

Drop the dead code. Behaviour is unchanged (ir.rule still scopes the
same reads). Reduces the codecov/patch denominator since the removed
lines were never executed under area-restricted users.

Author: emjay0921

spp_change_request_v2/models/change_request.py

@@ -1652,38 +1652,3 @@ def action_goto_review(self):
                 },
             },
         }
-
-    # ─── Area-based filtering (OP#989) ──────────────────────────────────
-    # Mirrors the `_prepare_domain` pattern from
-    # spp_area/models/registrant.py so a user with a local role (i.e.
-    # `center_area_ids` set on res.users by spp_area) only sees change
-    # requests whose registrant is in one of their assigned areas (or
-    # any descendant). Users without center areas (global roles) get
-    # no extra filter — same as before. Without this override the CR
-    # list and review screens ignored center-area boundaries even
-    # though the registrant filter on res.partner respected them.
-
-    @api.model
-    def _prepare_domain(self, domain):
-        domain = domain or []
-        user = self.env.user
-        # Guard for installs without spp_area — the field would not
-        # exist on res.users in that case. spp_change_request_v2 does
-        # not yet hard-depend on spp_area, so the guard keeps this
-        # override safe even when spp_area isn't loaded.
-        center_area_ids = getattr(user, "center_area_ids", None)
-        if center_area_ids:
-            domain = list(domain) + [
-                ("registrant_id.area_id", "child_of", center_area_ids.ids),
-            ]
-        return domain
-
-    @api.model
-    def search_read(self, domain=None, fields=None, offset=0, limit=None, order=None):
-        domain = self._prepare_domain(domain)
-        return super().search_read(domain, fields, offset, limit, order)
-
-    @api.model
-    def web_search_read(self, domain, specification, offset=0, limit=None, order=None, count_limit=None):
-        domain = self._prepare_domain(domain)
-        return super().web_search_read(domain, specification, offset, limit, order, count_limit)

spp_programs/models/program_membership.py

@@ -496,38 +496,3 @@ def _bulk_insert_on_conflict(self, vals_list, chunk_size=1000):
             len(vals_list) - total_inserted,
         )
         return total_inserted
-
-    # ─── Area-based filtering (OP#989) ──────────────────────────────────
-    # Mirrors the `_prepare_domain` pattern from
-    # spp_area/models/registrant.py so a user with a local role (i.e.
-    # `center_area_ids` set on res.users by spp_area) only sees program
-    # memberships whose partner is in one of their assigned areas (or
-    # any descendant of those areas). Users without center areas
-    # (global roles) get no extra filter — they see everything as
-    # before. Without this override "Verify Eligibility" / "Enroll
-    # Eligible" / the membership list bypassed area boundaries entirely.
-
-    @api.model
-    def _prepare_domain(self, domain):
-        domain = domain or []
-        user = self.env.user
-        # Guard against installs where spp_area isn't loaded — the
-        # field would not exist on res.users in that case. spp_programs
-        # already depends on spp_area today, but the guard keeps this
-        # override behaving sensibly if that ever changes.
-        center_area_ids = getattr(user, "center_area_ids", None)
-        if center_area_ids:
-            domain = list(domain) + [
-                ("partner_id.area_id", "child_of", center_area_ids.ids),
-            ]
-        return domain
-
-    @api.model
-    def search_read(self, domain=None, fields=None, offset=0, limit=None, order=None):
-        domain = self._prepare_domain(domain)
-        return super().search_read(domain, fields, offset, limit, order)
-
-    @api.model
-    def web_search_read(self, domain, specification, offset=0, limit=None, order=None, count_limit=None):
-        domain = self._prepare_domain(domain)
-        return super().web_search_read(domain, specification, offset, limit, order, count_limit)