fix(change_request): create phone records for new group members on apply (#876)

A new individual's captured phone numbers were only folded into the
partner's single header phone field, not created as spp.phone.number
records — so they didn't appear in the registry's Phone Numbers list.
Attach the phone records on apply, the same way the group's phones are
attached.

Author: emjay0921

spp_change_request_v2/strategies/create_group.py

@@ -32,7 +32,7 @@ def apply(self, change_request):
         group = self._create_group(detail)
 
         # 2. Multi-value attachments tied to the group partner.
-        self._attach_phones(detail, group)
+        self._attach_phones(detail.phone_line_ids, group)
         self._attach_banks(detail, group)
         self._attach_id_docs(detail, group)
 
@@ -144,12 +144,14 @@ def _create_group(self, detail):
     # ──────────────────────────────────────────────────────────────────────
     # Sub-record attachers
     # ──────────────────────────────────────────────────────────────────────
-    def _attach_phones(self, detail, group):
+    def _attach_phones(self, phone_lines, partner):
+        """Create spp.phone.number records (the registry's Phone Numbers list)
+        on ``partner`` from the given phone rows."""
         SppPhone = self.env["spp.phone.number"]
-        for line in detail.phone_line_ids:
+        for line in phone_lines:
             SppPhone.create(
                 {
-                    "partner_id": group.id,
+                    "partner_id": partner.id,
                     "phone_no": line.phone_no,
                     "country_id": line.country_id.id if line.country_id else False,
                     "date_collected": fields.Date.today(),
@@ -197,6 +199,9 @@ def _attach_members(self, detail, group):
             # Some downstream modules format the partner's name on the fly.
             if hasattr(individual, "name_change"):
                 individual.name_change()
+            # Create the individual's phone records (the registry's Phone
+            # Numbers list), the same way the group's phones are attached.
+            self._attach_phones(line.phone_line_ids, individual)
             self._create_membership(Membership, group, individual, line.membership_type_id, now)
 
     def _new_member_vals(self, line):

spp_change_request_v2/tests/test_create_group_strategy.py

@@ -553,8 +553,12 @@ def test_new_member_full_profile_written(self):
         self.assertEqual(individual.email, "maria@example.com")
         self.assertEqual(individual.income, 12345.0)
         # Multiple captured phone numbers are folded (in entry order) into the
-        # partner's single header phone field.
+        # partner's single header phone field...
         self.assertEqual(individual.phone, "+63911, +63922")
+        # ...and also created as proper phone records (the registry's Phone
+        # Numbers list), one per captured number.
+        phone_recs = self.env["spp.phone.number"].search([("partner_id", "=", individual.id)])
+        self.assertEqual(sorted(phone_recs.mapped("phone_no")), ["+63911", "+63922"])
         if occupation:
             self.assertEqual(individual.occupation_id, occupation)
         if civil: