fix(spp_cel_domain): normalize Odoo False to None for null comparisons

Odoo ORM returns False for unset non-boolean fields (Datetime, Date,
Char, Many2one, etc.), but CEL null maps to Python None. This caused
expressions like `m.disabled != null` to evaluate as `False != None`
which is True, matching every record even when the field is actually
NULL in the database.

_safe_getattr now detects Odoo records (via _fields attribute) and
converts False to None for non-boolean fields, so CEL null comparisons
behave correctly. Boolean fields retain their False value.

Author: jeremi

spp_cel_domain/services/cel_parser.py

@@ -77,7 +77,14 @@ def _safe_getattr(obj: Any, name: str, default: Any = None) -> Any:
         raise AttributeError(f"Access to attribute '{name}' is not allowed")
 
     if hasattr(obj, name):
-        return getattr(obj, name)
+        value = getattr(obj, name)
+        # Odoo ORM returns False for unset non-boolean fields (Datetime,
+        # Date, Char, Many2one, etc.). Normalize to None so that CEL null
+        # comparisons work correctly (e.g., `m.disabled != null`).
+        if value is False and hasattr(obj, "_fields") and name in obj._fields:
+            if obj._fields[name].type != "boolean":
+                return None
+        return value
     if isinstance(obj, dict):
         return obj.get(name, default)
     return default

spp_cel_domain/tests/test_cel_parser.py

@@ -409,3 +409,59 @@ def test_position_tracking_in_tokens(self):
         for tok in tokens:
             self.assertIsInstance(tok.pos, int)
             self.assertGreaterEqual(tok.pos, 0)
+
+    def test_odoo_null_field_equals_null(self):
+        """Odoo returns False for unset non-boolean fields; CEL null comparison should treat as None.
+
+        When an Odoo Datetime/Date/Char/etc. field is NULL in the DB, the ORM
+        returns False. CEL 'null' maps to Python None. Without normalization,
+        `m.disabled != null` becomes `False != None` which is True for every
+        record, even though the field IS null.
+        """
+        # Create a registrant with an unset disabled (Datetime) field
+        partner = self.env["res.partner"].create(
+            {"name": "CEL Null Test Person", "is_registrant": True, "is_group": False}
+        )
+
+        # Odoo ORM returns False for unset Datetime fields
+        self.assertIs(partner.disabled, False)
+
+        # CEL: m.disabled == null should be True (field is unset)
+        ast = P.parse("m.disabled == null")
+        result = P.evaluate(ast, {"m": partner})
+        self.assertTrue(
+            result,
+            "m.disabled == null should be True when disabled is unset "
+            f"(ORM returns {partner.disabled!r})",
+        )
+
+        # CEL: m.disabled != null should be False (field is unset)
+        ast = P.parse("m.disabled != null")
+        result = P.evaluate(ast, {"m": partner})
+        self.assertFalse(
+            result,
+            "m.disabled != null should be False when disabled is unset "
+            f"(ORM returns {partner.disabled!r})",
+        )
+
+    def test_odoo_boolean_false_not_treated_as_null(self):
+        """Boolean fields that are legitimately False should NOT be normalized to None."""
+        partner = self.env["res.partner"].create(
+            {"name": "CEL Bool Test", "is_registrant": False}
+        )
+
+        # is_registrant is a Boolean field, False is a real value
+        ast = P.parse("m.is_registrant == false")
+        result = P.evaluate(ast, {"m": partner})
+        self.assertTrue(
+            result,
+            "Boolean False should remain False, not become None",
+        )
+
+        # Boolean False should NOT equal null
+        ast = P.parse("m.is_registrant == null")
+        result = P.evaluate(ast, {"m": partner})
+        self.assertFalse(
+            result,
+            "Boolean False should not equal null",
+        )