fix(change_request): show real data (not counts) on Add Member review (#871)

The Add Member CR review page showed only counts for phones/bank/ID docs
and omitted the added individual's details. Surface the full data via the
generic _tables contract (shared with Create Group):

- All individual fields are shown even when empty (name, role, date of
  birth, gender, civil status, occupation, birth place, income, area,
  address, email, location).
- Phone Numbers / Bank Accounts / ID Documents render as their own tables.
- Drop the phone/bank/id_doc count keys.

The head-of-household replacement feature was reverted separately and
deferred to #1006.

Author: emjay0921

spp_change_request_v2/strategies/add_member.py

@@ -64,16 +64,65 @@ def preview(self, change_request):
         detail = change_request.get_detail()
         if not detail:
             return {}
+
+        location = None
+        if detail.latitude or detail.longitude:
+            location = f"{detail.latitude}, {detail.longitude}"
+
+        # One2many lines render as their own tables on the review page, via the
+        # generic "_tables" contract shared with Create Group (OP#871).
+        tables = []
+        phone_rows = [
+            [p.phone_no or "", p.country_id.display_name or "", _("Yes") if p.is_primary else ""]
+            for p in detail.phone_line_ids
+        ]
+        if phone_rows:
+            tables.append(
+                {"title": _("Phone Numbers"), "columns": [_("Number"), _("Country"), _("Primary")], "rows": phone_rows}
+            )
+        bank_rows = [
+            [b.acc_number or "", b.acc_holder_name or "", b.bank_id.display_name or ""] for b in detail.bank_line_ids
+        ]
+        if bank_rows:
+            tables.append(
+                {
+                    "title": _("Bank Accounts"),
+                    "columns": [_("Account Number"), _("Account Holder"), _("Bank")],
+                    "rows": bank_rows,
+                }
+            )
+        id_doc_rows = [
+            [d.id_type_id.display_name or "", d.value or "", str(d.expiry_date) if d.expiry_date else ""]
+            for d in detail.id_doc_line_ids
+        ]
+        if id_doc_rows:
+            tables.append(
+                {
+                    "title": _("ID Documents"),
+                    "columns": [_("Type"), _("Number"), _("Expiry Date")],
+                    "rows": id_doc_rows,
+                }
+            )
+
+        # Show every individual field even when empty (QA #871) — empty values
+        # render as a "-" placeholder through the action-summary formatter.
         return {
             "_action": "create_member",
             "_header": _("The following individual is to be added:"),
-            "member_name": detail.member_name,
-            "group": change_request.registrant_id.name,
-            "role": detail.membership_type_id.display if detail.membership_type_id else None,
-            "address": detail.address,
-            "phone_count": len(detail.phone_line_ids),
-            "bank_count": len(detail.bank_line_ids),
-            "id_doc_count": len(detail.id_doc_line_ids),
+            _("Group"): change_request.registrant_id.name,
+            _("Name"): detail.member_name,
+            _("Role"): detail.membership_type_id.display if detail.membership_type_id else None,
+            _("Date of Birth"): str(detail.birthdate) if detail.birthdate else None,
+            _("Gender"): detail.gender_id.display_name if detail.gender_id else None,
+            _("Civil Status"): detail.civil_status_id.display_name if detail.civil_status_id else None,
+            _("Occupation"): detail.occupation_id.display_name if detail.occupation_id else None,
+            _("Birth Place"): detail.birth_place or None,
+            _("Income"): detail.income or None,
+            _("Area"): detail.area_id.display_name if detail.area_id else None,
+            _("Address"): detail.address or None,
+            _("Email"): detail.email or None,
+            _("Location"): location,
+            "_tables": tables,
         }
 
     # ──────────────────────────────────────────────────────────────────────

spp_change_request_v2/tests/test_add_member_strategy.py

@@ -222,6 +222,47 @@ def test_preview_returns_create_member_action(self):
         # The review banner header is sourced from the preview (OP#871 QA round 1).
         self.assertIn("individual", (preview.get("_header") or "").lower())
 
+    def test_preview_shows_fields_and_tables(self):
+        """OP#871: the review preview shows the added individual's fields (even
+        when empty) and renders phones/bank/ID docs as tables, not counts."""
+        id_type = self.env["spp.vocabulary.code"].search(
+            [("vocabulary_id.namespace_uri", "=", "urn:openspp:vocab:id-type")], limit=1
+        )
+        cr = self._make_cr(
+            given_name="Maria",
+            family_name="Santos",
+            birthdate="1995-03-12",
+            email="maria@example.com",
+            phone_line_ids=[(0, 0, {"phone_no": "+63900000001", "is_primary": True})],
+            bank_line_ids=[(0, 0, {"acc_number": "ACCT-22"})],
+            id_doc_line_ids=([(0, 0, {"id_type_id": id_type.id, "value": "DOC-3"})] if id_type else []),
+        )
+        preview = cr.action_preview_changes()
+
+        # Counts are replaced by actual data.
+        for removed in ("phone_count", "bank_count", "id_doc_count"):
+            self.assertNotIn(removed, preview)
+
+        # Individual fields present, including ones left empty (render as "-" later).
+        self.assertEqual(preview["Name"], "SANTOS, Maria")
+        self.assertEqual(preview["Date of Birth"], "1995-03-12")
+        self.assertEqual(preview["Email"], "maria@example.com")
+        self.assertIn("Occupation", preview)
+        self.assertIn("Civil Status", preview)
+
+        titles = [t["title"] for t in preview["_tables"]]
+        self.assertIn("Phone Numbers", titles)
+        self.assertIn("Bank Accounts", titles)
+        phones = next(t for t in preview["_tables"] if t["title"] == "Phone Numbers")
+        self.assertIn("+63900000001", phones["rows"][0])
+
+        # Rendered review HTML shows the data + field labels, no leaked count keys.
+        html = cr._generate_review_comparison_html()
+        self.assertIn("Maria", html)
+        self.assertIn("+63900000001", html)
+        self.assertIn("Occupation", html)
+        self.assertNotIn("phone_count", html)
+
     def test_add_member_writes_single_address(self):
         """The single Address field maps to the registry's res.partner.address
         on apply, matching how the registry stores it (OP#871 QA round 1)."""