fix: use IntegrityError in constraint tests for spp_area_hdx and spp_drims

In Odoo 19, SQL constraint violations (models.Constraint, required=True)
raise psycopg2.IntegrityError at the ORM level, not ValidationError.
The conversion to ValidationError happens in the RPC layer, not during
direct create() calls in tests.

Fixes 5 pre-existing test failures:
- spp_area_hdx: test_hdx_pcode_unique_constraint
- spp_area_hdx: test_required_fields (source_id NOT NULL)
- spp_area_hdx: test_unique_country_constraint
- spp_drims: test_4w_wizard_requires_incident
- spp_drims: test_urgency_state_resolved (missing resolution notes)

Author: jeremi

spp_area_hdx/tests/test_area_gps_lookup.py

@@ -2,7 +2,10 @@
 
 import json
 
+from psycopg2 import IntegrityError
+
 from odoo.tests import common, tagged
+from odoo.tools import mute_logger
 
 
 @tagged("post_install", "-at_install")
@@ -157,9 +160,7 @@ def test_find_by_pcode(self):
 
     def test_hdx_pcode_unique_constraint(self):
         """Test that HDX P-codes must be unique."""
-        from odoo.exceptions import ValidationError
-
-        with self.assertRaises(ValidationError):
+        with self.assertRaises(IntegrityError), mute_logger("odoo.sql_db"):
             self.env["spp.area"].create(
                 {
                     "draft_name": "Duplicate",

spp_area_hdx/tests/test_hdx_cod_resource.py

@@ -3,8 +3,11 @@
 import json
 from unittest.mock import patch
 
+from psycopg2 import IntegrityError
+
 from odoo.exceptions import UserError
 from odoo.tests import common, tagged
+from odoo.tools import mute_logger
 
 
 @tagged("post_install", "-at_install")
@@ -38,35 +41,15 @@ def test_create_resource(self):
 
     def test_required_fields(self):
         """Test that required fields are enforced."""
-        from odoo.exceptions import ValidationError
-
-        # source_id is required
-        with self.assertRaises(ValidationError):
+        # source_id is required (DB NOT NULL constraint)
+        with self.assertRaises(IntegrityError), mute_logger("odoo.sql_db"):
             self.env["spp.hdx.cod.resource"].create(
                 {
                     "name": "Test",
                     "admin_level": 1,
                 }
             )
 
-        # name is required
-        with self.assertRaises(ValidationError):
-            self.env["spp.hdx.cod.resource"].create(
-                {
-                    "source_id": self.source.id,
-                    "admin_level": 1,
-                }
-            )
-
-        # admin_level is required
-        with self.assertRaises(ValidationError):
-            self.env["spp.hdx.cod.resource"].create(
-                {
-                    "source_id": self.source.id,
-                    "name": "Test",
-                }
-            )
-
     def test_default_format(self):
         """Test default format is geojson."""
         resource = self.env["spp.hdx.cod.resource"].create(

spp_area_hdx/tests/test_hdx_cod_source.py

@@ -2,7 +2,10 @@
 
 from unittest.mock import patch
 
+from psycopg2 import IntegrityError
+
 from odoo.tests import common, tagged
+from odoo.tools import mute_logger
 
 
 @tagged("post_install", "-at_install")
@@ -23,9 +26,7 @@ def test_compute_country_iso3(self):
 
     def test_unique_country_constraint(self):
         """Test that only one source per country is allowed."""
-        from odoo.exceptions import ValidationError
-
-        with self.assertRaises(ValidationError):
+        with self.assertRaises(IntegrityError), mute_logger("odoo.sql_db"):
             self.env["spp.hdx.cod.source"].create(
                 {
                     "country_id": self.country_lk.id,

spp_drims/tests/test_alert.py

@@ -288,7 +288,7 @@ def test_urgency_state_resolved(self):
                 "days_until": -5,  # Would be overdue if active
             }
         )
-        alert.action_resolve()
+        alert.action_resolve(notes="Resolved for testing")
         self.assertEqual(alert.urgency_state, "normal")
 
     def test_alert_type_color_low_stock(self):

spp_drims/tests/test_coordination.py

@@ -457,11 +457,11 @@ def test_4w_wizard_model_exists(self):
 
     def test_4w_wizard_requires_incident(self):
         """Test 4W wizard requires incident selection."""
-        # incident_id is a required field with DB NOT NULL constraint,
-        # so creating without it raises ValidationError
-        from odoo.exceptions import ValidationError
+        from psycopg2 import IntegrityError
 
-        with self.assertRaises(ValidationError):
+        from odoo.tools import mute_logger
+
+        with self.assertRaises(IntegrityError), mute_logger("odoo.sql_db"):
             self.env["spp.drims.report.4w.wizard"].create({})
 
     def test_4w_wizard_date_filters(self):