fix(spp_api_v2_change_request): fix 3 bugs and promote to Beta

- Fix path routing: replace /{reference} with /{p1}/{p2}/{p3} on all 8
  reference-based endpoints since CR references (CR/2026/00001) contain
  slashes that Starlette splits into separate path segments
- Fix mail.thread AccessError: add mail_create_nolog and tracking_disable
  context to service env, preventing flush_all() from triggering
  message_partner_ids writes as Public user (uid=3)
- Fix detail serialization: exclude mail.thread fields (message_ids,
  message_is_follower, has_message, etc.) from API responses
- Promote development_status from Alpha to Beta

Author: emjay0921

spp_api_v2_change_request/__manifest__.py

@@ -6,7 +6,7 @@
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/OpenSPP2",
     "license": "LGPL-3",
-    "development_status": "Alpha",
+    "development_status": "Beta",
     "maintainers": ["jeremi", "gonzalesedwin1123", "reichie020212"],
     "depends": [
         "spp_api_v2",

spp_api_v2_change_request/routers/change_request.py

@@ -40,6 +40,11 @@
 change_request_router = APIRouter(tags=["ChangeRequest"], prefix="/ChangeRequest")
 
 
+def _build_reference(p1: str, p2: str, p3: str) -> str:
+    """Reconstruct CR reference from path segments (e.g., CR/2026/00001)."""
+    return f"{p1}/{p2}/{p3}"
+
+
 @change_request_router.post(
     "",
     response_model=ChangeRequestResponse,
@@ -87,9 +92,11 @@ async def create_change_request(
     return service.to_api_schema(cr)
 
 
-@change_request_router.get("/{reference}", response_model=ChangeRequestResponse)
+@change_request_router.get("/{p1}/{p2}/{p3}", response_model=ChangeRequestResponse)
 async def read_change_request(
-    reference: Annotated[str, Path(description="CR reference (e.g., CR/2024/00001)")],
+    p1: Annotated[str, Path(description="Reference part 1 (e.g., CR)")],
+    p2: Annotated[str, Path(description="Reference part 2 (e.g., 2026)")],
+    p3: Annotated[str, Path(description="Reference part 3 (e.g., 00001)")],
     env: Annotated[Environment, Depends(odoo_env)],
     api_client: Annotated[dict, Depends(get_authenticated_client)],
     response: Response,
@@ -106,6 +113,7 @@ async def read_change_request(
             detail="Client does not have permission to read change requests",
         )
 
+    reference = _build_reference(p1, p2, p3)
     service = ChangeRequestService(env)
     cr = service.find_by_reference(reference)
 
@@ -224,9 +232,11 @@ async def search_change_requests(
     )
 
 
-@change_request_router.put("/{reference}", response_model=ChangeRequestResponse)
+@change_request_router.put("/{p1}/{p2}/{p3}", response_model=ChangeRequestResponse)
 async def update_change_request(
-    reference: Annotated[str, Path()],
+    p1: Annotated[str, Path(description="Reference part 1 (e.g., CR)")],
+    p2: Annotated[str, Path(description="Reference part 2 (e.g., 2026)")],
+    p3: Annotated[str, Path(description="Reference part 3 (e.g., 00001)")],
     update_data: ChangeRequestUpdate,
     env: Annotated[Environment, Depends(odoo_env)],
     api_client: Annotated[dict, Depends(get_authenticated_client)],
@@ -245,6 +255,7 @@ async def update_change_request(
             detail="Client does not have permission to update change requests",
         )
 
+    reference = _build_reference(p1, p2, p3)
     service = ChangeRequestService(env)
     cr = service.find_by_reference(reference)
 
@@ -284,9 +295,11 @@ async def update_change_request(
 # === Actions ===
 
 
-@change_request_router.post("/{reference}/$submit", response_model=ChangeRequestResponse)
+@change_request_router.post("/{p1}/{p2}/{p3}/$submit", response_model=ChangeRequestResponse)
 async def submit_change_request(
-    reference: Annotated[str, Path()],
+    p1: Annotated[str, Path(description="Reference part 1 (e.g., CR)")],
+    p2: Annotated[str, Path(description="Reference part 2 (e.g., 2026)")],
+    p3: Annotated[str, Path(description="Reference part 3 (e.g., 00001)")],
     env: Annotated[Environment, Depends(odoo_env)],
     api_client: Annotated[dict, Depends(get_authenticated_client)],
 ):
@@ -301,6 +314,7 @@ async def submit_change_request(
             detail="Client does not have permission to submit change requests",
         )
 
+    reference = _build_reference(p1, p2, p3)
     service = ChangeRequestService(env)
     cr = service.find_by_reference(reference)
 
@@ -321,9 +335,11 @@ async def submit_change_request(
     return service.to_api_schema(cr)
 
 
-@change_request_router.post("/{reference}/$approve", response_model=ChangeRequestResponse)
+@change_request_router.post("/{p1}/{p2}/{p3}/$approve", response_model=ChangeRequestResponse)
 async def approve_change_request(
-    reference: Annotated[str, Path()],
+    p1: Annotated[str, Path(description="Reference part 1 (e.g., CR)")],
+    p2: Annotated[str, Path(description="Reference part 2 (e.g., 2026)")],
+    p3: Annotated[str, Path(description="Reference part 3 (e.g., 00001)")],
     env: Annotated[Environment, Depends(odoo_env)],
     api_client: Annotated[dict, Depends(get_authenticated_client)],
     action_data: ApproveActionData | None = None,
@@ -339,6 +355,7 @@ async def approve_change_request(
             detail="Client does not have permission to approve change requests",
         )
 
+    reference = _build_reference(p1, p2, p3)
     service = ChangeRequestService(env)
     cr = service.find_by_reference(reference)
 
@@ -360,9 +377,11 @@ async def approve_change_request(
     return service.to_api_schema(cr)
 
 
-@change_request_router.post("/{reference}/$reject", response_model=ChangeRequestResponse)
+@change_request_router.post("/{p1}/{p2}/{p3}/$reject", response_model=ChangeRequestResponse)
 async def reject_change_request(
-    reference: Annotated[str, Path()],
+    p1: Annotated[str, Path(description="Reference part 1 (e.g., CR)")],
+    p2: Annotated[str, Path(description="Reference part 2 (e.g., 2026)")],
+    p3: Annotated[str, Path(description="Reference part 3 (e.g., 00001)")],
     action_data: RejectActionData,
     env: Annotated[Environment, Depends(odoo_env)],
     api_client: Annotated[dict, Depends(get_authenticated_client)],
@@ -378,6 +397,7 @@ async def reject_change_request(
             detail="Client does not have permission to reject change requests",
         )
 
+    reference = _build_reference(p1, p2, p3)
     service = ChangeRequestService(env)
     cr = service.find_by_reference(reference)
 
@@ -398,9 +418,11 @@ async def reject_change_request(
     return service.to_api_schema(cr)
 
 
-@change_request_router.post("/{reference}/$request-revision", response_model=ChangeRequestResponse)
+@change_request_router.post("/{p1}/{p2}/{p3}/$request-revision", response_model=ChangeRequestResponse)
 async def request_revision_change_request(
-    reference: Annotated[str, Path()],
+    p1: Annotated[str, Path(description="Reference part 1 (e.g., CR)")],
+    p2: Annotated[str, Path(description="Reference part 2 (e.g., 2026)")],
+    p3: Annotated[str, Path(description="Reference part 3 (e.g., 00001)")],
     action_data: RequestRevisionActionData,
     env: Annotated[Environment, Depends(odoo_env)],
     api_client: Annotated[dict, Depends(get_authenticated_client)],
@@ -416,6 +438,7 @@ async def request_revision_change_request(
             detail="Client does not have permission to request revision",
         )
 
+    reference = _build_reference(p1, p2, p3)
     service = ChangeRequestService(env)
     cr = service.find_by_reference(reference)
 
@@ -436,9 +459,11 @@ async def request_revision_change_request(
     return service.to_api_schema(cr)
 
 
-@change_request_router.post("/{reference}/$apply", response_model=ChangeRequestResponse)
+@change_request_router.post("/{p1}/{p2}/{p3}/$apply", response_model=ChangeRequestResponse)
 async def apply_change_request(
-    reference: Annotated[str, Path()],
+    p1: Annotated[str, Path(description="Reference part 1 (e.g., CR)")],
+    p2: Annotated[str, Path(description="Reference part 2 (e.g., 2026)")],
+    p3: Annotated[str, Path(description="Reference part 3 (e.g., 00001)")],
     env: Annotated[Environment, Depends(odoo_env)],
     api_client: Annotated[dict, Depends(get_authenticated_client)],
 ):
@@ -453,6 +478,7 @@ async def apply_change_request(
             detail="Client does not have permission to apply change requests",
         )
 
+    reference = _build_reference(p1, p2, p3)
     service = ChangeRequestService(env)
     cr = service.find_by_reference(reference)
 
@@ -473,9 +499,11 @@ async def apply_change_request(
     return service.to_api_schema(cr)
 
 
-@change_request_router.post("/{reference}/$reset", response_model=ChangeRequestResponse)
+@change_request_router.post("/{p1}/{p2}/{p3}/$reset", response_model=ChangeRequestResponse)
 async def reset_change_request(
-    reference: Annotated[str, Path()],
+    p1: Annotated[str, Path(description="Reference part 1 (e.g., CR)")],
+    p2: Annotated[str, Path(description="Reference part 2 (e.g., 2026)")],
+    p3: Annotated[str, Path(description="Reference part 3 (e.g., 00001)")],
     env: Annotated[Environment, Depends(odoo_env)],
     api_client: Annotated[dict, Depends(get_authenticated_client)],
 ):
@@ -490,6 +518,7 @@ async def reset_change_request(
             detail="Client does not have permission to reset change requests",
         )
 
+    reference = _build_reference(p1, p2, p3)
     service = ChangeRequestService(env)
     cr = service.find_by_reference(reference)
 

spp_api_v2_change_request/services/change_request_service.py

@@ -18,7 +18,8 @@ class ChangeRequestService:
     """Service for Change Request resource CRUD and mapping."""
 
     def __init__(self, env: Environment):
-        self.env = env
+        ctx = dict(env.context, mail_create_nolog=True, tracking_disable=True)
+        self.env = env(context=ctx)
 
     def find_by_reference(self, reference: str):
         """
@@ -161,7 +162,7 @@ def _serialize_detail(self, detail) -> dict[str, Any]:
         # Get fields from the model
         model_fields = detail._fields
 
-        # Skip internal and computed fields
+        # Skip internal, computed, and mail.thread fields
         skip_fields = {
             "id",
             "create_uid",
@@ -175,6 +176,20 @@ def _serialize_detail(self, detail) -> dict[str, Any]:
             "registrant_id",
             "approval_state",
             "is_applied",
+            # mail.thread fields
+            "message_ids",
+            "message_follower_ids",
+            "message_partner_ids",
+            "message_is_follower",
+            "has_message",
+            "message_needaction",
+            "message_needaction_counter",
+            "message_has_error",
+            "message_has_error_counter",
+            "message_attachment_count",
+            "message_has_sms_error",
+            "message_main_attachment_id",
+            "website_message_ids",
         }
 
         for field_name, field in model_fields.items():