fix(spp_statistic): fix unreachable privacy service delegation

Empty recordsets in Odoo are falsy, so checking `if privacy_service:`
would always evaluate to False even when the model is installed.
Changed to `if privacy_service is not None:` to correctly detect
when the spp.metrics.privacy model is available.

Author: jeremi

spp_metrics_core/README.md

@@ -4,9 +4,10 @@ Shared foundation for all metrics (statistics, simulation metrics, etc.) in Open
 
 ## Overview
 
-`spp_metrics_core` provides the base model and categorization system that eliminates duplication of genuinely shared
-fields across different metric types. All domain modules (statistics, simulations, dashboards) inherit from the base
-model and add their own computation-specific fields.
+`spp_metrics_core` provides the base model and categorization system that eliminates
+duplication of genuinely shared fields across different metric types. All domain modules
+(statistics, simulations, dashboards) inherit from the base model and add their own
+computation-specific fields.
 
 ## Architecture
 
@@ -24,8 +25,8 @@ spp.metric.base (AbstractModel)
 
 Abstract model providing genuinely shared fields for all metric types.
 
-Concrete models define their own computation-specific fields (metric_type, format, expressions, etc.) since these vary
-incompatibly between metric types.
+Concrete models define their own computation-specific fields (metric_type, format,
+expressions, etc.) since these vary incompatibly between metric types.
 
 **Identity**
 
@@ -72,8 +73,8 @@ Shared categorization for all metric types:
 
 ## Defining Metrics
 
-Since `spp.metric.base` is an **AbstractModel**, it does not store data directly. Domain modules define concrete metrics
-by inheriting from the base:
+Since `spp.metric.base` is an **AbstractModel**, it does not store data directly. Domain
+modules define concrete metrics by inheriting from the base:
 
 - `spp_statistic` - Defines published statistics
 - `spp_simulation` - Defines simulation metrics
@@ -113,9 +114,9 @@ Reference categories in your metrics:
 
 ```xml
 <record id="my_custom_metric" model="custom.metric">
-    <field name="name">my_metric</field>
-    <field name="label">My Custom Metric</field>
-    <field name="category_id" ref="spp_metrics_core.category_population"/>
+  <field name="name">my_metric</field>
+  <field name="label">My Custom Metric</field>
+  <field name="category_id" ref="spp_metrics_core.category_population" />
 </record>
 ```
 
@@ -125,19 +126,19 @@ Add domain-specific categories:
 
 ```xml
 <record id="category_health" model="spp.metric.category">
-    <field name="name">Health</field>
-    <field name="code">health</field>
-    <field name="description">Health-related metrics</field>
-    <field name="sequence">50</field>
+  <field name="name">Health</field>
+  <field name="code">health</field>
+  <field name="description">Health-related metrics</field>
+  <field name="sequence">50</field>
 </record>
 ```
 
 ## Migration
 
 ### From spp_statistic.category
 
-The migration automatically renames `spp.statistic.category` to `spp.metric.category` while preserving all data and
-external references.
+The migration automatically renames `spp.statistic.category` to `spp.metric.category`
+while preserving all data and external references.
 
 **Before**:
 
@@ -156,7 +157,8 @@ See [Migration Guide](../../docs/migration/statistics-refactoring.md) for detail
 ## Benefits
 
 1. **No Duplication**: Genuinely shared fields defined once, reused everywhere
-2. **Model-Specific Freedom**: Each concrete model defines its own computation fields without conflicts
+2. **Model-Specific Freedom**: Each concrete model defines its own computation fields
+   without conflicts
 3. **Consistent UI**: Common fields (name, label, category) display the same way
 4. **Shared Categories**: One categorization system for all metrics
 5. **Future-Proof**: New metric types easily add their own computation approaches
@@ -174,7 +176,8 @@ See [Migration Guide](../../docs/migration/statistics-refactoring.md) for detail
 
 ## Architecture Documentation
 
-See [Statistics System Architecture](../../docs/architecture/statistics-systems.md) for the complete system design.
+See [Statistics System Architecture](../../docs/architecture/statistics-systems.md) for
+the complete system design.
 
 ## License
 

spp_metrics_core/__manifest__.py

@@ -23,39 +23,4 @@
     "application": False,
     "installable": True,
     "auto_install": False,
-    "description": """
-OpenSPP Metrics Core
-====================
-
-Unified foundation for all metrics (statistics, simulation metrics, etc.)
-
-Architecture
-------------
-Provides a base abstract model that eliminates field duplication across
-different metric types (statistics, simulation metrics, etc.).
-
-::
-
-    spp.metric.base (AbstractModel)
-        │
-        ├── spp.statistic (extends with publication flags)
-        └── spp.simulation.metric (extends with scenario-specific fields)
-
-Models
-------
-- ``spp.metric.base``: Abstract model with shared metric fields
-- ``spp.metric.category``: Shared categorization for all metric types
-
-Fields Provided
----------------
-- **Identity**: name, label, description
-- **Presentation**: unit, decimal_places
-- **Categorization**: category_id
-- **Metadata**: sequence, active
-
-Migration
----------
-Automatically migrates ``spp.statistic.category`` to ``spp.metric.category``
-to maintain backward compatibility while providing a unified category model.
-    """,
 }

spp_metrics_core/data/metric_categories.xml

@@ -3,7 +3,6 @@
     Part of OpenSPP. See LICENSE file for full copyright and licensing details.
 -->
 <odoo>
-
     <!-- Default Metric Categories -->
 
     <record id="category_population" model="spp.metric.category">
@@ -33,5 +32,4 @@
         <field name="description">Distribution and entitlement metrics</field>
         <field name="sequence">40</field>
     </record>
-
 </odoo>

spp_metrics_core/migrations/19.0.1.0.0/pre-migrate.py

@@ -50,10 +50,7 @@ def migrate(cr, version):
         seq_exists = cr.fetchone()[0]
 
         if seq_exists:
-            _logger.info(
-                "Found spp_statistic_category_id_seq sequence, "
-                "renaming to spp_metric_category_id_seq"
-            )
+            _logger.info("Found spp_statistic_category_id_seq sequence, renaming to spp_metric_category_id_seq")
 
             # Rename sequence
             cr.execute(

spp_metrics_core/models/metric_category.py

@@ -59,9 +59,7 @@ class MetricCategory(models.Model):
         help="Parent category for hierarchical organization",
     )
 
-    _sql_constraints = [
-        ("code_unique", "UNIQUE(code)", "Category code must be unique!")
-    ]
+    _sql_constraints = [("code_unique", "UNIQUE(code)", "Category code must be unique!")]
 
     @api.constrains("parent_id")
     def _check_parent_recursion(self):

spp_metrics_core/tests/test_metric_category.py

@@ -1,6 +1,5 @@
 # Part of OpenSPP. See LICENSE file for full copyright and licensing details.
 
-from odoo.exceptions import ValidationError
 from odoo.tests import tagged
 from odoo.tests.common import TransactionCase
 

spp_statistic/__manifest__.py

@@ -25,52 +25,4 @@
     "application": False,
     "installable": True,
     "auto_install": False,
-    "description": """
-OpenSPP Statistics
-==================
-
-Provides a configuration layer for publishable statistics that can be
-consumed by multiple contexts (GIS, dashboards, APIs, reports).
-
-Architecture
-------------
-Statistics separate "what to compute" (CEL variables) from "where to publish"
-(contexts) and "how to present" (labels, formats, grouping).
-
-::
-
-    spp.cel.variable (defines computation)
-        │
-        └── Referenced by ──► spp.statistic (defines publication)
-                                  ├── is_published_gis
-                                  ├── is_published_dashboard
-                                  ├── is_published_api
-                                  │
-                                  └── spp.statistic.context
-                                        ├── context (gis/dashboard/api)
-                                        ├── label, format, group
-                                        └── context-specific config
-
-Models
-------
-- ``spp.statistic``: Publishable statistic referencing a CEL variable
-- ``spp.metric.category``: Organization categories for statistics
-- ``spp.statistic.context``: Context-specific presentation configuration
-
-Usage
------
-Define statistics via XML or UI::
-
-    <record id="stat_children_under_5" model="spp.statistic">
-        <field name="name">children_under_5</field>
-        <field name="variable_id" ref="cel_var_children_under_5"/>
-        <field name="label">Children Under 5</field>
-        <field name="is_published_gis" eval="True"/>
-        <field name="is_published_dashboard" eval="True"/>
-    </record>
-
-Query statistics for a context::
-
-    stats = env["spp.statistic"].get_published_for_context("gis")
-    """,
 }

spp_statistic/data/statistic_categories.xml

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8" ?>
 <!--
     Default Statistic Categories
 
@@ -8,53 +8,63 @@
     Note: Uses spp.metric.category (migrated from spp.statistic.category)
 -->
 <odoo noupdate="1">
-
     <!-- Demographics - Population composition -->
     <record id="category_demographics" model="spp.metric.category">
         <field name="name">Demographics</field>
         <field name="code">demographics</field>
-        <field name="description">Population composition statistics: age groups, gender distribution, household size</field>
+        <field
+            name="description"
+        >Population composition statistics: age groups, gender distribution, household size</field>
         <field name="sequence">10</field>
     </record>
 
     <!-- Vulnerability - Risk indicators -->
     <record id="category_vulnerability" model="spp.metric.category">
         <field name="name">Vulnerability</field>
         <field name="code">vulnerability</field>
-        <field name="description">Vulnerability indicators: disability, female-headed households, at-risk populations</field>
+        <field
+            name="description"
+        >Vulnerability indicators: disability, female-headed households, at-risk populations</field>
         <field name="sequence">20</field>
     </record>
 
     <!-- Programs - Enrollment and coverage -->
     <record id="category_programs" model="spp.metric.category">
         <field name="name">Programs</field>
         <field name="code">programs</field>
-        <field name="description">Program statistics: enrollment counts, coverage rates, benefit distribution</field>
+        <field
+            name="description"
+        >Program statistics: enrollment counts, coverage rates, benefit distribution</field>
         <field name="sequence">30</field>
     </record>
 
     <!-- Geographic - Area-based metrics -->
     <record id="category_geographic" model="spp.metric.category">
         <field name="name">Geographic</field>
         <field name="code">geographic</field>
-        <field name="description">Geographic statistics: area coverage, density, distribution patterns</field>
+        <field
+            name="description"
+        >Geographic statistics: area coverage, density, distribution patterns</field>
         <field name="sequence">40</field>
     </record>
 
     <!-- Economic - Financial indicators -->
     <record id="category_economic" model="spp.metric.category">
         <field name="name">Economic</field>
         <field name="code">economic</field>
-        <field name="description">Economic statistics: income levels, poverty indicators, benefit amounts</field>
+        <field
+            name="description"
+        >Economic statistics: income levels, poverty indicators, benefit amounts</field>
         <field name="sequence">50</field>
     </record>
 
     <!-- Fairness - Equity metrics -->
     <record id="category_fairness" model="spp.metric.category">
         <field name="name">Fairness</field>
         <field name="code">fairness</field>
-        <field name="description">Equity and fairness metrics: disparity ratios, inclusion rates, coverage gaps</field>
+        <field
+            name="description"
+        >Equity and fairness metrics: disparity ratios, inclusion rates, coverage gaps</field>
         <field name="sequence">60</field>
     </record>
-
 </odoo>

spp_statistic/models/statistic.py

@@ -267,7 +267,7 @@ def apply_suppression(self, value, count=None, context=None):
 
         # Delegate to unified privacy service
         privacy_service = self.env.get("spp.metrics.privacy")
-        if privacy_service:
+        if privacy_service is not None:
             stat_config = {"minimum_count": min_count, "suppression_display": display_mode}
             return privacy_service.suppress_value(value, count, stat_config=stat_config)
 

spp_statistic/tests/test_statistic.py

@@ -192,9 +192,7 @@ def test_get_published_by_category(self):
         """Test grouping statistics by category."""
         Statistic = self.env["spp.statistic"]
 
-        cat2 = self.env["spp.metric.category"].create(
-            {"name": "Second", "code": "second"}
-        )
+        cat2 = self.env["spp.metric.category"].create({"name": "Second", "code": "second"})
 
         Statistic.create(
             {