fix(lint): resolve pylint_odoo warnings across case, GRM, and session modules

- Change development_status from "Stable" to "Production/Stable" (C8111)
- Remove redundant string= parameters matching auto-generated names (W8113)
- Use named translation placeholders instead of positional %s (W8120)

Author: gonzalesedwin1123

spp_case_base/__manifest__.py

@@ -7,7 +7,7 @@
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/OpenSPP2",
     "license": "LGPL-3",
-    "development_status": "Stable",
+    "development_status": "Production/Stable",
     "maintainers": ["jeremi", "gonzalesedwin1123", "emjay0921"],
     "depends": [
         "base",

spp_case_base/models/case.py

@@ -37,7 +37,6 @@ class Case(models.Model):
             ("2", "Level 2 - Medium Intensity"),
             ("3", "Level 3 - High Intensity"),
         ],
-        string="Intensity Level",
         default="2",
         required=True,
         tracking=True,
@@ -51,7 +50,6 @@ class Case(models.Model):
             ("high", "High"),
             ("urgent", "Urgent"),
         ],
-        string="Priority",
         default="medium",
         required=True,
         tracking=True,
@@ -64,7 +62,6 @@ class Case(models.Model):
             ("household", "Household"),
             ("group", "Group"),
         ],
-        string="Client Type",
         default="individual",
         required=True,
     )
@@ -108,19 +105,16 @@ class Case(models.Model):
 
     # Dates
     opened_date = fields.Date(
-        string="Opened Date",
         default=fields.Date.context_today,
         required=True,
         tracking=True,
     )
 
     target_closure_date = fields.Date(
-        string="Target Closure Date",
         tracking=True,
     )
 
     actual_closure_date = fields.Date(
-        string="Actual Closure Date",
         readonly=True,
         tracking=True,
     )
@@ -135,17 +129,14 @@ class Case(models.Model):
             ("program", "Program Enrollment"),
             ("other", "Other"),
         ],
-        string="Intake Source",
         tracking=True,
     )
 
     referral_source = fields.Char(
-        string="Referral Source",
         help="Name or organization that referred the client",
     )
 
     presenting_issue = fields.Html(
-        string="Presenting Issue",
         help="Main issue or need that led to case opening",
     )
 
@@ -199,23 +190,18 @@ class Case(models.Model):
 
     # Count fields for stat buttons
     assessment_count = fields.Integer(
-        string="Assessment Count",
         compute="_compute_related_counts",
     )
     intervention_plan_count = fields.Integer(
-        string="Intervention Plan Count",
         compute="_compute_related_counts",
     )
     visit_count = fields.Integer(
-        string="Visit Count",
         compute="_compute_related_counts",
     )
     note_count = fields.Integer(
-        string="Note Count",
         compute="_compute_related_counts",
     )
     referral_count = fields.Integer(
-        string="Referral Count",
         compute="_compute_related_counts",
     )
 
@@ -236,22 +222,16 @@ class Case(models.Model):
             ("lost_contact", "Lost Contact"),
             ("other", "Other"),
         ],
-        string="Closure Outcome",
     )
 
-    closure_summary = fields.Html(
-        string="Closure Summary",
-    )
+    closure_summary = fields.Html()
 
     # Review Dates
     next_review_date = fields.Date(
-        string="Next Review Date",
         tracking=True,
     )
 
-    last_review_date = fields.Date(
-        string="Last Review Date",
-    )
+    last_review_date = fields.Date()
 
     # Company
     company_id = fields.Many2one(
@@ -262,7 +242,6 @@ class Case(models.Model):
 
     # UI Fields
     active = fields.Boolean(
-        string="Active",
         default=True,
         help="If unchecked, this record will be hidden from active views.",
     )
@@ -274,19 +253,16 @@ class Case(models.Model):
 
     # Computed Fields
     days_open = fields.Integer(
-        string="Days Open",
         compute="_compute_days_open",
         store=False,
     )
 
     is_active = fields.Boolean(
-        string="Is Active",
         compute="_compute_is_active",
         store=True,
     )
 
     has_active_plan = fields.Boolean(
-        string="Has Active Plan",
         compute="_compute_has_active_plan",
         store=False,
     )
@@ -459,7 +435,11 @@ def _cron_check_reviews(self):
                 "mail.mail_activity_data_todo",
                 date_deadline=today,
                 summary=_("Case review overdue"),
-                note=_("Case %s is due for review. Last review: %s") % (case.name, case.last_review_date or _("Never")),
+                note=_(
+                    "Case %(case_name)s is due for review. Last review: %(last_review)s",
+                    case_name=case.name,
+                    last_review=case.last_review_date or _("Never"),
+                ),
                 user_id=case.case_worker_id.id,
             )
 
@@ -489,7 +469,11 @@ def _cron_check_reviews(self):
                     "mail.mail_activity_data_todo",
                     date_deadline=case.next_review_date,
                     summary=_("Case review upcoming"),
-                    note=_("Case %s review is scheduled for %s") % (case.name, case.next_review_date),
+                    note=_(
+                        "Case %(case_name)s review is scheduled for %(review_date)s",
+                        case_name=case.name,
+                        review_date=case.next_review_date,
+                    ),
                     user_id=case.case_worker_id.id,
                 )
 

spp_case_base/models/case_assessment.py

@@ -29,7 +29,6 @@ class CaseAssessment(models.Model):
     )
 
     assessment_date = fields.Date(
-        string="Assessment Date",
         required=True,
         default=fields.Date.context_today,
         tracking=True,
@@ -51,26 +50,22 @@ class CaseAssessment(models.Model):
             ("closure", "Closure Assessment"),
             ("reassessment", "Reassessment"),
         ],
-        string="Assessment Type",
         required=True,
         default="periodic",
         tracking=True,
     )
 
     # Assessment Content
     findings = fields.Html(
-        string="Findings",
         help="Key findings from the assessment",
     )
 
     recommendations = fields.Html(
-        string="Recommendations",
         help="Recommended actions based on assessment",
     )
 
     # Risk Assessment
     risk_score = fields.Float(
-        string="Risk Score",
         help="Risk score from 0 to 100",
         tracking=True,
     )
@@ -82,7 +77,6 @@ class CaseAssessment(models.Model):
             ("high", "High"),
             ("critical", "Critical"),
         ],
-        string="Risk Level",
         compute="_compute_risk_level",
         store=True,
         tracking=True,
@@ -111,7 +105,6 @@ class CaseAssessment(models.Model):
             ("completed", "Completed"),
             ("reviewed", "Reviewed"),
         ],
-        string="State",
         default="draft",
         required=True,
         tracking=True,
@@ -126,7 +119,6 @@ class CaseAssessment(models.Model):
     )
 
     reviewed_date = fields.Datetime(
-        string="Reviewed Date",
         readonly=True,
         tracking=True,
     )
@@ -153,7 +145,6 @@ class CaseAssessment(models.Model):
 
     # UI Fields
     active = fields.Boolean(
-        string="Active",
         default=True,
     )
 

spp_case_base/models/case_intervention.py

@@ -32,18 +32,15 @@ class CaseIntervention(models.Model):
     )
 
     sequence = fields.Integer(
-        string="Sequence",
         default=10,
         help="Order of interventions in the plan",
     )
 
     description = fields.Text(
-        string="Description",
         help="Detailed description of the intervention",
     )
 
     target_outcome = fields.Char(
-        string="Target Outcome",
         help="Expected result or outcome of this intervention",
     )
 
@@ -68,12 +65,10 @@ class CaseIntervention(models.Model):
 
     # Dates
     target_date = fields.Date(
-        string="Target Date",
         help="Target completion date",
     )
 
     completed_date = fields.Date(
-        string="Completed Date",
         readonly=True,
     )
 
@@ -92,19 +87,16 @@ class CaseIntervention(models.Model):
     )
 
     completion_notes = fields.Text(
-        string="Completion Notes",
         help="Notes about the completion or outcome of the intervention",
     )
 
     # Computed fields
     is_overdue = fields.Boolean(
-        string="Is Overdue",
         compute="_compute_is_overdue",
         store=False,
     )
 
     days_until_due = fields.Integer(
-        string="Days Until Due",
         compute="_compute_days_until_due",
         store=False,
     )

spp_case_base/models/case_intervention_plan.py

@@ -27,7 +27,6 @@ class CaseInterventionPlan(models.Model):
     )
 
     version = fields.Integer(
-        string="Version",
         default=1,
         required=True,
         readonly=True,
@@ -49,36 +48,30 @@ class CaseInterventionPlan(models.Model):
 
     # Plan Content
     goals = fields.Html(
-        string="Goals",
         required=True,
         help="Case management goals to be achieved",
     )
 
     expected_outcomes = fields.Html(
-        string="Expected Outcomes",
         help="Expected outcomes and success criteria",
     )
 
     client_responsibilities = fields.Html(
-        string="Client Responsibilities",
         help="Client's roles and responsibilities in the plan",
     )
 
     # Dates
     start_date = fields.Date(
-        string="Start Date",
         default=fields.Date.context_today,
         required=True,
         tracking=True,
     )
 
     target_end_date = fields.Date(
-        string="Target End Date",
         tracking=True,
     )
 
     actual_end_date = fields.Date(
-        string="Actual End Date",
         readonly=True,
     )
 
@@ -107,7 +100,6 @@ class CaseInterventionPlan(models.Model):
     )
 
     approved_date = fields.Datetime(
-        string="Approved Date",
         readonly=True,
         tracking=True,
     )

spp_case_base/models/case_note.py

@@ -18,7 +18,6 @@ class CaseNote(models.Model):
     )
 
     note_date = fields.Datetime(
-        string="Note Date",
         required=True,
         default=fields.Datetime.now,
     )
@@ -37,13 +36,11 @@ class CaseNote(models.Model):
             ("progress", "Progress Update"),
             ("supervision", "Supervision Note"),
         ],
-        string="Note Type",
         required=True,
         default="general",
     )
 
     content = fields.Html(
-        string="Content",
         required=True,
     )