|
| 1 | +# Part of OpenSPP. See LICENSE file for full copyright and licensing details. |
| 2 | +import uuid |
| 3 | + |
| 4 | +from odoo import fields |
| 5 | +from odoo.tests import TransactionCase |
| 6 | + |
| 7 | + |
| 8 | +class TestCycleComputedFields(TransactionCase): |
| 9 | + """Test that SQL-optimized cycle computed fields return correct results. |
| 10 | +
|
| 11 | + These fields were migrated from Python iteration over recordsets to |
| 12 | + SQL aggregation for O(1) instead of O(N) per cycle. |
| 13 | + """ |
| 14 | + |
| 15 | + def setUp(self): |
| 16 | + super().setUp() |
| 17 | + self.program = self.env["spp.program"].create({"name": f"Test Program {uuid.uuid4().hex[:8]}"}) |
| 18 | + self.cycle = self.env["spp.cycle"].create( |
| 19 | + { |
| 20 | + "name": "Test Cycle", |
| 21 | + "program_id": self.program.id, |
| 22 | + "start_date": fields.Date.today(), |
| 23 | + "end_date": fields.Date.today(), |
| 24 | + } |
| 25 | + ) |
| 26 | + self.registrant1 = self.env["res.partner"].create({"name": "Registrant 1", "is_registrant": True}) |
| 27 | + self.registrant2 = self.env["res.partner"].create({"name": "Registrant 2", "is_registrant": True}) |
| 28 | + self.registrant3 = self.env["res.partner"].create({"name": "Registrant 3", "is_registrant": True}) |
| 29 | + |
| 30 | + def _create_entitlement(self, partner, amount, state="draft"): |
| 31 | + ent = self.env["spp.entitlement"].create( |
| 32 | + { |
| 33 | + "partner_id": partner.id, |
| 34 | + "cycle_id": self.cycle.id, |
| 35 | + "initial_amount": amount, |
| 36 | + } |
| 37 | + ) |
| 38 | + if state != "draft": |
| 39 | + ent.state = state |
| 40 | + ent.flush_recordset() |
| 41 | + return ent |
| 42 | + |
| 43 | + # -- total_amount -- |
| 44 | + |
| 45 | + def test_total_amount_empty(self): |
| 46 | + """Cycle with no entitlements has total_amount = 0.""" |
| 47 | + self.cycle.invalidate_recordset(["total_amount"]) |
| 48 | + self.assertEqual(self.cycle.total_amount, 0) |
| 49 | + |
| 50 | + def test_total_amount_sums_initial_amounts(self): |
| 51 | + """total_amount must equal sum of all entitlement initial_amounts.""" |
| 52 | + self._create_entitlement(self.registrant1, 100.0) |
| 53 | + self._create_entitlement(self.registrant2, 250.50) |
| 54 | + self._create_entitlement(self.registrant3, 49.50) |
| 55 | + self.cycle.invalidate_recordset(["total_amount"]) |
| 56 | + self.assertAlmostEqual(self.cycle.total_amount, 400.0) |
| 57 | + |
| 58 | + # -- total_entitlements_count -- |
| 59 | + |
| 60 | + def test_total_entitlements_count_empty(self): |
| 61 | + """Cycle with no entitlements has count = 0.""" |
| 62 | + self.cycle.invalidate_recordset(["total_entitlements_count"]) |
| 63 | + self.assertEqual(self.cycle.total_entitlements_count, 0) |
| 64 | + |
| 65 | + def test_total_entitlements_count_correct(self): |
| 66 | + """Count must include all cash entitlements.""" |
| 67 | + self._create_entitlement(self.registrant1, 100.0) |
| 68 | + self._create_entitlement(self.registrant2, 200.0) |
| 69 | + self.cycle.invalidate_recordset(["total_entitlements_count"]) |
| 70 | + self.assertEqual(self.cycle.total_entitlements_count, 2) |
| 71 | + |
| 72 | + # -- show_approve_entitlements_button -- |
| 73 | + |
| 74 | + def test_show_approve_no_entitlements(self): |
| 75 | + """Button hidden when no entitlements exist.""" |
| 76 | + self.cycle.invalidate_recordset(["show_approve_entitlements_button"]) |
| 77 | + self.assertFalse(self.cycle.show_approve_entitlements_button) |
| 78 | + |
| 79 | + def test_show_approve_with_pending(self): |
| 80 | + """Button shown when pending_validation entitlements exist.""" |
| 81 | + self._create_entitlement(self.registrant1, 100.0, state="pending_validation") |
| 82 | + self.cycle.invalidate_recordset(["show_approve_entitlements_button"]) |
| 83 | + self.assertTrue(self.cycle.show_approve_entitlements_button) |
| 84 | + |
| 85 | + def test_show_approve_only_draft(self): |
| 86 | + """Button hidden when all entitlements are draft.""" |
| 87 | + self._create_entitlement(self.registrant1, 100.0, state="draft") |
| 88 | + self.cycle.invalidate_recordset(["show_approve_entitlements_button"]) |
| 89 | + self.assertFalse(self.cycle.show_approve_entitlements_button) |
| 90 | + |
| 91 | + def test_show_approve_only_approved(self): |
| 92 | + """Button hidden when all entitlements are approved.""" |
| 93 | + self._create_entitlement(self.registrant1, 100.0, state="approved") |
| 94 | + self.cycle.invalidate_recordset(["show_approve_entitlements_button"]) |
| 95 | + self.assertFalse(self.cycle.show_approve_entitlements_button) |
| 96 | + |
| 97 | + # -- all_entitlements_approved -- |
| 98 | + |
| 99 | + def test_all_approved_empty(self): |
| 100 | + """No entitlements => not all approved (nothing to approve).""" |
| 101 | + self.cycle.invalidate_recordset(["all_entitlements_approved"]) |
| 102 | + self.assertFalse(self.cycle.all_entitlements_approved) |
| 103 | + |
| 104 | + def test_all_approved_when_all_approved(self): |
| 105 | + """True when every entitlement has state=approved.""" |
| 106 | + self._create_entitlement(self.registrant1, 100.0, state="approved") |
| 107 | + self._create_entitlement(self.registrant2, 200.0, state="approved") |
| 108 | + self.cycle.invalidate_recordset(["all_entitlements_approved"]) |
| 109 | + self.assertTrue(self.cycle.all_entitlements_approved) |
| 110 | + |
| 111 | + def test_all_approved_mixed_states(self): |
| 112 | + """False when some entitlements are not approved.""" |
| 113 | + self._create_entitlement(self.registrant1, 100.0, state="approved") |
| 114 | + self._create_entitlement(self.registrant2, 200.0, state="draft") |
| 115 | + self.cycle.invalidate_recordset(["all_entitlements_approved"]) |
| 116 | + self.assertFalse(self.cycle.all_entitlements_approved) |
| 117 | + |
| 118 | + # -- multi-cycle batching -- |
| 119 | + |
| 120 | + def test_computed_fields_multi_cycle(self): |
| 121 | + """SQL queries must handle multiple cycles in a single batch.""" |
| 122 | + cycle2 = self.env["spp.cycle"].create( |
| 123 | + { |
| 124 | + "name": "Test Cycle 2", |
| 125 | + "program_id": self.program.id, |
| 126 | + "start_date": fields.Date.today(), |
| 127 | + "end_date": fields.Date.today(), |
| 128 | + } |
| 129 | + ) |
| 130 | + self._create_entitlement(self.registrant1, 100.0) |
| 131 | + self.env["spp.entitlement"].create( |
| 132 | + { |
| 133 | + "partner_id": self.registrant2.id, |
| 134 | + "cycle_id": cycle2.id, |
| 135 | + "initial_amount": 300.0, |
| 136 | + } |
| 137 | + ) |
| 138 | + |
| 139 | + cycles = self.cycle | cycle2 |
| 140 | + cycles.invalidate_recordset(["total_amount", "total_entitlements_count"]) |
| 141 | + |
| 142 | + self.assertAlmostEqual(self.cycle.total_amount, 100.0) |
| 143 | + self.assertAlmostEqual(cycle2.total_amount, 300.0) |
| 144 | + self.assertEqual(self.cycle.total_entitlements_count, 1) |
| 145 | + self.assertEqual(cycle2.total_entitlements_count, 1) |
0 commit comments