Skip to content

chore(metrics,aggregation): promote to Beta with coverage tests#91

Merged
emjay0921 merged 5 commits into19.0from
fix/alpha-to-beta-aggregation-metrics
Mar 12, 2026
Merged

chore(metrics,aggregation): promote to Beta with coverage tests#91
emjay0921 merged 5 commits into19.0from
fix/alpha-to-beta-aggregation-metrics

Conversation

@emjay0921
Copy link
Copy Markdown
Contributor

Why is this change needed?

Promote spp_aggregation, spp_metrics_core, and spp_metrics_services from Alpha to Beta status after code review confirmed they are clean and production-ready.

How was the change implemented?

  • Updated development_status from "Alpha" to "Beta" in all three module manifests
  • Added readme/DESCRIPTION.md files for all three modules (resolves missing-readme pylint warnings)
  • Generated README.rst files via OCA readme generator
  • Added comprehensive test coverage files (test_coverage.py) for all three modules

New unit tests

  • spp_metrics_core (25 total tests): Abstract model registry, field definitions/types/defaults, recursion detection (2-level, self-reference, 3-level cycle), category lifecycle (deactivate, reactivate, description, ordering)
  • spp_metrics_services (115 total tests): Demographic dimension evaluation (field, expression, dot notation), label lookups, get_by_name/get_active_dimensions, cache invalidation on write/unlink, fairness analysis (boolean/many2one/selection/expression dimensions, disparity ratio), privacy service (k-anonymity, complementary suppression, access validation), distribution edge cases
  • spp_aggregation (172 total tests): Access rule constraint validation (user/group exclusivity, k-anonymity bounds), scope allowed/dimensions allowed checks, cache key generation for all scope types, TTL and cron cleanup, scope resolver edge cases, aggregation service convenience methods

Unit tests executed by the author

All three modules pass cleanly:

  • spp_metrics_core: 0 failed, 0 errors of 25 tests
  • spp_metrics_services: 0 failed, 0 errors of 115 tests
  • spp_aggregation: 0 failed, 0 errors of 172 tests

How to test manually

  1. Install the three modules on a fresh Odoo 19 instance
  2. Verify menus and views load without errors
  3. Run tests via Docker to confirm all pass

Related links

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.39%. Comparing base (ae00c8a) to head (90939c5).
⚠️ Report is 9 commits behind head on 19.0.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             19.0      #91      +/-   ##
==========================================
+ Coverage   69.91%   70.39%   +0.48%     
==========================================
  Files         674      674              
  Lines       37005    37005              
==========================================
+ Hits        25872    26051     +179     
+ Misses      11133    10954     -179     
Flag Coverage Δ
spp_aggregation 85.06% <ø> (+5.01%) ⬆️
spp_api_v2_gis 71.52% <ø> (ø)
spp_api_v2_simulation 69.61% <ø> (ø)
spp_base_common 90.26% <ø> (ø)
spp_dci_demo 69.23% <ø> (ø)
spp_metrics_core 97.29% <ø> (+2.70%) ⬆️
spp_metrics_services 88.31% <ø> (+21.49%) ⬆️
spp_mis_demo_v2 69.82% <ø> (ø)
spp_programs 45.51% <ø> (ø)
spp_security 66.66% <ø> (ø)
spp_simulation 70.08% <ø> (ø)
spp_statistic 77.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
spp_aggregation/__manifest__.py 0.00% <ø> (ø)
spp_metrics_core/__manifest__.py 0.00% <ø> (ø)
spp_metrics_services/__manifest__.py 0.00% <ø> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emjay0921 emjay0921 merged commit 839f83e into 19.0 Mar 12, 2026
27 checks passed
@emjay0921 emjay0921 deleted the fix/alpha-to-beta-aggregation-metrics branch March 12, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants