Skip to content

fix(spp_security,spp_hazard): rename Hazard & Emergency to avoid XML parse error #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emjay0921 merged 1 commit into from
Mar 12, 2026
Merged

fix(spp_security,spp_hazard): rename Hazard & Emergency to avoid XML parse error #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spp_hazard/security/compliance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ record_rules: []
menus:
# Main Hazard menu - accessible to all hazard groups
- id: hazard_main_menu_root
name: "Hazard & Emergency"
name: "Hazard and Emergency"
groups:
[
spp_security.group_spp_admin,
Expand Down
2 changes: 1 addition & 1 deletion spp_hazard/views/menu.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<!-- Main Hazard Menu (Top-level application) -->
<menuitem
id="hazard_main_menu_root"
name="Hazard &amp; Emergency"
name="Hazard and Emergency"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you're updating the name, it would be a good idea to also update the associated icon file name for consistency. The web_icon attribute on the next line refers to OpenSPP-Web-Menu_Hazard__Emergency_Icon.png. Consider renaming this file to reflect the new name (e.g., OpenSPP-Web-Menu_Hazard_and_Emergency_Icon.png) and updating the path in the web_icon attribute. This would improve the overall consistency of the codebase.

web_icon="spp_hazard,static/description/OpenSPP-Web-Menu_Hazard__Emergency_Icon.png"
sequence="45"
/>
Expand Down
4 changes: 2 additions & 2 deletions spp_security/security/categories.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,9 @@
<field name="sequence">77</field>
</record>

<!-- Hazard & Emergency Domain Category -->
<!-- Hazard and Emergency Domain Category -->
<record id="category_spp_hazard" model="ir.module.category">
<field name="name">Hazard &amp; Emergency</field>
<field name="name">Hazard and Emergency</field>
<field
name="description"
>Hazard classification, incident tracking, and impact assessment</field>
Expand Down
Loading