fix(spp_graduation): add web_icon to Graduation root menu

[emjay0921]

Why is this change needed?

The openspp-graduation-menu-icons.png file existed in spp_graduation/static/description/ but was not referenced by the Graduation root menu, so the menu had no icon.

How was the change implemented?

Added web_icon attribute to the menu_graduation_root menuitem pointing to the existing icon file.

New unit tests

Unit tests executed by the author

How to test manually

1. Install spp_graduation
2. Check the top-level Graduation menu displays the custom icon

Related links

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor user interface inconsistency by ensuring the Graduation root menu displays its intended icon. By adding a single attribute to the menu definition, the existing icon file is now correctly linked, enhancing the visual presentation and user experience within the application.

Highlights

• Graduation Root Menu Icon: Added the "web_icon" attribute to the "menu_graduation_root" menu item, referencing the existing "openspp-graduation-menu-icons.png" file. This resolves the issue where the Graduation root menu previously lacked a visual icon.

Changelog

• spp_graduation/views/graduation_menus.xml
  • Added the "web_icon" attribute to the "menu_graduation_root" menu item.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds a web_icon attribute to the menu_graduation_root menu item in spp_graduation/views/graduation_menus.xml. The change references an existing icon file to ensure the Graduation root menu displays its intended icon. The implementation is straightforward and follows standard Odoo practices. I have reviewed the change and found no issues.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.39%. Comparing base (31cf2d2) to head (cfc7d46).

Additional details and impacted files

@@           Coverage Diff           @@
##             19.0      #98   +/-   ##
=======================================
  Coverage   70.39%   70.39%           
=======================================
  Files         674      674           
  Lines       37005    37005           
=======================================
  Hits        26051    26051           
  Misses      10954    10954           

Flag	Coverage Δ
spp_base_common	90.26% <ø> (ø)
spp_case_graduation	97.77% <ø> (ø)
spp_graduation	93.45% <ø> (ø)
spp_programs	45.51% <ø> (ø)
spp_security	66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.