-
Notifications
You must be signed in to change notification settings - Fork 4
fix: errors and warnings in make livehtml
#109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pmigueld
wants to merge
3
commits into
v2-odoo19-doc-refresh
Choose a base branch
from
fix/odoo-docs-v2-log-warnings
base: v2-odoo19-doc-refresh
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -63,7 +63,8 @@ Global defaults apply to all incidents unless overridden. These control when ale | |||||||||
| 2. Scroll to **DRIMS** section | ||||||||||
| 3. Configure default thresholds | ||||||||||
|
|
||||||||||
|  | ||||||||||
| <!-- <!-- TODO: Add screenshot: DRIMS settings section --> | ||||||||||
| <!--  --> --> | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The nested HTML comment syntax
Suggested change
|
||||||||||
|
|
||||||||||
| ### Global Threshold Configuration | ||||||||||
|
|
||||||||||
|
|
@@ -97,7 +98,8 @@ Use incident-level overrides when: | |||||||||
| 3. Enable **Override Global Thresholds** | ||||||||||
| 4. Set custom values | ||||||||||
|
|
||||||||||
|  | ||||||||||
| <!-- <!-- TODO: Add screenshot: Incident alert configuration tab --> | ||||||||||
| <!--  --> --> | ||||||||||
|
|
||||||||||
| | Field | Description | Example Use Case | | ||||||||||
| |-------|-------------|------------------| | ||||||||||
|
|
@@ -195,7 +197,8 @@ Items with lot expiration dates within the warning period (default: 30 days). | |||||||||
| 3. Lots must have **Expiration Date** set | ||||||||||
| 4. Stock must be in a **DRIMS warehouse** | ||||||||||
|
|
||||||||||
|  | ||||||||||
| <!-- <!-- TODO: Add screenshot: Product expiry configuration --> | ||||||||||
| <!--  --> --> | ||||||||||
|
|
||||||||||
| **Example Scenario:** | ||||||||||
|
|
||||||||||
|
|
@@ -280,7 +283,8 @@ Warehouses automatically calculate health status based on active alerts: | |||||||||
| | **Warning** | 1-2 active alerts OR capacity <30% | Orange | | ||||||||||
| | **Good** | No active alerts, adequate stock | Green | | ||||||||||
|
|
||||||||||
|  | ||||||||||
| <!-- <!-- TODO: Add screenshot: Warehouse health dashboard --> | ||||||||||
| <!--  --> --> | ||||||||||
|
|
||||||||||
| ### Alert Dashboard | ||||||||||
|
|
||||||||||
|
|
@@ -293,7 +297,8 @@ Filter by: | |||||||||
| - **Warehouse** | ||||||||||
| - **Incident** | ||||||||||
|
|
||||||||||
|  | ||||||||||
| <!-- <!-- TODO: Add screenshot: Alert dashboard with filters --> | ||||||||||
| <!--  --> --> | ||||||||||
|
|
||||||||||
| ## Responding to Alerts | ||||||||||
|
|
||||||||||
|
|
@@ -307,7 +312,8 @@ When you start investigating an alert: | |||||||||
|
|
||||||||||
| This removes the alert from "urgent" views but keeps it tracked. | ||||||||||
|
|
||||||||||
|  | ||||||||||
| <!-- <!-- TODO: Add screenshot: Acknowledge alert button --> | ||||||||||
| <!--  --> --> | ||||||||||
|
|
||||||||||
| ### Resolving Alerts | ||||||||||
|
|
||||||||||
|
|
@@ -320,7 +326,8 @@ When the underlying issue is fixed: | |||||||||
|
|
||||||||||
| Resolved alerts are archived but remain in reporting for analysis. | ||||||||||
|
|
||||||||||
|  | ||||||||||
| <!-- <!-- TODO: Add screenshot: Resolve alert button --> | ||||||||||
| <!--  --> --> | ||||||||||
|
|
||||||||||
| ### Alert Activity Feed | ||||||||||
|
|
||||||||||
|
|
@@ -373,7 +380,8 @@ You cannot manually change priority. To get different priority: | |||||||||
| 3. **Resolve stale alerts** - Clean up alerts for issues that were fixed but not marked resolved | ||||||||||
| 4. **Filter dashboards** - Use priority filters to focus on Critical and High alerts only | ||||||||||
|
|
||||||||||
|  | ||||||||||
| <!-- <!-- TODO: Add screenshot: Alert filters set to Critical and High --> | ||||||||||
| <!--  --> --> | ||||||||||
|
|
||||||||||
| ### Alert Created But Condition Resolved | ||||||||||
|
|
||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this patch for
werkzeug.routing.NumberConverteris a clever and necessary workaround for building the documentation with newer dependencies, it's worth noting that monkey-patching a library like this can be fragile. It might be beneficial to add a comment pointing to an upstream issue or discussion in Odoo or Werkzeug if one exists, to track a more permanent solution. This would help future maintainers understand the context and eventually remove the patch when it's no longer needed.