[IMP] Icons#809
Merged
Merged
Conversation
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 17.0 #809 +/- ##
==========================================
+ Coverage 77.88% 77.90% +0.01%
==========================================
Files 763 765 +2
Lines 19853 19886 +33
Branches 2383 2386 +3
==========================================
+ Hits 15463 15492 +29
- Misses 3835 3838 +3
- Partials 555 556 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
Bot
requested review from
gonzalesedwin1123,
jeremi and
reichie020212
|
reichie020212
approved these changes
Jun 4, 2025
Member
|
@claude review this PR |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Member
|
@claude review this PR |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Member
|
@emjay0921 please check the conflict |
emjay0921
force-pushed
the
802-replace-icons
branch
from
ae5b31b to
faaca53
Compare
|
gonzalesedwin1123
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
To improve the icons for Menus for SP-MIS and SP-Farmer
How was the change implemented?
Changed the menus icons via XML Data, inheriting/overriding the Menus' Icons
New unit tests
Unit tests executed by the author
How to test manually
Related links
#802