Skip to content

[NEW] Base Module Restructure#846

Merged
gonzalesedwin1123 merged 51 commits into
17.0from
base-module-restructure
Sep 30, 2025
Merged

[NEW] Base Module Restructure#846
gonzalesedwin1123 merged 51 commits into
17.0from
base-module-restructure

Conversation

@emjay0921
Copy link
Copy Markdown
Contributor

@emjay0921 emjay0921 commented Sep 22, 2025

Why is this change needed?

Restructure the Base Modules

  • spp_base_common
  • spp_base_spmis
  • spp_base_farmer_registry
  • spp_base_social_registry

How was the change implemented?

Created and modified the existing base modules, and fixed all dependencies and access rights.

New unit tests

Unit tests executed by the author

How to test manually

Related links

@emjay0921 emjay0921 changed the title [NEW] spp_base_common [NEW] Base Module Restructure Sep 22, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 78.31325% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.98%. Comparing base (a8c1e8f) to head (233478c).
⚠️ Report is 11 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_area/models/user.py 46.15% 11 Missing and 3 partials ⚠️
spp_area_base/models/area_import.py 73.68% 8 Missing and 2 partials ⚠️
spp_area/models/role.py 66.66% 5 Missing ⚠️
spp_hide_menus_base/models/ir_module_module.py 87.50% 2 Missing and 1 partial ⚠️
spp_base_farmer_registry/models/base_import.py 0.00% 1 Missing ⚠️
spp_base_spmis/models/spp_unique_id.py 50.00% 1 Missing ⚠️
...t_create_farm/models/change_request_create_farm.py 0.00% 0 Missing and 1 partial ⚠️
...armer_registry_demo/models/generate_farmer_data.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #846      +/-   ##
==========================================
+ Coverage   77.90%   77.98%   +0.07%     
==========================================
  Files         765      768       +3     
  Lines       19886    19962      +76     
  Branches     2386     2398      +12     
==========================================
+ Hits        15493    15567      +74     
- Misses       3837     3843       +6     
+ Partials      556      552       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emjay0921 emjay0921 marked this pull request as ready for review September 26, 2025 02:35
@emjay0921 emjay0921 marked this pull request as draft September 26, 2025 02:36
@emjay0921 emjay0921 marked this pull request as ready for review September 29, 2025 06:17
@emjay0921 emjay0921 removed the request for review from reichie020212 September 29, 2025 06:17
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
12 Security Hotspots

See analysis details on SonarQube Cloud

@gonzalesedwin1123 gonzalesedwin1123 merged commit f8a5832 into 17.0 Sep 30, 2025
10 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2025
@gonzalesedwin1123 gonzalesedwin1123 deleted the base-module-restructure branch October 8, 2025 00:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants